1
1
mirror of https://github.com/go-gitea/gitea synced 2024-11-05 17:54:26 +00:00
gitea/modules/migrations
zeripath 86863ae939
Prevent timer leaks in Workerpool and others (#11333) (#11340)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-09 00:18:39 +08:00
..
base Fix missing updated time on migrated issues and comments (#9744) (#9764) 2020-01-14 17:55:03 +01:00
error.go Improve migrations to support migrating milestones/labels/issues/comments/pullrequests (#6290) 2019-05-07 09:12:51 +08:00
git.go Sleep longer if request speed is over github limitation (#9335) 2019-12-16 23:16:54 -05:00
gitea_test.go Sleep longer if request speed is over github limitation (#9335) 2019-12-16 23:16:54 -05:00
gitea.go Fix missing updated time on migrated issues and comments (#9744) (#9764) 2020-01-14 17:55:03 +01:00
github_test.go [Backport] CI optimisation & add github token env var (#9875) 2020-01-19 23:21:54 +01:00
github.go Prevent timer leaks in Workerpool and others (#11333) (#11340) 2020-05-09 00:18:39 +08:00
main_test.go Improve migrations to support migrating milestones/labels/issues/comments/pullrequests (#6290) 2019-05-07 09:12:51 +08:00
migrate.go Use OriginalURL insead of CloneAddr in migration logging (#9418) 2019-12-18 16:49:56 -05:00
update.go Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00