1
1
mirror of https://github.com/go-gitea/gitea synced 2024-11-05 17:54:26 +00:00
gitea/modules/util
zeripath 86863ae939
Prevent timer leaks in Workerpool and others (#11333) (#11340)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-09 00:18:39 +08:00
..
compare.go Enable Uploading/Removing Attachments When Editing an Issue/Comment (#8426) 2019-10-15 13:19:32 +01:00
path.go Stop using git count-objects and use raw directory size for repository (#8848) 2019-11-10 21:33:47 +00:00
sanitize_test.go Sanitize credentials in mirror form (#9975) (#9991) 2020-01-26 08:16:53 +00:00
sanitize.go Sanitize credentials in mirror form (#9975) (#9991) 2020-01-26 08:16:53 +00:00
timer.go Prevent timer leaks in Workerpool and others (#11333) (#11340) 2020-05-09 00:18:39 +08:00
url.go Handle insecure and ports in go get (#7041) 2019-05-27 22:08:38 +01:00
util_test.go Convert EOL to UNIX-style to render MD properly (#8925) 2019-11-13 03:27:11 +01:00
util.go Convert EOL to UNIX-style to render MD properly (#8925) 2019-11-13 03:27:11 +01:00