mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			88 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			88 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package repo
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models"
 | |
| 	"code.gitea.io/gitea/modules/context"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/modules/test"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestRepoEdit(t *testing.T) {
 | |
| 	models.PrepareTestEnv(t)
 | |
| 
 | |
| 	ctx := test.MockContext(t, "user2/repo1")
 | |
| 	test.LoadRepo(t, ctx, 1)
 | |
| 	test.LoadUser(t, ctx, 2)
 | |
| 	ctx.Repo.Owner = ctx.User
 | |
| 	description := "new description"
 | |
| 	website := "http://wwww.newwebsite.com"
 | |
| 	private := true
 | |
| 	hasIssues := false
 | |
| 	hasWiki := false
 | |
| 	defaultBranch := "master"
 | |
| 	hasPullRequests := true
 | |
| 	ignoreWhitespaceConflicts := true
 | |
| 	allowMerge := false
 | |
| 	allowRebase := false
 | |
| 	allowRebaseMerge := false
 | |
| 	allowSquashMerge := false
 | |
| 	archived := true
 | |
| 	opts := api.EditRepoOption{
 | |
| 		Name:                      &ctx.Repo.Repository.Name,
 | |
| 		Description:               &description,
 | |
| 		Website:                   &website,
 | |
| 		Private:                   &private,
 | |
| 		HasIssues:                 &hasIssues,
 | |
| 		HasWiki:                   &hasWiki,
 | |
| 		DefaultBranch:             &defaultBranch,
 | |
| 		HasPullRequests:           &hasPullRequests,
 | |
| 		IgnoreWhitespaceConflicts: &ignoreWhitespaceConflicts,
 | |
| 		AllowMerge:                &allowMerge,
 | |
| 		AllowRebase:               &allowRebase,
 | |
| 		AllowRebaseMerge:          &allowRebaseMerge,
 | |
| 		AllowSquash:               &allowSquashMerge,
 | |
| 		Archived:                  &archived,
 | |
| 	}
 | |
| 
 | |
| 	var apiCtx = &context.APIContext{Context: ctx, Org: nil}
 | |
| 	web.SetForm(apiCtx, &opts)
 | |
| 	Edit(apiCtx)
 | |
| 
 | |
| 	assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
 | |
| 	models.AssertExistsAndLoadBean(t, &models.Repository{
 | |
| 		ID: 1,
 | |
| 	}, models.Cond("name = ? AND is_archived = 1", *opts.Name))
 | |
| }
 | |
| 
 | |
| func TestRepoEditNameChange(t *testing.T) {
 | |
| 	models.PrepareTestEnv(t)
 | |
| 
 | |
| 	ctx := test.MockContext(t, "user2/repo1")
 | |
| 	test.LoadRepo(t, ctx, 1)
 | |
| 	test.LoadUser(t, ctx, 2)
 | |
| 	ctx.Repo.Owner = ctx.User
 | |
| 	name := "newname"
 | |
| 	opts := api.EditRepoOption{
 | |
| 		Name: &name,
 | |
| 	}
 | |
| 
 | |
| 	var apiCtx = &context.APIContext{Context: ctx, Org: nil}
 | |
| 	web.SetForm(apiCtx, &opts)
 | |
| 	Edit(apiCtx)
 | |
| 	assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
 | |
| 
 | |
| 	models.AssertExistsAndLoadBean(t, &models.Repository{
 | |
| 		ID: 1,
 | |
| 	}, models.Cond("name = ?", opts.Name))
 | |
| }
 |