mirror of
https://github.com/go-gitea/gitea
synced 2025-11-04 05:18:25 +00:00
716fcfcf72
A lot of our code is repeatedly testing if individual errors are specific types of Not Exist errors. This is repetitative and unnecesary. `Unwrap() error` provides a common way of labelling an error as a NotExist error and we can/should use this. This PR has chosen to use the common `io/fs` errors e.g. `fs.ErrNotExist` for our errors. This is in some ways not completely correct as these are not filesystem errors but it seems like a reasonable thing to do and would allow us to simplify a lot of our code to `errors.Is(err, fs.ErrNotExist)` instead of `package.IsErr...NotExist(err)` I am open to suggestions to use a different base error - perhaps `models/db.ErrNotExist` if that would be felt to be better. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: delvh <dev.lh@web.de>
54 lines
1.4 KiB
Go
54 lines
1.4 KiB
Go
// Copyright 2022 Gitea. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package foreignreference
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
// ErrLocalIndexNotExist represents a "LocalIndexNotExist" kind of error.
|
|
type ErrLocalIndexNotExist struct {
|
|
RepoID int64
|
|
ForeignIndex int64
|
|
Type string
|
|
}
|
|
|
|
// ErrLocalIndexNotExist checks if an error is a ErrLocalIndexNotExist.
|
|
func IsErrLocalIndexNotExist(err error) bool {
|
|
_, ok := err.(ErrLocalIndexNotExist)
|
|
return ok
|
|
}
|
|
|
|
func (err ErrLocalIndexNotExist) Error() string {
|
|
return fmt.Sprintf("repository %d has no LocalIndex for ForeignIndex %d of type %s", err.RepoID, err.ForeignIndex, err.Type)
|
|
}
|
|
|
|
func (err ErrLocalIndexNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|
|
|
|
// ErrForeignIndexNotExist represents a "ForeignIndexNotExist" kind of error.
|
|
type ErrForeignIndexNotExist struct {
|
|
RepoID int64
|
|
LocalIndex int64
|
|
Type string
|
|
}
|
|
|
|
// ErrForeignIndexNotExist checks if an error is a ErrForeignIndexNotExist.
|
|
func IsErrForeignIndexNotExist(err error) bool {
|
|
_, ok := err.(ErrForeignIndexNotExist)
|
|
return ok
|
|
}
|
|
|
|
func (err ErrForeignIndexNotExist) Error() string {
|
|
return fmt.Sprintf("repository %d has no ForeignIndex for LocalIndex %d of type %s", err.RepoID, err.LocalIndex, err.Type)
|
|
}
|
|
|
|
func (err ErrForeignIndexNotExist) Unwrap() error {
|
|
return util.ErrNotExist
|
|
}
|