1
1
mirror of https://github.com/go-gitea/gitea synced 2024-11-05 17:54:26 +00:00
gitea/services
Kemal Zebari 242b331260
Prevent re-review and dismiss review actions on closed and merged PRs (#30065)
Resolves #29965.

---
Manually tested this by:
- Following the
[installation](https://docs.gitea.com/next/installation/install-with-docker#basics)
guide (but built a local Docker image instead)
- Creating 2 users, one who is the `Owner` of a newly-created repository
and the other a `Collaborator`
- Had the `Collaborator` create a PR that the `Owner` reviews
- `Collaborator` resolves conversation and `Owner` merges PR

And with this change we see that we can no longer see re-request review
button for the `Owner`:

<img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM"
src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4">
2024-03-28 15:19:24 +00:00
..
actions Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
agit A small refactor for agit implementation (#29614) 2024-03-06 05:52:48 +00:00
asymkey Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
attachment Add support for API blob upload of release attachments (#29507) 2024-03-02 17:02:01 +00:00
auth Migrate margin and padding helpers to tailwind (#30043) 2024-03-24 17:42:49 +01:00
automerge Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
context Refactor external URL detection (#29973) 2024-03-22 04:32:40 +08:00
contexttest Make "/user/login" page redirect if the current user has signed in (#29583) 2024-03-05 02:12:03 +00:00
convert Performance improvements for pull request list page (#29900) 2024-03-21 14:13:08 +01:00
cron Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
doctor Fix gitea doctor will remove repo-avatar files when execute command storage-archives (#30094) 2024-03-26 08:24:13 +00:00
externalaccount Revert "Support SAML authentication (#25165)" (#29358) 2024-02-24 12:18:49 +08:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Add a warning for disallowed email domains (#29658) 2024-03-11 06:07:36 +00:00
gitdiff Fix incorrect diff expander for deletion of last lines in a file (#29501) 2024-03-01 16:12:21 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue Fix Add/Remove WIP on pull request title failure (#29999) 2024-03-25 15:51:23 +08:00
lfs Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
mailer Use relative links for commits, mentions, and issues in markdown (#29427) 2024-03-13 10:34:58 +00:00
markup Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrations Fix duplicate migrated milestones (#30102) 2024-03-26 10:20:26 +00:00
mirror Use repo object format name instead of detecting from git repository (#29702) 2024-03-10 22:30:36 +01:00
notify Update status and code index after changing the default branch (#27018) 2023-09-13 04:43:31 +00:00
org Delete repos of org when purge delete user (#27273) 2023-10-19 13:16:11 +00:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
release Use repo object format name instead of detecting from git repository (#29702) 2024-03-10 22:30:36 +01:00
repository Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Skip email domain check when admins edit user emails (#29609) 2024-03-05 16:51:56 +00:00
webhook Fix possible data race on tests (#30093) 2024-03-26 14:08:30 +00:00
wiki Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-08 15:30:10 +08:00