1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 01:54:26 +00:00
gitea/services
Giteabot ec3f5f9992
Move database operations of merging a pull request to post receive hook and add a transaction (#30805) (#30888)
Backport #30805 by @lunny

Merging PR may fail because of various problems. The pull request may
have a dirty state because there is no transaction when merging a pull
request. ref
https://github.com/go-gitea/gitea/pull/25741#issuecomment-2074126393

This PR moves all database update operations to post-receive handler for
merging a pull request and having a database transaction. That means if
database operations fail, then the git merging will fail, the git client
will get a fail result.

There are already many tests for pull request merging, so we don't need
to add a new one.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-05-08 14:17:18 +00:00
..
actions feat(api): enhance Actions Secrets Management API for repository (#30656) 2024-04-26 21:11:49 +08:00
agit Performance optimization for git push (#30104) 2024-04-09 03:43:17 +00:00
asymkey Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
attachment Add support for API blob upload of release attachments (#29507) 2024-03-02 17:02:01 +00:00
auth Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
automerge Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
context Refactor AppURL usage (#30885) (#30891) 2024-05-08 13:34:43 +00:00
contexttest Move database operations of merging a pull request to post receive hook and add a transaction (#30805) (#30888) 2024-05-08 14:17:18 +00:00
convert Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
cron Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
doctor Add a db consistency check to remove runners that do not belong to a repository (#30614) 2024-04-23 03:51:52 +00:00
externalaccount Revert "Support SAML authentication (#25165)" (#29358) 2024-02-24 12:18:49 +08:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Initial support for colorblindness-friendly themes (#30625) 2024-04-24 00:18:41 +08:00
gitdiff Make sure git version&feature are always prepared (#30877) (#30879) 2024-05-07 02:07:33 +00:00
indexer Fix missing issue search index update when changing status (#28325) 2023-12-03 12:22:44 +01:00
issue Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
lfs Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
mailer Fix incorrect message id for release email (#30825) (#30833) 2024-05-03 00:00:29 +08:00
markup Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
migrations Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
mirror Remove unused parameter for some functions in services/mirror (#30724) 2024-04-27 10:44:49 +00:00
notify Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
org Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull Move database operations of merging a pull request to post receive hook and add a transaction (#30805) (#30888) 2024-05-08 14:17:18 +00:00
release Use repo object format name instead of detecting from git repository (#29702) 2024-03-10 22:30:36 +01:00
repository Make sure git version&feature are always prepared (#30877) (#30879) 2024-05-07 02:07:33 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix incorrect ctx usage in defer function (#27740) 2023-10-22 14:12:27 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
webhook Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
webtheme Initial support for colorblindness-friendly themes (#30625) 2024-04-24 00:18:41 +08:00
wiki Avoid showing Failed to change the default wiki branch if repo has no wiki when saving repo settings (#30329) 2024-04-08 19:43:23 +08:00