mirror of
https://github.com/go-gitea/gitea
synced 2025-01-25 09:04:29 +00:00
34dfc25b83
close #33086 * Add a special value for "SSH_USER" setting: `(DOER_USERNAME)` * Improve parseRepositoryURL and add tests (now it doesn't have hard dependency on some setting values) Many changes are just adding "ctx" and "doer" argument to functions. By the way, improve app.example.ini, remove all `%(key)s` syntax, it only makes messy and no user really cares about it. Document: https://gitea.com/gitea/docs/pulls/138
300 lines
10 KiB
Go
300 lines
10 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package repo
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unit"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/httplib"
|
|
"code.gitea.io/gitea/modules/markup"
|
|
"code.gitea.io/gitea/modules/optional"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
var (
|
|
countRepospts = CountRepositoryOptions{OwnerID: 10}
|
|
countReposptsPublic = CountRepositoryOptions{OwnerID: 10, Private: optional.Some(false)}
|
|
countReposptsPrivate = CountRepositoryOptions{OwnerID: 10, Private: optional.Some(true)}
|
|
)
|
|
|
|
func TestGetRepositoryCount(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
ctx := db.DefaultContext
|
|
count, err1 := CountRepositories(ctx, countRepospts)
|
|
privateCount, err2 := CountRepositories(ctx, countReposptsPrivate)
|
|
publicCount, err3 := CountRepositories(ctx, countReposptsPublic)
|
|
assert.NoError(t, err1)
|
|
assert.NoError(t, err2)
|
|
assert.NoError(t, err3)
|
|
assert.Equal(t, int64(3), count)
|
|
assert.Equal(t, privateCount+publicCount, count)
|
|
}
|
|
|
|
func TestGetPublicRepositoryCount(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
count, err := CountRepositories(db.DefaultContext, countReposptsPublic)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(1), count)
|
|
}
|
|
|
|
func TestGetPrivateRepositoryCount(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
count, err := CountRepositories(db.DefaultContext, countReposptsPrivate)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, int64(2), count)
|
|
}
|
|
|
|
func TestRepoAPIURL(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
repo := unittest.AssertExistsAndLoadBean(t, &Repository{ID: 10})
|
|
|
|
assert.Equal(t, "https://try.gitea.io/api/v1/repos/user12/repo10", repo.APIURL())
|
|
}
|
|
|
|
func TestWatchRepo(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &Repository{ID: 3})
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
|
|
assert.NoError(t, WatchRepo(db.DefaultContext, user, repo, true))
|
|
unittest.AssertExistsAndLoadBean(t, &Watch{RepoID: repo.ID, UserID: user.ID})
|
|
unittest.CheckConsistencyFor(t, &Repository{ID: repo.ID})
|
|
|
|
assert.NoError(t, WatchRepo(db.DefaultContext, user, repo, false))
|
|
unittest.AssertNotExistsBean(t, &Watch{RepoID: repo.ID, UserID: user.ID})
|
|
unittest.CheckConsistencyFor(t, &Repository{ID: repo.ID})
|
|
}
|
|
|
|
func TestMetas(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := &Repository{Name: "testRepo"}
|
|
repo.Owner = &user_model.User{Name: "testOwner"}
|
|
repo.OwnerName = repo.Owner.Name
|
|
|
|
repo.Units = nil
|
|
|
|
metas := repo.ComposeMetas(db.DefaultContext)
|
|
assert.Equal(t, "testRepo", metas["repo"])
|
|
assert.Equal(t, "testOwner", metas["user"])
|
|
|
|
externalTracker := RepoUnit{
|
|
Type: unit.TypeExternalTracker,
|
|
Config: &ExternalTrackerConfig{
|
|
ExternalTrackerFormat: "https://someurl.com/{user}/{repo}/{issue}",
|
|
},
|
|
}
|
|
|
|
testSuccess := func(expectedStyle string) {
|
|
repo.Units = []*RepoUnit{&externalTracker}
|
|
repo.commonRenderingMetas = nil
|
|
metas := repo.ComposeMetas(db.DefaultContext)
|
|
assert.Equal(t, expectedStyle, metas["style"])
|
|
assert.Equal(t, "testRepo", metas["repo"])
|
|
assert.Equal(t, "testOwner", metas["user"])
|
|
assert.Equal(t, "https://someurl.com/{user}/{repo}/{issue}", metas["format"])
|
|
}
|
|
|
|
testSuccess(markup.IssueNameStyleNumeric)
|
|
|
|
externalTracker.ExternalTrackerConfig().ExternalTrackerStyle = markup.IssueNameStyleAlphanumeric
|
|
testSuccess(markup.IssueNameStyleAlphanumeric)
|
|
|
|
externalTracker.ExternalTrackerConfig().ExternalTrackerStyle = markup.IssueNameStyleNumeric
|
|
testSuccess(markup.IssueNameStyleNumeric)
|
|
|
|
externalTracker.ExternalTrackerConfig().ExternalTrackerStyle = markup.IssueNameStyleRegexp
|
|
testSuccess(markup.IssueNameStyleRegexp)
|
|
|
|
repo, err := GetRepositoryByID(db.DefaultContext, 3)
|
|
assert.NoError(t, err)
|
|
|
|
metas = repo.ComposeMetas(db.DefaultContext)
|
|
assert.Contains(t, metas, "org")
|
|
assert.Contains(t, metas, "teams")
|
|
assert.Equal(t, "org3", metas["org"])
|
|
assert.Equal(t, ",owners,team1,", metas["teams"])
|
|
}
|
|
|
|
func TestParseRepositoryURLPathSegments(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.AppURL, "https://localhost:3000")()
|
|
|
|
ctxURL, _ := url.Parse("https://gitea")
|
|
ctxReq := &http.Request{URL: ctxURL, Header: http.Header{}}
|
|
ctxReq.Host = ctxURL.Host
|
|
ctxReq.Header.Add("X-Forwarded-Proto", ctxURL.Scheme)
|
|
ctx := context.WithValue(context.Background(), httplib.RequestContextKey, ctxReq)
|
|
cases := []struct {
|
|
input string
|
|
ownerName, repoName, remaining string
|
|
}{
|
|
{input: "/user/repo"},
|
|
|
|
{input: "https://localhost:3000/user/repo", ownerName: "user", repoName: "repo"},
|
|
{input: "https://external:3000/user/repo"},
|
|
|
|
{input: "https://localhost:3000/user/repo.git/other", ownerName: "user", repoName: "repo", remaining: "/other"},
|
|
|
|
{input: "https://gitea/user/repo", ownerName: "user", repoName: "repo"},
|
|
{input: "https://gitea:3333/user/repo"},
|
|
|
|
{input: "ssh://try.gitea.io:2222/user/repo", ownerName: "user", repoName: "repo"},
|
|
{input: "ssh://external:2222/user/repo"},
|
|
|
|
{input: "git+ssh://user@try.gitea.io/user/repo.git", ownerName: "user", repoName: "repo"},
|
|
{input: "git+ssh://user@external/user/repo.git"},
|
|
|
|
{input: "root@try.gitea.io:user/repo.git", ownerName: "user", repoName: "repo"},
|
|
{input: "root@gitea:user/repo.git", ownerName: "user", repoName: "repo"},
|
|
{input: "root@external:user/repo.git"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.input, func(t *testing.T) {
|
|
ret := parseRepositoryURL(ctx, c.input)
|
|
assert.Equal(t, c.ownerName, ret.OwnerName)
|
|
assert.Equal(t, c.repoName, ret.RepoName)
|
|
assert.Equal(t, c.remaining, ret.RemainingPath)
|
|
})
|
|
}
|
|
|
|
t.Run("WithSubpath", func(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.AppURL, "https://localhost:3000/subpath")()
|
|
defer test.MockVariableValue(&setting.AppSubURL, "/subpath")()
|
|
cases = []struct {
|
|
input string
|
|
ownerName, repoName, remaining string
|
|
}{
|
|
{input: "https://localhost:3000/user/repo"},
|
|
{input: "https://localhost:3000/subpath/user/repo.git/other", ownerName: "user", repoName: "repo", remaining: "/other"},
|
|
|
|
{input: "ssh://try.gitea.io:2222/user/repo", ownerName: "user", repoName: "repo"},
|
|
{input: "ssh://external:2222/user/repo"},
|
|
|
|
{input: "git+ssh://user@try.gitea.io/user/repo.git", ownerName: "user", repoName: "repo"},
|
|
{input: "git+ssh://user@external/user/repo.git"},
|
|
|
|
{input: "root@try.gitea.io:user/repo.git", ownerName: "user", repoName: "repo"},
|
|
{input: "root@external:user/repo.git"},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
t.Run(c.input, func(t *testing.T) {
|
|
ret := parseRepositoryURL(ctx, c.input)
|
|
assert.Equal(t, c.ownerName, ret.OwnerName)
|
|
assert.Equal(t, c.repoName, ret.RepoName)
|
|
assert.Equal(t, c.remaining, ret.RemainingPath)
|
|
})
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestGetRepositoryByURL(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
t.Run("InvalidPath", func(t *testing.T) {
|
|
repo, err := GetRepositoryByURL(db.DefaultContext, "something")
|
|
assert.Nil(t, repo)
|
|
assert.Error(t, err)
|
|
})
|
|
|
|
testRepo2 := func(t *testing.T, url string) {
|
|
repo, err := GetRepositoryByURL(db.DefaultContext, url)
|
|
require.NoError(t, err)
|
|
assert.EqualValues(t, 2, repo.ID)
|
|
assert.EqualValues(t, 2, repo.OwnerID)
|
|
}
|
|
|
|
t.Run("ValidHttpURL", func(t *testing.T) {
|
|
testRepo2(t, "https://try.gitea.io/user2/repo2")
|
|
testRepo2(t, "https://try.gitea.io/user2/repo2.git")
|
|
})
|
|
|
|
t.Run("ValidGitSshURL", func(t *testing.T) {
|
|
testRepo2(t, "git+ssh://sshuser@try.gitea.io/user2/repo2")
|
|
testRepo2(t, "git+ssh://sshuser@try.gitea.io/user2/repo2.git")
|
|
|
|
testRepo2(t, "git+ssh://try.gitea.io/user2/repo2")
|
|
testRepo2(t, "git+ssh://try.gitea.io/user2/repo2.git")
|
|
})
|
|
|
|
t.Run("ValidImplicitSshURL", func(t *testing.T) {
|
|
testRepo2(t, "sshuser@try.gitea.io:user2/repo2")
|
|
testRepo2(t, "sshuser@try.gitea.io:user2/repo2.git")
|
|
|
|
testRelax := func(t *testing.T, url string) {
|
|
repo, err := GetRepositoryByURLRelax(db.DefaultContext, url)
|
|
require.NoError(t, err)
|
|
assert.Equal(t, int64(2), repo.ID)
|
|
assert.Equal(t, int64(2), repo.OwnerID)
|
|
}
|
|
// TODO: it doesn't seem to be common git ssh URL, should we really support this?
|
|
testRelax(t, "try.gitea.io:user2/repo2")
|
|
testRelax(t, "try.gitea.io:user2/repo2.git")
|
|
})
|
|
}
|
|
|
|
func TestComposeSSHCloneURL(t *testing.T) {
|
|
defer test.MockVariableValue(&setting.SSH, setting.SSH)()
|
|
defer test.MockVariableValue(&setting.Repository, setting.Repository)()
|
|
|
|
setting.SSH.User = "git"
|
|
|
|
// test SSH_DOMAIN
|
|
setting.SSH.Domain = "domain"
|
|
setting.SSH.Port = 22
|
|
setting.Repository.UseCompatSSHURI = false
|
|
assert.Equal(t, "git@domain:user/repo.git", ComposeSSHCloneURL(&user_model.User{Name: "doer"}, "user", "repo"))
|
|
setting.Repository.UseCompatSSHURI = true
|
|
assert.Equal(t, "ssh://git@domain/user/repo.git", ComposeSSHCloneURL(&user_model.User{Name: "doer"}, "user", "repo"))
|
|
// test SSH_DOMAIN while use non-standard SSH port
|
|
setting.SSH.Port = 123
|
|
setting.Repository.UseCompatSSHURI = false
|
|
assert.Equal(t, "ssh://git@domain:123/user/repo.git", ComposeSSHCloneURL(nil, "user", "repo"))
|
|
setting.Repository.UseCompatSSHURI = true
|
|
assert.Equal(t, "ssh://git@domain:123/user/repo.git", ComposeSSHCloneURL(nil, "user", "repo"))
|
|
|
|
// test IPv6 SSH_DOMAIN
|
|
setting.Repository.UseCompatSSHURI = false
|
|
setting.SSH.Domain = "::1"
|
|
setting.SSH.Port = 22
|
|
assert.Equal(t, "git@[::1]:user/repo.git", ComposeSSHCloneURL(nil, "user", "repo"))
|
|
setting.SSH.Port = 123
|
|
assert.Equal(t, "ssh://git@[::1]:123/user/repo.git", ComposeSSHCloneURL(nil, "user", "repo"))
|
|
|
|
setting.SSH.User = "(DOER_USERNAME)"
|
|
setting.SSH.Domain = "domain"
|
|
setting.SSH.Port = 22
|
|
assert.Equal(t, "doer@domain:user/repo.git", ComposeSSHCloneURL(&user_model.User{Name: "doer"}, "user", "repo"))
|
|
setting.SSH.Port = 123
|
|
assert.Equal(t, "ssh://doer@domain:123/user/repo.git", ComposeSSHCloneURL(&user_model.User{Name: "doer"}, "user", "repo"))
|
|
}
|
|
|
|
func TestIsUsableRepoName(t *testing.T) {
|
|
assert.NoError(t, IsUsableRepoName("a"))
|
|
assert.NoError(t, IsUsableRepoName("-1_."))
|
|
assert.NoError(t, IsUsableRepoName(".profile"))
|
|
|
|
assert.Error(t, IsUsableRepoName("-"))
|
|
assert.Error(t, IsUsableRepoName("🌞"))
|
|
assert.Error(t, IsUsableRepoName("the..repo"))
|
|
assert.Error(t, IsUsableRepoName("foo.wiki"))
|
|
assert.Error(t, IsUsableRepoName("foo.git"))
|
|
}
|