1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-25 01:54:26 +00:00
gitea/integrations
zeripath 320031fce6
Handle more pathological branch and tag names (#11843) (#11863)
Backport #11843

It's possible to push quite pathological appearing branch names to gitea
using git push gitea reasonable-branch:refs/heads/-- at which point
large parts of the UI will break. Similarly you can git push origin
reasonable-tag:refs/tags/-- which wil return an error.

This PR fixes the problems these cause. It also changes the code from
creating branches to pushing to ensure that branch restoration has to
pass hooks.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-06-12 14:01:44 -04:00
..
gitea-repositories-meta Avoiding directory execution on hook (#10954) (#10955) 2020-04-04 11:29:58 -05:00
migration-test Cache PullRequest Divergence (#10914) 2020-04-14 09:53:34 -04:00
api_admin_org_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_admin_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_branch_test.go Slight performance changes to integrations/git_test.go (#11227) 2020-04-27 14:20:09 +03:00
api_comment_test.go [API] Add "before" query to ListIssueComments and ListRepoIssue… (#9685) 2020-01-13 17:02:24 +01:00
api_fork_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_gpg_keys_test.go Handle expected errors in AddGPGkey API (#11644) (#11661) 2020-05-28 18:16:41 -04:00
api_helper_for_declarative_test.go Correctly set the organization num repos (#11339) 2020-05-12 01:04:08 +03:00
api_issue_label_test.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
api_issue_milestone_test.go Fix milestone API state parameter unhandled (#10049) 2020-01-29 08:36:32 +02:00
api_issue_reaction_test.go [API] Fix 9544 | return 200 when reaction already exist (#9550) 2019-12-31 03:21:21 -05:00
api_issue_stopwatch_test.go [API] extend StopWatch (#9196) 2019-12-11 23:23:05 -05:00
api_issue_subscription_test.go Return issue subscription status from API subscribe (#10966) 2020-04-30 23:55:24 +01:00
api_issue_test.go [API] ListIssues add filter for milestones (#10148) 2020-04-30 01:15:39 -03:00
api_issue_tracked_time_test.go Fix tracked time issues (#11349) 2020-05-09 11:18:44 -03:00
api_keys_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_notification_test.go [Api] Check Notify (always return json) (#10059) 2020-04-10 19:49:39 -04:00
api_oauth2_apps_test.go Add Get/Update for api/v1/user/applications/oauth2 (#11008) 2020-04-09 19:37:31 -05:00
api_org_test.go [API] add GET /orgs endpoint (#9560) 2020-01-12 23:43:44 +08:00
api_pull_review_test.go API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
api_pull_test.go Add option to API to update PullRequest base branch (#11666) (#11796) 2020-06-07 23:20:53 +03:00
api_releases_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_edit_test.go Api: advanced settings for repository (external wiki, issue tracker etc.) (#7756) 2019-10-02 17:30:41 +08:00
api_repo_file_create_test.go Handle expected errors in FileCreate & FileUpdate API (#11643) (#11718) 2020-06-01 07:28:52 +01:00
api_repo_file_delete_test.go Contents API should return 404 on not exist (#10323) 2020-04-15 02:18:51 -03:00
api_repo_file_helpers.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_repo_file_update_test.go Handle expected errors in FileCreate & FileUpdate API (#11643) (#11718) 2020-06-01 07:28:52 +01:00
api_repo_get_contents_list_test.go Contents API should return 404 on not exist (#10323) 2020-04-15 02:18:51 -03:00
api_repo_get_contents_test.go Contents API should return 404 on not exist (#10323) 2020-04-15 02:18:51 -03:00
api_repo_git_blobs_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_commits_test.go Consolidate API for getting single commit (#11368) 2020-05-11 12:44:36 +03:00
api_repo_git_hook_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_ref_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_tags_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_trees_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_lfs_locks_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_raw_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_tags_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_test.go Honor DEFAULT_PAGING_NUM for API (#11805) (#11813) 2020-06-09 16:05:21 +03:00
api_repo_topic_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_team_test.go [API] orgEditTeam make Fields optional (#9556) 2020-01-09 13:15:14 +00:00
api_team_user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_token_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_heatmap_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_orgs_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_search_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
attachment_test.go Fix missing defer prepareTestEnv(t)() on some tests (#9906) 2020-01-21 12:40:21 +01:00
auth_ldap_test.go Refactor Cron and merge dashboard tasks (#10745) 2020-05-16 19:31:38 -04:00
benchmarks_test.go Missed defer prepareTestEnv (#9285) 2019-12-08 01:14:50 +00:00
branches_test.go Handle more pathological branch and tag names (#11843) (#11863) 2020-06-12 14:01:44 -04:00
change_default_branch_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
cmd_keys_test.go In authorized_keys use double-quote for windows compatibility (#10841) 2020-03-27 09:49:39 +02:00
cors_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
create_no_session_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
delete_user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
download_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
editor_test.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
empty_repo_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
eventsource_test.go Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
explore_repos_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
git_helper_for_declarative_test.go Make the PushCreate test declarative (#11229) 2020-04-28 09:32:23 +01:00
git_test.go Make the PushCreate test declarative (#11229) 2020-04-28 09:32:23 +01:00
gpg_git_test.go Fix the intermittent TestGPGGit failures (#9360) 2019-12-15 16:21:16 +00:00
html_helper.go integration tests: Use t.Helper() (#7654) 2019-07-29 12:15:18 +08:00
integration_test.go Reject duplicate AccessToken names (#10994) 2020-04-13 22:02:48 +03:00
issue_test.go Prettify Timeline (#10972) 2020-04-11 01:01:41 +03:00
lfs_getobject_test.go Support Range header end in lfs (#11314) 2020-05-11 11:37:59 +03:00
links_test.go [BugFix] use default avatar for ghost user (fix 500 error) (#9536) 2019-12-29 16:24:50 +02:00
mssql.ini.tmpl Use /tmp for test repositories (#11126) 2020-04-19 14:17:02 +03:00
mysql8.ini.tmpl Use /tmp for test repositories (#11126) 2020-04-19 14:17:02 +03:00
mysql.ini.tmpl Use /tmp for test repositories (#11126) 2020-04-19 14:17:02 +03:00
nonascii_branches_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
oauth_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
org_count_test.go Correctly set the organization num repos (#11339) 2020-05-12 01:04:08 +03:00
org_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pgsql.ini.tmpl Use /tmp for test repositories (#11126) 2020-04-19 14:17:02 +03:00
private-testing.key Fix verification of subkeys of default gpg key (#11713) (#11747) 2020-06-03 18:01:32 +01:00
pull_compare_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pull_create_test.go Prettify Timeline (#10972) 2020-04-11 01:01:41 +03:00
pull_merge_test.go Backport various styling fixes (#11619) 2020-05-25 22:33:57 -04:00
pull_review_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pull_status_test.go Fix wrong hint when status checking is running on pull request view (#9886) 2020-01-22 11:46:04 +08:00
pull_update_test.go Add "Update Branch" button to Pull Requests (#9784) 2020-01-17 08:03:40 +02:00
README_ZH.md Improve integration tests (#8276) 2019-09-25 14:13:18 +02:00
README.md update integration README (#10400) 2020-02-23 00:45:20 +02:00
release_test.go Honor DEFAULT_PAGING_NUM for API (#11805) (#11813) 2020-06-09 16:05:21 +03:00
repo_activity_test.go Fix activity count in TestRepoActivity (#9959) 2020-01-24 13:06:40 +00:00
repo_branch_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_commits_search_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_commits_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_fork_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_generate_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_migrate_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_search_test.go Move code indexer related code to a new package (#9191) 2019-12-08 14:15:35 -05:00
repo_test.go Use local timezone to compare (#10446) 2020-02-25 11:05:00 +08:00
repo_watch_test.go Auto-subscribe user to repository when they commit/tag to it (#7657) 2019-11-10 09:22:19 +00:00
repofiles_delete_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repofiles_update_test.go Code Refactor of IssueWatch related things (#10401) 2020-02-26 03:32:22 -03:00
setting_test.go Add a /user/login landing page option (#9622) 2020-01-06 17:50:44 +01:00
signin_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
signout_test.go Logout POST action (#10582) 2020-03-02 22:50:31 -06:00
signup_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
sqlite.ini.tmpl Use /tmp for test repositories (#11126) 2020-04-19 14:17:02 +03:00
ssh_key_test.go Make the PushCreate test declarative (#11229) 2020-04-28 09:32:23 +01:00
testlogger.go Language statistics bar for repositories (#8037) 2020-02-11 11:34:17 +02:00
timetracking_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
version_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
xss_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00

Integrations tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-mysql
make test-pgsql
make test-sqlite

Make sure to perform a clean build before running tests:

make clean build

Run all tests via local drone

drone exec --local --build-event "pull_request"

Run sqlite integrations tests

Start tests

make test-sqlite

Run mysql integrations tests

Setup a mysql database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:3306 --rm --name mysql mysql:latest #(just ctrl-c to stop db and clean the container)
docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" --rm --name elasticsearch elasticsearch:7.6.0 #(in a secound terminal, just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integrations tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Run mssql integrations tests

Setup a mssql database inside docker

docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSecurePassword1" -p 1433:1433 --rm --name mssql microsoft/mssql-server-linux:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql

Running individual tests

Example command to run GPG test:

For sqlite:

make test-sqlite#GPG

For other databases(replace MSSQL to MYSQL, MYSQL8, PGSQL):

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG