mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 03:18:24 +00:00 
			
		
		
		
	This PR fixes inconsistencies between system and default webhooks in the Gitea API. (See also #26418) - A system webhook is a webhook that captures events for all repositories. - A default webhook is copied to a new repository when it is created. Before this PR `POST /api/v1/admin/hooks/` creates default webhooks (if not configured otherwise) and `GET /api/v1/admin/hooks/` returns system webhooks. The PR introduces an optional query parameter to `GET /api/v1/admin/hooks/` to enable selecting if either default, system or both kind of webhooks should be retrieved. By default the flag is set to return system webhooks keep current behaviour. ## Examples ### System Webhooks #### Create ``` POST /api/v1/admin/hooks/ { "type": "gitea", "active": false, "branch_filter": "*", "events": [ "create", "..." ], "config": { "url": "http://...", "content_type": "json", "secret": "secret", "is_system_webhook": true // <-- controls hook type } } ``` #### List ``` GET/api/v1/admin/hooks?type=system //type argument is optional here since it's the default ``` #### Others The other relevant endpoints work as expected by referencing the hook by id ``` GET /api/v1/admin/hooks/:id PATCH /api/v1/admin/hooks/:id DELETE /api/v1/admin/hooks/:id ``` ### Default Webhooks #### Create ``` POST /api/v1/admin/hooks/ { "type": "gitea", "active": false, "branch_filter": "*", "events": [ "create", "..." ], "config": { "url": "http://...", "content_type": "json", "secret": "secret", "is_system_webhook": false // optional, as false is the default value } } ``` #### List ``` GET/api/v1/admin/hooks?type=default ``` #### Others The other relevant endpoints work as expected by referencing the hook by id ``` GET /api/v1/admin/hooks/:id PATCH /api/v1/admin/hooks/:id DELETE /api/v1/admin/hooks/:id ```
		
			
				
	
	
		
			197 lines
		
	
	
		
			4.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			197 lines
		
	
	
		
			4.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2021 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package admin
 | |
| 
 | |
| import (
 | |
| 	"errors"
 | |
| 	"net/http"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/webhook"
 | |
| 	"code.gitea.io/gitea/modules/optional"
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 	"code.gitea.io/gitea/routers/api/v1/utils"
 | |
| 	"code.gitea.io/gitea/services/context"
 | |
| 	webhook_service "code.gitea.io/gitea/services/webhook"
 | |
| )
 | |
| 
 | |
| // ListHooks list system's webhooks
 | |
| func ListHooks(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /admin/hooks admin adminListHooks
 | |
| 	// ---
 | |
| 	// summary: List system's webhooks
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: page
 | |
| 	//   in: query
 | |
| 	//   description: page number of results to return (1-based)
 | |
| 	//   type: integer
 | |
| 	// - name: limit
 | |
| 	//   in: query
 | |
| 	//   description: page size of results
 | |
| 	//   type: integer
 | |
| 	// - type: string
 | |
| 	//   enum:
 | |
| 	//     - system
 | |
| 	//     - default
 | |
| 	//     - all
 | |
| 	//   description: system, default or both kinds of webhooks
 | |
| 	//   name: type
 | |
| 	//   default: system
 | |
| 	//   in: query
 | |
| 	//
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/HookList"
 | |
| 
 | |
| 	// for compatibility the default value is true
 | |
| 	isSystemWebhook := optional.Some(true)
 | |
| 	typeValue := ctx.FormString("type")
 | |
| 	if typeValue == "default" {
 | |
| 		isSystemWebhook = optional.Some(false)
 | |
| 	} else if typeValue == "all" {
 | |
| 		isSystemWebhook = optional.None[bool]()
 | |
| 	}
 | |
| 
 | |
| 	sysHooks, err := webhook.GetSystemOrDefaultWebhooks(ctx, isSystemWebhook)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "GetSystemWebhooks", err)
 | |
| 		return
 | |
| 	}
 | |
| 	hooks := make([]*api.Hook, len(sysHooks))
 | |
| 	for i, hook := range sysHooks {
 | |
| 		h, err := webhook_service.ToHook(setting.AppURL+"/-/admin", hook)
 | |
| 		if err != nil {
 | |
| 			ctx.Error(http.StatusInternalServerError, "convert.ToHook", err)
 | |
| 			return
 | |
| 		}
 | |
| 		hooks[i] = h
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, hooks)
 | |
| }
 | |
| 
 | |
| // GetHook get an organization's hook by id
 | |
| func GetHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /admin/hooks/{id} admin adminGetHook
 | |
| 	// ---
 | |
| 	// summary: Get a hook
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to get
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	hookID := ctx.PathParamInt64("id")
 | |
| 	hook, err := webhook.GetSystemOrDefaultWebhook(ctx, hookID)
 | |
| 	if err != nil {
 | |
| 		if errors.Is(err, util.ErrNotExist) {
 | |
| 			ctx.NotFound()
 | |
| 		} else {
 | |
| 			ctx.Error(http.StatusInternalServerError, "GetSystemOrDefaultWebhook", err)
 | |
| 		}
 | |
| 		return
 | |
| 	}
 | |
| 	h, err := webhook_service.ToHook("/-/admin/", hook)
 | |
| 	if err != nil {
 | |
| 		ctx.Error(http.StatusInternalServerError, "convert.ToHook", err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, h)
 | |
| }
 | |
| 
 | |
| // CreateHook create a hook for an organization
 | |
| func CreateHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation POST /admin/hooks admin adminCreateHook
 | |
| 	// ---
 | |
| 	// summary: Create a hook
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   required: true
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/CreateHookOption"
 | |
| 	// responses:
 | |
| 	//   "201":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	form := web.GetForm(ctx).(*api.CreateHookOption)
 | |
| 
 | |
| 	utils.AddSystemHook(ctx, form)
 | |
| }
 | |
| 
 | |
| // EditHook modify a hook of a repository
 | |
| func EditHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation PATCH /admin/hooks/{id} admin adminEditHook
 | |
| 	// ---
 | |
| 	// summary: Update a hook
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to update
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/EditHookOption"
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	form := web.GetForm(ctx).(*api.EditHookOption)
 | |
| 
 | |
| 	// TODO in body params
 | |
| 	hookID := ctx.PathParamInt64("id")
 | |
| 	utils.EditSystemHook(ctx, form, hookID)
 | |
| }
 | |
| 
 | |
| // DeleteHook delete a system hook
 | |
| func DeleteHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation DELETE /admin/hooks/{id} admin adminDeleteHook
 | |
| 	// ---
 | |
| 	// summary: Delete a hook
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to delete
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "204":
 | |
| 	//     "$ref": "#/responses/empty"
 | |
| 
 | |
| 	hookID := ctx.PathParamInt64("id")
 | |
| 	if err := webhook.DeleteDefaultSystemWebhook(ctx, hookID); err != nil {
 | |
| 		if errors.Is(err, util.ErrNotExist) {
 | |
| 			ctx.NotFound()
 | |
| 		} else {
 | |
| 			ctx.Error(http.StatusInternalServerError, "DeleteDefaultSystemWebhook", err)
 | |
| 		}
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.Status(http.StatusNoContent)
 | |
| }
 |