mirror of
https://github.com/go-gitea/gitea
synced 2024-11-14 14:14:25 +00:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
169 lines
4.8 KiB
Go
169 lines
4.8 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"net/http"
|
|
"strconv"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
auth "code.gitea.io/gitea/modules/forms"
|
|
"code.gitea.io/gitea/modules/test"
|
|
"code.gitea.io/gitea/modules/web"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func int64SliceToCommaSeparated(a []int64) string {
|
|
s := ""
|
|
for i, n := range a {
|
|
if i > 0 {
|
|
s += ","
|
|
}
|
|
s += strconv.Itoa(int(n))
|
|
}
|
|
return s
|
|
}
|
|
|
|
func TestInitializeLabels(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/initialize")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 2)
|
|
web.SetForm(ctx, &auth.InitializeLabelsForm{TemplateName: "Default"})
|
|
InitializeLabels(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
models.AssertExistsAndLoadBean(t, &models.Label{
|
|
RepoID: 2,
|
|
Name: "enhancement",
|
|
Color: "#84b6eb",
|
|
})
|
|
assert.Equal(t, "/user2/repo2/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestRetrieveLabels(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
for _, testCase := range []struct {
|
|
RepoID int64
|
|
Sort string
|
|
ExpectedLabelIDs []int64
|
|
}{
|
|
{1, "", []int64{1, 2}},
|
|
{1, "leastissues", []int64{2, 1}},
|
|
{2, "", []int64{}},
|
|
} {
|
|
ctx := test.MockContext(t, "user/repo/issues")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, testCase.RepoID)
|
|
ctx.Req.Form.Set("sort", testCase.Sort)
|
|
RetrieveLabels(ctx)
|
|
assert.False(t, ctx.Written())
|
|
labels, ok := ctx.Data["Labels"].([]*models.Label)
|
|
assert.True(t, ok)
|
|
if assert.Len(t, labels, len(testCase.ExpectedLabelIDs)) {
|
|
for i, label := range labels {
|
|
assert.EqualValues(t, testCase.ExpectedLabelIDs[i], label.ID)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNewLabel(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/edit")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &auth.CreateLabelForm{
|
|
Title: "newlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
NewLabel(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
models.AssertExistsAndLoadBean(t, &models.Label{
|
|
Name: "newlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
assert.Equal(t, "/user2/repo1/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestUpdateLabel(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/edit")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
web.SetForm(ctx, &auth.CreateLabelForm{
|
|
ID: 2,
|
|
Title: "newnameforlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
UpdateLabel(ctx)
|
|
assert.EqualValues(t, http.StatusFound, ctx.Resp.Status())
|
|
models.AssertExistsAndLoadBean(t, &models.Label{
|
|
ID: 2,
|
|
Name: "newnameforlabel",
|
|
Color: "#abcdef",
|
|
})
|
|
assert.Equal(t, "/user2/repo1/labels", test.RedirectURL(ctx.Resp))
|
|
}
|
|
|
|
func TestDeleteLabel(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/labels/delete")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("id", "2")
|
|
DeleteLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
models.AssertNotExistsBean(t, &models.Label{ID: 2})
|
|
models.AssertNotExistsBean(t, &models.IssueLabel{LabelID: 2})
|
|
assert.Equal(t, ctx.Tr("repo.issues.label_deletion_success"), ctx.Flash.SuccessMsg)
|
|
}
|
|
|
|
func TestUpdateIssueLabel_Clear(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("issue_ids", "1,3")
|
|
ctx.Req.Form.Set("action", "clear")
|
|
UpdateIssueLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
models.AssertNotExistsBean(t, &models.IssueLabel{IssueID: 1})
|
|
models.AssertNotExistsBean(t, &models.IssueLabel{IssueID: 3})
|
|
models.CheckConsistencyFor(t, &models.Label{})
|
|
}
|
|
|
|
func TestUpdateIssueLabel_Toggle(t *testing.T) {
|
|
for _, testCase := range []struct {
|
|
Action string
|
|
IssueIDs []int64
|
|
LabelID int64
|
|
ExpectedAdd bool // whether we expect the label to be added to the issues
|
|
}{
|
|
{"attach", []int64{1, 3}, 1, true},
|
|
{"detach", []int64{1, 3}, 1, false},
|
|
{"toggle", []int64{1, 3}, 1, false},
|
|
{"toggle", []int64{1, 2}, 2, true},
|
|
} {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1/issues/labels")
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadRepo(t, ctx, 1)
|
|
ctx.Req.Form.Set("issue_ids", int64SliceToCommaSeparated(testCase.IssueIDs))
|
|
ctx.Req.Form.Set("action", testCase.Action)
|
|
ctx.Req.Form.Set("id", strconv.Itoa(int(testCase.LabelID)))
|
|
UpdateIssueLabel(ctx)
|
|
assert.EqualValues(t, http.StatusOK, ctx.Resp.Status())
|
|
for _, issueID := range testCase.IssueIDs {
|
|
models.AssertExistsIf(t, testCase.ExpectedAdd, &models.IssueLabel{
|
|
IssueID: issueID,
|
|
LabelID: testCase.LabelID,
|
|
})
|
|
}
|
|
models.CheckConsistencyFor(t, &models.Label{})
|
|
}
|
|
}
|