1
1
mirror of https://github.com/go-gitea/gitea synced 2024-09-21 11:16:03 +00:00
gitea/routers/web/repo
william-allspice e9c64f41a6
Distinguish official vs non-official reviews, add tool tips, and upgr… (#31924)
This Pull Request is a follow up to
https://github.com/go-gitea/gitea/pull/31886:

1. Adds a UI indicator between official (green) and unofficial (grey)
approved pull requests on the Pull Request page (as suggested by
@kdumontnu )
2. Adds tooltips adding clarity to the type and status of a review on
the Pull Request page (as suggested by @kdumontnu)
3. Updates text adding more clarity to required approvals (as suggested
by @kdumontnu)
4. Updates text on the branch settings page explaining what branch
approval limitations (as suggested by @yp05327)

Official approval:
<img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM"
src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696">

Unofficial approval:
<img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM"
src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7">

Rejected approval:
<img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM"
src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617">

Stale approval:
<img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM"
src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77">

Requested review tooltip:
<img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM"
src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2">

Updated text for approvals:
<img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM"
src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c">

Updated text for allowlisted/whitelisted approvals:
<img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM"
src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1">

Protected branch settings text:
<img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM"
src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776">

Comments list:
<img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM"
src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2">

---------

Co-authored-by: Kyle D. <kdumontnu@gmail.com>
2024-09-06 06:40:02 +00:00
..
actions Actions support workflow dispatch event (#28163) 2024-08-18 22:38:40 -04:00
setting Don't return 500 if mirror url contains special chars (#31859) 2024-08-21 01:54:55 +00:00
activity.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
attachment.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
blame.go Improve detecting empty files (#31332) 2024-06-13 01:06:46 +00:00
branch.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
cherry_pick.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
code_frequency.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
commit.go Add tag name in the commits list (#31082) 2024-08-19 17:04:06 +00:00
compare.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
contributors.go Fix Activity Page Contributors dropdown (#31264) 2024-06-06 10:28:33 +08:00
download.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
editor_test.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
editor.go Add missed return after ctx.ServerError (#31130) 2024-05-28 12:31:59 +03:00
find.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
fork.go Use db.ListOptionsAll instead of db.ListOptions{ListAll: true} (#29995) 2024-03-22 13:53:52 +01:00
githttp_test.go Fix http protocol auth (#27875) 2023-11-02 22:14:33 +08:00
githttp.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
helper.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_content_history.go Remove unnecessary inline style for tab-size (#31224) 2024-06-03 17:21:45 +00:00
issue_dependency.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_label_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_label.go Refactor label.IsArchived() (#29750) 2024-03-13 07:04:07 +01:00
issue_lock.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_pin.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_stopwatch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
issue_watch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
issue.go Distinguish official vs non-official reviews, add tool tips, and upgr… (#31924) 2024-09-06 06:40:02 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
migrate.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
milestone.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
packages.go Remove AddParamIfExist(AddParam) (#29841) 2024-03-16 12:07:56 +00:00
patch.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
projects_test.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
projects.go Add issue comment when moving issues from one column to another of the project (#29311) 2024-08-09 01:29:02 +00:00
pull_review_test.go Fix template error when comment review doesn't exist (#29888) 2024-03-19 04:19:48 +00:00
pull_review.go Prevent allow/reject reviews on merged/closed PRs (#30686) 2024-04-27 11:55:03 +00:00
pull.go Avoid returning without written ctx when posting PR (#31843) 2024-08-16 17:04:54 +00:00
recent_commits.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release_test.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
release.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
render.go Fix rendered wiki page link (#31398) 2024-06-18 03:09:20 +00:00
repo.go Hide the "Details" link of commit status when the user cannot access actions (#30156) 2024-07-28 23:11:40 +08:00
search_test.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
search.go Improve grep search (#30843) 2024-05-03 09:13:48 +00:00
topic.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
treelist.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go render plain text file if the LFS object doesn't exist (#31812) 2024-08-15 05:50:09 +08:00
wiki_test.go Fix raw wiki links (#31825) 2024-08-16 20:40:51 +08:00
wiki.go Fix raw wiki links (#31825) 2024-08-16 20:40:51 +08:00