mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 19:38:23 +00:00 
			
		
		
		
	Fix empty field login_name in API response JSON when creating user (#30511)
				
					
				
			Fix #30508 ps: if `sourceID` is not set, `LoginName` will be ignored
This commit is contained in:
		| @@ -30,7 +30,7 @@ import ( | ||||
| 	user_service "code.gitea.io/gitea/services/user" | ||||
| ) | ||||
|  | ||||
| func parseAuthSource(ctx *context.APIContext, u *user_model.User, sourceID int64, loginName string) { | ||||
| func parseAuthSource(ctx *context.APIContext, u *user_model.User, sourceID int64) { | ||||
| 	if sourceID == 0 { | ||||
| 		return | ||||
| 	} | ||||
| @@ -47,7 +47,6 @@ func parseAuthSource(ctx *context.APIContext, u *user_model.User, sourceID int64 | ||||
|  | ||||
| 	u.LoginType = source.Type | ||||
| 	u.LoginSource = source.ID | ||||
| 	u.LoginName = loginName | ||||
| } | ||||
|  | ||||
| // CreateUser create a user | ||||
| @@ -83,12 +82,13 @@ func CreateUser(ctx *context.APIContext) { | ||||
| 		Passwd:             form.Password, | ||||
| 		MustChangePassword: true, | ||||
| 		LoginType:          auth.Plain, | ||||
| 		LoginName:          form.LoginName, | ||||
| 	} | ||||
| 	if form.MustChangePassword != nil { | ||||
| 		u.MustChangePassword = *form.MustChangePassword | ||||
| 	} | ||||
|  | ||||
| 	parseAuthSource(ctx, u, form.SourceID, form.LoginName) | ||||
| 	parseAuthSource(ctx, u, form.SourceID) | ||||
| 	if ctx.Written() { | ||||
| 		return | ||||
| 	} | ||||
|   | ||||
		Reference in New Issue
	
	Block a user