Giteabot and Hester Gong
22911a1ece
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) ( #23513 ) ( #23540 )
...
Backport #23513 by @HesterG
Close #23466
Right now on pull request "files Changed" tab, if a file is viewed, when
the comments' links are visited, the comment will not be shown as the
file is folded after viewed. This PR is to improve the behavior, to make
the comment seen even the related file is folded, like on github.
And right now scroll position will be remembered and hence it won’t
scroll to hashed comment after refreshing, this PR also adjust the
scroll position remembering behavior: When there is hash comment in url,
do not remember the scroll position.
Before:
https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov
After:
https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov
Update - long comment's behavior after using `scrollTop ` (Comment div
scroll to the position which is 30px below the diff header, or 30px
below top on conversation tab):
https://user-images.githubusercontent.com/17645053/225614460-0602c1a6-229c-41f4-84d2-334e78251486.mov
Co-authored-by: Hester Gong <hestergong@gmail.com >
2023-03-17 22:59:18 -04:00
Giteabot and silverwind
4b763d8d37
Fix diff detail buttons wrapping, use tippy for review box ( #23271 ) ( #23546 )
...
Backport #23271 by @silverwind
Fix visual regression introduced by
https://github.com/go-gitea/gitea/pull/22986 .
Before:
<img width="1277" alt="image"
src="https://user-images.githubusercontent.com/115237/222792814-d70c2173-0c7c-4db2-8839-95be63cdc8ee.png ">
<img width="649" alt="image"
src="https://user-images.githubusercontent.com/115237/222792989-9b1f5e12-becd-40cc-b02c-e9f59a8e72a4.png ">
After:
<img width="1274" alt="image"
src="https://user-images.githubusercontent.com/115237/222792769-e7a9702f-4b6a-46c4-9385-da103ed4dff0.png ">
<img width="565" alt="image"
src="https://user-images.githubusercontent.com/115237/222793084-6de6482b-11dc-4d38-b514-15884d20e140.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-17 14:52:04 -04:00
bd1a915bdb
Use octicon-verified for gpg signatures ( #23529 ) ( #23536 )
...
Backport #23529 by @silverwind
Before:
<img width="292" alt="Screenshot 2023-03-16 at 23 40 47"
src="https://user-images.githubusercontent.com/115237/225768871-43e11ced-e340-4c88-b756-25f9f7076fd2.png ">
<img width="288" alt="Screenshot 2023-03-16 at 23 51 05"
src="https://user-images.githubusercontent.com/115237/225770071-b51f3ed6-ef14-421b-a5bc-6a26e808d404.png ">
After:
<img width="291" alt="Screenshot 2023-03-16 at 23 40 37"
src="https://user-images.githubusercontent.com/115237/225768864-ea4956c7-8c57-4148-9d89-c818991a7538.png ">
<img width="281" alt="image"
src="https://user-images.githubusercontent.com/115237/225769978-0b9c6c52-9a13-4c23-b13e-8a8a692abf43.png ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-17 11:39:31 -04:00
Giteabot and silverwind
cab7044772
Increase horizontal page padding ( #23507 ) ( #23537 )
...
Backport #23507 by @silverwind
Add a bit more empty space on left and right side of page content for a
more pleasant viewing experience. Also tweaked the mobile navbar to
match.
Before:
<img width="1276" alt="Screenshot 2023-03-16 at 00 58 23"
src="https://user-images.githubusercontent.com/115237/225473942-f544106f-1b61-456a-99fb-3ba136cabc8d.png ">
After:
<img width="1270" alt="Screenshot 2023-03-16 at 00 58 37"
src="https://user-images.githubusercontent.com/115237/225473959-8b555359-a08d-48e1-9476-2710aabb1166.png ">
Mobile Navbar:
<img width="673" alt="Screenshot 2023-03-16 at 01 05 12"
src="https://user-images.githubusercontent.com/115237/225473966-adccef2b-4d34-44ed-8c75-d4ca46d96cf3.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-17 21:01:47 +08:00
68c9f1abd8
Use <nav> instead of <div> in the global navbar ( #23125 ) ( #23533 )
...
Backport #23125 by @delvh
Furthermore improved/deleted some comments in the template.
The appearance did not change.
Co-authored-by: delvh <leon@kske.dev >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-17 01:28:17 -04:00
Giteabot and silverwind
23a6fa9421
Make time tooltips interactive ( #23526 ) ( #23527 )
...
Backport #23526 by @silverwind
Fixes https://codeberg.org/forgejo/forgejo/issues/511
<img width="379" alt="Screenshot 2023-03-16 at 20 23 10"
src="https://user-images.githubusercontent.com/115237/225731294-4c6e4f44-bdcc-4c8c-86e2-49f7c03b377d.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-16 16:23:11 -05:00
Giteabot and techknowlogick
70e31b4aa0
Update path to docs theme file ( #23502 ) ( #23505 )
...
Backport #23502 by @techknowlogick
The branch name for the theme was updated to main
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-15 16:04:27 -05:00
d73846f0b4
Disable sending email after push a commit to a closed PR ( #23462 ) ( #23492 )
...
Backport #23462 by @sillyguodong
Close #23440
Cause by #23189
In #23189 , we should insert a comment record into db when pushing a
commit to the PR, even if the PR is closed.
But should skip sending any notification in this case.
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-03-15 11:20:51 +01:00
527bbf67e8
Fix 'View File' button in code search ( #23478 ) ( #23483 )
...
Backport #23478 by @silverwind
- Right-align 'View File' button
- Add 'role' attribute to button link
Before:
<img width="1148" alt="Screenshot 2023-03-14 at 22 02 16"
src="https://user-images.githubusercontent.com/115237/225135954-f06153ec-c222-441e-98ba-0177afff3a7a.png ">
After:
<img width="1150" alt="Screenshot 2023-03-14 at 22 02 33"
src="https://user-images.githubusercontent.com/115237/225135966-323cb695-05ef-4b83-a8ef-05f2b1887090.png ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-03-15 10:34:05 +01:00
Giteabot and tdsds.com
5feb31f219
Bump webpack from 5.75.0 to 5.76.0 ( #23484 ) ( #23487 )
...
Backport #23484 by @dependabot[bot]
Bumps [webpack](https://github.com/webpack/webpack ) from 5.75.0 to
5.76.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/webpack/webpack/releases ">webpack's
releases</a>.</em></p>
<blockquote>
<h2>v5.76.0</h2>
<h2>Bugfixes</h2>
<ul>
<li>Avoid cross-realm object access by <a
href="https://github.com/Jack-Works "><code>@Jack-Works</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16500 ">webpack/webpack#16500</a></li>
<li>Improve hash performance via conditional initialization by <a
href="https://github.com/lvivski "><code>@lvivski</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16491 ">webpack/webpack#16491</a></li>
<li>Serialize <code>generatedCode</code> info to fix bug in asset module
cache restoration by <a
href="https://github.com/ryanwilsonperkin "><code>@ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16703 ">webpack/webpack#16703</a></li>
<li>Improve performance of <code>hashRegExp</code> lookup by <a
href="https://github.com/ryanwilsonperkin "><code>@ryanwilsonperkin</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16759 ">webpack/webpack#16759</a></li>
</ul>
<h2>Features</h2>
<ul>
<li>add <code>target</code> to <code>LoaderContext</code> type by <a
href="https://github.com/askoufis "><code>@askoufis</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16781 ">webpack/webpack#16781</a></li>
</ul>
<h2>Security</h2>
<ul>
<li><a
href="https://github.com/advisories/GHSA-3rfm-jhwj-7488 ">CVE-2022-37603</a>
fixed by <a
href="https://github.com/akhilgkrishnan "><code>@akhilgkrishnan</code></a>
in <a
href="https://redirect.github.com/webpack/webpack/pull/16446 ">webpack/webpack#16446</a></li>
</ul>
<h2>Repo Changes</h2>
<ul>
<li>Fix HTML5 logo in README by <a
href="https://github.com/jakebailey "><code>@jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16614 ">webpack/webpack#16614</a></li>
<li>Replace TypeScript logo in README by <a
href="https://github.com/jakebailey "><code>@jakebailey</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16613 ">webpack/webpack#16613</a></li>
<li>Update actions/cache dependencies by <a
href="https://github.com/piwysocki "><code>@piwysocki</code></a> in <a
href="https://redirect.github.com/webpack/webpack/pull/16493 ">webpack/webpack#16493</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/Jack-Works "><code>@Jack-Works</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16500 ">webpack/webpack#16500</a></li>
<li><a href="https://github.com/lvivski "><code>@lvivski</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16491 ">webpack/webpack#16491</a></li>
<li><a
href="https://github.com/jakebailey "><code>@jakebailey</code></a> made
their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16614 ">webpack/webpack#16614</a></li>
<li><a
href="https://github.com/akhilgkrishnan "><code>@akhilgkrishnan</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16446 ">webpack/webpack#16446</a></li>
<li><a
href="https://github.com/ryanwilsonperkin "><code>@ryanwilsonperkin</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16703 ">webpack/webpack#16703</a></li>
<li><a href="https://github.com/piwysocki "><code>@piwysocki</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16493 ">webpack/webpack#16493</a></li>
<li><a href="https://github.com/askoufis "><code>@askoufis</code></a>
made their first contribution in <a
href="https://redirect.github.com/webpack/webpack/pull/16781 ">webpack/webpack#16781</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0 ">https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/webpack/webpack/commit/97b1718720c33f1b17302a74c5284b01e02ec001 "><code>97b1718</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16781 ">#16781</a>
from askoufis/loader-context-target-type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b84efe6224b276bf72e4c5e2f4e76acddfaeef07 "><code>b84efe6</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16759 ">#16759</a>
from ryanwilsonperkin/real-content-hash-regex-perf</li>
<li><a
href="https://github.com/webpack/webpack/commit/c98e9e001441b165c7ed4845700839730b505833 "><code>c98e9e0</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16493 ">#16493</a>
from piwysocki/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/5f34acfbc074da6cc09f48944d7f2b4273ffb3f8 "><code>5f34acf</code></a>
feat: Add <code>target</code> to <code>LoaderContext</code> type</li>
<li><a
href="https://github.com/webpack/webpack/commit/b7fc4d876deb958d7ee81ecc00a312e39a354a44 "><code>b7fc4d8</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16703 ">#16703</a>
from ryanwilsonperkin/ryanwilsonperkin/fix-16160</li>
<li><a
href="https://github.com/webpack/webpack/commit/63ea82da4d4e4242b6a6285fc937f0684f264fe8 "><code>63ea82d</code></a>
Merge branch 'webpack:main' into patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/4ba225225b1348c8776ca5b5fe53468519413bc0 "><code>4ba2252</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16446 ">#16446</a>
from akhilgkrishnan/patch-1</li>
<li><a
href="https://github.com/webpack/webpack/commit/1acd6350be3d74d4ac70b64cbbc60f27724b618b "><code>1acd635</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16613 ">#16613</a>
from jakebailey/ts-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/302eb37fe19ed7ca60eaf895aca4f9da9dfd7931 "><code>302eb37</code></a>
Merge pull request <a
href="https://redirect.github.com/webpack/webpack/issues/16614 ">#16614</a>
from jakebailey/html5-logo</li>
<li><a
href="https://github.com/webpack/webpack/commit/cfdb1dfe59b33bf7441b8a8e4fc58d75e4f54cee "><code>cfdb1df</code></a>
Improve performance of hashRegExp lookup</li>
<li>Additional commits viewable in <a
href="https://github.com/webpack/webpack/compare/v5.75.0...v5.76.0 ">compare
view</a></li>
</ul>
</details>
<details>
<summary>Maintainer changes</summary>
<p>This version was pushed to npm by <a
href="https://www.npmjs.com/~evilebottnawi ">evilebottnawi</a>, a new
releaser for webpack since your current version.</p>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the
default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as
the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as
the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the
default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/go-gitea/gitea/network/alerts ).
</details>
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-03-15 14:21:59 +08:00
31efbafbe3
Convert GitHub event on actions and fix some pull_request events. ( #23037 ) ( #23471 )
...
Backport #23037 by @lunny
Follow #22680
Partially Fix #22958 , on pull_request, `opened`, `reopened`,
`synchronize` supported, `edited` hasn't been supported yet because
Gitea doesn't trigger that events.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-15 10:43:10 +08:00
28af02eea0
Fix due date being wrong on issue list ( #23475 ) ( #23477 )
...
Backport #23475 by @yardenshoham
Exactly like #22302 but in the issue list page
Co-authored-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-15 09:40:43 +08:00
c698a6fc5d
Scoped label display and documentation tweaks ( #23430 ) ( #23433 )
...
Backport #23430 by @brechtvl
* Fix scoped label left and right part breaking across lines.
* Remove slanted divider in scoped label display, make it straight.
After using this for a while, this feels more visually noisy than
helpful.
* Reduce contrast between scope and item to reduce probability of
unreadable text on background.
* Change documentation to remove mention of non-exclusive scoped labels.
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-03-15 07:58:38 +08:00
e5a51eca45
Remove wrongly added column on migration test fixtures ( #23456 ) ( #23470 )
...
Backport #23456 by @lunny
Fix https://drone.gitea.io/go-gitea/gitea/69418/3/8
Migration fixtures are in `models/migrations/fixtures`, every folder
will be used only by the test with the same name.
For `Test_DeleteOrphanedIssueLabels`, the fixture should keep consistent
as the database structure at that time. So the newly added `exclusive`
is not right. Just revert the change in
https://github.com/go-gitea/gitea/pull/22585/files#diff-f8db9cbbaa10bf7b27eb726884454db821a4b4f8cb9a0d50435555908761bbcb
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-14 16:09:52 -04:00
8536dc4b73
Make branches list page operations remember current page ( #23420 ) ( #23460 )
...
Backport #23420 by @wxiaoguang
Close #23411
Always pass "page" query parameter to backend, and make backend respect
it.
The `ctx.FormInt("limit")` is never used, so removed.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-14 20:51:14 +08:00
Giteabot and sillyguodong
1543ac9c8d
Fix missing commit status in PR which from forked repo ( #23351 ) ( #23453 )
...
Backport #23351 by @sillyguodong
close : #23347
### Reference and Inference
According to Github REST API
[doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference ):
1. The `Drone CI` that can create some commit status by
[API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status )
is enabled in `go-gitea/gitea`. So I tried to call the API to get a
commit status list of a PR which is commited to upstream
repo(`go-gitea/gitea`). As a result, the API returned a array of commit
status.
2. Then I tried to call the API to get commit status list of the
reference which of the `SHA` is the same as step 1 in the repo which is
forked from `go-gitea/gitea`. But I got a empty array.
So, I believe it that：
1. The commit status is not shared between upstream repo and forked
repo.
2. The coomit status is bound to a repo that performs actions. (Gitea's
logic is the same)
### Cause
During debugging, I found it that commit status are not stored in the DB
as expected.
So, I located the following code:
https://github.com/go-gitea/gitea/blob/8cadd51bf295e6ff36ac36efed68cc5de34c9382/services/actions/commit_status.go#L18-L26
When I create a PR, the type of `event` is `pull request`, not `push`.
So the code return function directly.
### Screenshot
### Other
In this PR, I also fix the problem of missing icon which represents
running in PRs list.
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-03-14 08:11:31 +08:00
Giteabot and John Olheiser
c3c0710412
Purge API comment ( #23451 ) ( #23452 )
...
Backport #23451 by @jolheiser
This PR just adds the `purge` query parameter to the swagger docs for
admin user delete.
I considered using the same verbiage we have in the UI, but that seemed
more verbose than descriptions we use elsewhere in swagger. I'm fine if
that's preferred, though, just let me know. 🙂
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-03-13 15:46:18 -05:00
Giteabot and Philip Peterson
fa33919e24
Support reflogs ( #22451 ) ( #23438 )
...
Backport #22451 by @philip-peterson
This PR adds support for reflogs on all repositories. It does this by
adding a global configuration entry.
Implements #14865
Signed-off-by: Philip Peterson <philip.c.peterson@gmail.com >
Co-authored-by: Philip Peterson <philip-peterson@users.noreply.github.com >
2023-03-13 12:20:10 +00:00
b1162495af
Fix actions frontend bugs (pagination, long name alignment) and small simplify ( #23370 ) ( #23436 )
...
Backport #23370 by @HesterG
1 Right now on actions page, the action list will not be aligned if
commit message is long. In this PR, the changes are:
- The branch tag is moved to bottom row
- Width percentage is given to make them aligned
- Show "..." if commit is longer than two lines.
- Align the status icon with the commit message with baseline
Before:
<img width="1068" alt="截屏2023-03-08 12 23 22"
src="https://user-images.githubusercontent.com/17645053/223628534-6b9472cb-29f5-40a3-9714-c5152553049e.png ">
After:
<img width="756" alt="截屏2023-03-08 13 34 28"
src="https://user-images.githubusercontent.com/17645053/223628571-da94698b-0e0a-43e3-ae82-34d8c780e5ba.png ">
2 Right now the actions list's pagination is not working properly
because Param is not passed to pagination template, in this PR Param
Strings are passed to the pager
Before:
<img width="1176" alt="截屏2023-03-08 12 23 50"
src="https://user-images.githubusercontent.com/17645053/223629207-8b67ce74-2342-4259-bc81-036e37752716.png ">
After:
<img width="1343" alt="截屏2023-03-08 13 11 54"
src="https://user-images.githubusercontent.com/17645053/223629321-4f538f8a-45dc-4d6f-ae60-2c82680ae3e7.png ">
3 A small simplify in `RepoActionView.vue` .
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-13 09:09:00 +02:00
Giteabot and yp05327
41655ee878
Show edit/close/delete button on organization wide repositories ( #23388 ) ( #23429 )
...
Backport #23388 by @yp05327
A part of https://github.com/go-gitea/gitea/pull/22865
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-12 15:17:25 +01:00
0d9b44c0e3
Preserve file size when creating attachments ( #23406 ) ( #23426 )
...
Backport #23406 by @baez90
When creating attachments (issue, release, repo) the file size (being
part of the multipart file header) is passed through the chain of
creating an attachment to ensure the MinIO client can stream the file
directly instead of having to read it to memory completely at first.
Fixes #23393
Co-authored-by: Peter <peter.kurfer@googlemail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-12 12:45:39 +01:00
Giteabot
e87f36e885
Use buildkit for docker builds ( #23415 ) ( #23424 )
2023-03-11 17:11:23 -05:00
b301cb17a3
Fix and move "Use this template" button ( #23398 ) ( #23408 )
...
Backport #23398
Before:
<img width="1157" alt="Screenshot 2023-03-09 at 23 21 25"
src="https://user-images.githubusercontent.com/115237/224174168-869966cc-fa59-4231-b449-23bd9db12862.png ">
After:
<img width="1145" alt="Screenshot 2023-03-09 at 23 24 34"
src="https://user-images.githubusercontent.com/115237/224174173-7f5b9c22-44c4-4eed-990c-da49d749eb0e.png ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-11 01:41:04 +08:00
Giteabot and yp05327
e259daeff8
Add missing tabs to org projects page ( #22705 ) ( #23412 )
...
Backport #22705 by @yp05327
Fixes https://github.com/go-gitea/gitea/issues/22676
Context Data `IsOrganizationMember` and `IsOrganizationOwner` is used to
control the visibility of `people` and `team` tab.
https://github.com/go-gitea/gitea/blob/2871ea08096cba15546f357d0ec473734ee9d8be/templates/org/menu.tmpl#L19-L40
And because of the reuse of user projects page, User Context is changed
to Organization Context. But the value of `IsOrganizationMember` and
`IsOrganizationOwner` are not being given.
I reused func `HandleOrgAssignment` to add them to the ctx, but may have
some unnecessary variables, idk whether it is ok.
I found there is a missing `PageIsViewProjects` at create project page.
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-10 10:08:28 -06:00
Giteabot and zeripath
edb618c136
Handle OpenID discovery URL errors a little nicer when creating/editing sources ( #23397 ) ( #23403 )
...
Backport #23397
When there is an error creating a new openIDConnect authentication
source try to handle the error a little better.
Close #23283
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2023-03-10 08:29:28 -06:00
43cf04c031
Fix broken Chroma CSS styles ( #23174 ) ( #23402 )
...
Backport #23174
The CSS styles in Gitea themes are out-of-sync of Chroma's styles.
This PR introduces a `chroma-style-diff.go` tool to compare the diff.
The missing CSS styles have been added manually. They are left as empty
to reduce arguments because there was no color for them before.
And this PR fixes #22348 , with just 2 lines changed: `.chroma .kt & .n`,
these colors are taken from GitHub.
It's good enough for #22348
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-03-10 19:45:07 +08:00
e9991b1f06
Refactor and tidy-up the merge/update branch code ( #22568 ) ( #23365 )
...
Backport #22568
The merge and update branch code was previously a little tangled and had
some very long functions. The functions were not very clear in their
reasoning and there were deficiencies in their logging and at least one
bug in the handling of LFS for update by rebase.
This PR substantially refactors this code and splits things out to into
separate functions. It also attempts to tidy up the calls by wrapping
things in "context"s. There are also attempts to improve logging when
there are errors.
Signed-off-by: Andrew Thornton <art27@cantab.net >
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
Co-authored-by: delvh <dev.lh@web.de >
2023-03-09 22:15:39 -05:00
Giteabot and yp05327
975785dd42
Rename canWriteUnit to canWriteProjects ( #23386 ) ( #23399 )
...
Backport #23386
A part of https://github.com/go-gitea/gitea/pull/22865
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-09 21:21:12 -05:00
Giteabot and yp05327
e269e8901f
Fix incorrect NotFound conditions in org/projects.go ( #23384 ) ( #23395 )
...
Backport #23384
A part of https://github.com/go-gitea/gitea/pull/22865
user/org project's `RepoID` is always 0, we need to check `OwnerID`
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-09 13:56:31 -06:00
Giteabot
87c31c2ffe
Set X-Gitea-Debug header once ( #23361 ) ( #23381 )
2023-03-09 06:33:05 +08:00
54c674c936
Fix panic when getting notes by ref ( #23372 ) ( #23377 )
...
Backport #23372
Fix #23357 .
Now the `/repos/{owner}/{repo}/git/notes/{sha}` API supports getting
notes by a ref or sha
(https://try.gitea.io/api/swagger#/repository/repoGetNote ). But the
`GetNote` func can only accept commit ID.
https://github.com/go-gitea/gitea/blob/a12f5757372f751d25f9e5ca1f168f6920ded894/modules/git/notes_nogogit.go#L18
So we need to convert the query parameter to commit ID before calling
`GetNote`.
Co-authored-by: Zettat123 <zettat123@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-08 15:17:31 -05:00
cf80f829b4
Do not recognize text files as audio ( #23355 ) ( #23368 )
...
Backport #23355
Close #17108
This PR uses a trick (removing the ID3 tag) to detect the content again
to to see whether the content is text type.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-08 16:03:05 +08:00
ed25e094ab
Fix adding of empty class name ( #23352 ) ( #23360 )
...
Backport #23352
This PR is to fix the error shown below. The reason is because
[`class-name`
prop](https://github.com/go-gitea/gitea/blob/main/web_src/js/components/ActionRunStatus.vue#L6 )
given to `svg` component has a space, and classList cannot add empty
string.
https://user-images.githubusercontent.com/17645053/223346720-c7f9de43-5e69-4ecf-93c0-90bf04090693.mov
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-07 17:15:19 -05:00
10df304b2f
Fix various ImageDiff/SVG bugs ( #23312 ) ( #23358 )
...
Backport #23312
Replace #23310 , Close #19733
And fix various UI problems, including regressions from #22959 #22950
and more.
## SVG Detection
The old regexp may mismatch non-SVG files. This PR adds new tests for
those cases.
## UI Changes
### Before
### After
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-07 15:38:13 +02:00
Giteabot and Jason Song
ecae62837c
Refactor setting.Database.UseXXX to methods ( #23354 ) ( #23356 )
...
Backport #23354
Replace #23350 .
Refactor `setting.Database.UseMySQL` to
`setting.Database.Type.IsMySQL()`.
To avoid mismatching between `Type` and `UseXXX`.
This refactor can fix the bug mentioned in #23350 , so it should be
backported.
Co-authored-by: Jason Song <i@wolfogre.com >
2023-03-07 20:11:44 +08:00
6be6c19daf
Fix PR view misalignment caused by long name file ( #23321 ) ( #23335 )
...
Backport #23321
Close #23248
The UI after this PR:
https://user-images.githubusercontent.com/17645053/223009758-7f0c9f12-d346-4cb2-a605-729fddce732f.mov
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-07 11:11:55 +08:00
61f91bdc7e
Update documentation for the new YAML label file format ( #23020 ) ( #23341 )
...
Backport #23020
update documentation to include an overview of the yaml label template
that is part of PR #22976
Signed-off-by: Jon Roadley-Battin <jon.roadleybattin@gmail.com >
Co-authored-by: JonRB <4564448+eeyrjmr@users.noreply.github.com >
Co-authored-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-03-06 17:52:29 -06:00
8ab50be000
Remove unnecessary space on link ( #23334 ) ( #23340 )
...
Backport #23334
The action run title has a blank. This PR removes it.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-06 16:35:51 -05:00
dfab6e2d1c
Fix incorrect redirect link of delete org project ( #23327 ) ( #23339 )
...
Backport #23327
A part of https://github.com/go-gitea/gitea/pull/22865/commits
The old code will cause 500 error.
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-03-06 16:05:42 -05:00
Giteabot and yp05327
2f7bbdf8c9
Fix incorrect project links and use symlink icon for org-wide projects ( #23325 ) ( #23336 )
...
Backport #23325
Fix displaying same projects icons between user/repo projects.
And fix incorrect projects links.
A part of https://github.com/go-gitea/gitea/pull/22865 .
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-06 13:48:04 -06:00
Giteabot and Brecht Van Lommel
af4767df5c
Scoped labels: don't require holding alt key to remove ( #23303 ) ( #23331 )
...
Backport #23303
Alt doesn't work on all browsers, the simplest solution for v1.19 is to
just not require it and toggle the label by just clicking.
Part of #22974
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2023-03-06 12:59:53 -06:00
Giteabot and wxiaoguang
233a399706
Fix broken code editor diff preview ( #23307 ) ( #23320 )
...
Backport #23307
Close #23265 , the code editor diff preview has been broken for long
time.
* Fix the regression for `data-line-num`
* `.code-diff` is necessary to show the line number
* Fix the regression for #12434
* The diff:
[12434](https://github.com/go-gitea/gitea/pull/12434/files?diff=unified&w=1 )
* It hides the Type(4) (aka HunkHeader) for unexpected cases.
Diff with ignoring whitespaces:
https://github.com/go-gitea/gitea/pull/23307/files?diff=unified&w=1
Before: see the issue #23265
After:
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-06 12:05:35 -06:00
Giteabot and Jonathan Tran
dcf1717793
Add context when rendering labels or emojis ( #23281 ) ( #23319 )
...
Backport #23281
This branch continues the work of #23092 and attempts to rid the
codebase of any `nil` contexts when using a `RenderContext`.
Anything that renders markdown or does post processing may call
`markup.sha1CurrentPatternProcessor()`, and this runs
`git.OpenRepository()`, which needs a context. It will panic if the
context is `nil`. This branch attempts to _always_ include a context
when creating a `RenderContext` to prevent future crashes.
Co-authored-by: Jonathan Tran <jon@allspice.io >
2023-03-06 10:32:40 -06:00
b1e68f39e7
Properly flush unique queues on startup ( #23154 ) ( #23201 )
...
Backport #23154
There have been a number of reports of PRs being blocked whilst being
checked which have been difficult to debug. In investigating #23050 I
have realised that whilst the Warn there is somewhat of a miscall there
was a real bug in the way that the LevelUniqueQueue was being restored
on start-up of the PersistableChannelUniqueQueue.
Next there is a conflict in the setting of the internal leveldb queue
name - This wasn't being set so it was being overridden by other unique
queues.
This PR fixes these bugs and adds a testcase.
Thanks to @brechtvl for noticing the second issue.
Fix #23050
and others
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
Co-authored-by: delvh <leon@kske.dev >
2023-03-06 22:35:07 +08:00
ee3d9330a8
Update hacking-on-gitea-zh_cn documentation ( #23315 ) ( #23323 )
...
Backport #23315
This PR fix outdated hacking-on-gitea-zh_cn documentation.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Jason Song <i@wolfogre.com >
2023-03-06 18:44:02 +08:00
d1d15306d1
Change interactiveBorder to fix popup preview ( #23169 ) ( #23314 )
...
Backport #23169
Close #23073 .
Used the solution as reference to the reply:
https://github.com/go-gitea/gitea/issues/23073#issuecomment-1440124609
Here made the change inside the `contextpopup.js` because this is where
the popup component is created and tippy configuration is given.
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-06 16:45:43 +08:00
e3b1ebbbfe
Scoped labels: set aria-disabled on muted Exclusive option for a11y ( #23306 ) ( #23311 )
...
Backport #23306
It is convenient to be able to toggle off this option after removing /
from the name. This ensures the muted state is communicated to blind
users even when the input is not fully disabled.
Part of #22974
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-05 23:05:11 +08:00
17ae7e335e
Add basic documentation for labels, including scoped labels ( #23304 ) ( #23309 )
...
Backport #23304
Part of #22974
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Co-authored-by: delvh <dev.lh@web.de >
2023-03-05 20:38:46 +08:00
1edb57eda9
Fix various bugs for "install" page ( #23194 ) ( #23286 )
...
Backport #23194
## TLDR
* Fix the broken page / broken image problem when click "Install"
* Fix the Password Hash Algorithm display problem for #22942
* Close #20089
* Close #23183
* Close #23184
## Details
### The broken page / broken image problem when clicking on "Install"
(Redirect failed after install - #23184 )
Before: when clicking on "install", all new requests will fail, because the
server has been restarted. Users just see a broken page with broken
images, sometimes the server is not ready but the user would have been
redirect to "/user/login" page, then the users see a new broken page
(connection refused or something wrong ...)
After: only check InstallLock=true for necessary handlers, and sleep for
a while before restarting the server, then the browser has enough time
to load the "post-install" page. And there is a script to check whether
"/user/login" is ready, the user will only be redirected to the login
page when the server is ready.
### During new instance setup fill 'Gitea Base URL' with
window.location.origin - #20089
If the "app_url" input contains `localhost` (the default value from
config), use current window's location href as the `app_url` (aka
ROOT_URL)
### Fix the Password Hash Algorithm display problem for "Provide the
ability to set password hash algorithm parameters #22942 "
Before: the UI shows `pbkdf2$50000$50`
<details>
</details>
After: the UI shows `pbkdf2`
<details>
</details>
### GET data: net::ERR_INVALID_URL #23183
Cause by empty `data:` in `<link rel="manifest"
href="data:{{.ManifestData}}">`
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-05 11:59:58 +01:00
a2a9b0f977
Support sanitising the URL by removing extra slashes in the URL ( #21333 ) ( #23300 )
...
Backport #21333
Changes in this PR :
Strips incoming request URL of additional slashes (/). For example an
input like
`https://git.data.coop//halfd/new-website.git ` is translated to
`https://git.data.coop/halfd/new-website.git `
Fixes https://github.com/go-gitea/gitea/issues/20462
Fix #23242
Co-authored-by: Sandeep Bhat <sandyethadka@gmail.com >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <leon@kske.dev >
2023-03-05 02:14:12 -05:00
ff96f804b6
update to mermaid v10 ( #23178 ) ( #23299 )
...
Backport #23178
fix #23153
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: delvh <leon@kske.dev >
2023-03-05 02:13:50 -05:00
Giteabot
a926994bfe
Re-add accidentally removed hacking-on-gitea.zh-cn.md ( #23297 ) ( #23305 )
2023-03-04 20:09:58 -05:00
83903535e3
Fix code wrap for unbroken lines ( #23268 ) ( #23293 )
...
Backport #23268
## The Problem
`overflow-wrap: break-word` doesn't work well for unbroken lines. Use
`overflow-wrap: anywhere` instead, and remove legacy alias `word-wrap`
## Before
## After
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-03-04 20:55:12 +01:00
8142408d3a
Fill head commit to in payload when notifying push commits for mirroring ( #23215 ) ( #23292 )
...
Backport #23215
Just like what has been done when pushing manually:
https://github.com/go-gitea/gitea/blob/7a5af25592003ddc3017fcd7b822a3e02fc40ef6/services/repository/push.go#L225-L226
Before:
<img width="448" alt="image"
src="https://user-images.githubusercontent.com/9418365/222100123-cd4839d1-2d4d-45f7-7a0-0cbc73162b44.png ">
After:
<img width="448" alt="image"
src="https://user-images.githubusercontent.com/9418365/222100225-3c5bb65-7ab9-41e2-8e39-9d84c23c352d.png ">
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-04 19:02:50 +01:00
a4158d1904
Avoid panic caused by broken payload when creating commit status ( #23216 ) ( #23294 )
...
Backport #23216
When creating commit status for Actons jobs, a payload with nil
`HeadCommit` will cause panic.
Reported at:
https://gitea.com/gitea/act_runner/issues/28#issuecomment-732166
Although the `HeadCommit` probably can not be nil after #23215 ,
`CreateCommitStatus` should protect itself, to avoid being broken in the
future.
In addition, it's enough to print error log instead of returning err
when `CreateCommitStatus` failed.
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-03-04 14:23:49 +00:00
781019216c
Fix GetFilesChangedBetween if the file name may be escaped ( #23272 ) ( #23279 )
...
Backport #23272
The code for GetFilesChangedBetween uses `git diff --name-only
base..head` to get the names of files changed between base and head
however this forgets that git will escape certain values.
This PR simply switches to use `-z` which has the `NUL` character as the
separator.
Ref https://github.com/go-gitea/gitea/pull/22568#discussion_r1123138096
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-03-04 00:38:31 -05:00
1322cd7a58
Use correct README link to render the README ( #23152 ) ( #23264 )
...
Backport #23152
`renderReadmeFile` needs `readmeTreelink` as parameter but gets
`treeLink`.
The values of them look like as following:
`treeLink`: `/{OwnerName}/{RepoName}/src/branch/{BranchName}`
`readmeTreelink`:
`/{OwnerName}/{RepoName}/src/branch/{BranchName}/{ReadmeFileName}`
`path.Dir` in
https://github.com/go-gitea/gitea/blob/8540fc45b11eff9a73753ca139f8ea5c38509bf5/routers/web/repo/view.go#L316
should convert `readmeTreelink` into
`/{OwnerName}/{RepoName}/src/branch/{BranchName}` instead of the current
`/{OwnerName}/{RepoName}/src/branch`.
Fixes #23151
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: Jason Song <i@wolfogre.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-03-04 00:38:11 -05:00
Giteabot and silverwind
464bbd747e
Fix commit retrieval by tag ( #21804 ) ( #23266 )
...
Backport #21804
It is not correct to return tag data when commit data is requested, so
remove the hacky code that overwrote parts of a commit with parts of a
tag.
This fixes commit retrieval by tag for both the latest commit in the UI
and the commit info on tag webhook events.
Fixes: https://github.com/go-gitea/gitea/issues/21687
Replaces: https://github.com/go-gitea/gitea/pull/21693
<img width="324" alt="Screenshot 2022-11-13 at 15 26 37"
src="https://user-images.githubusercontent.com/115237/201526975-736c6ea7-ad6a-467a-a823-9a63d6ecb718.png ">
<img width="789" alt="image"
src="https://user-images.githubusercontent.com/115237/201526876-90a13ffc-1e5c-4d76-911b-f1ae51e8eaab.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-03 13:42:46 -06:00
Giteabot and wxiaoguang
574182e1eb
Revert relative links to absolute links in mail templates ( #23267 ) ( #23269 )
...
Backport #23267
Follow #21986 , fix regression.
The mail templates should always use `AppURL` (the full absolute URL)
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-03 17:41:00 +00:00
Giteabot and HesterG
ef8209a953
Use async await to fix empty quote reply at first time ( #23168 ) ( #23256 )
...
Backport #23168
The reason why quote reply is empty is when quote reply is clicked, it
triggers the click function on `.comment-form-reply` button, and when
the first time this function is triggered, easyMDE for the reply has not
yet initialized, so that click handler of `.quote-reply` button in
`repo-legacy.js` got an `undefined` as easyMDE, and the following lines
which put quoted reply into the easyMDE is not executed.
The workaround in this PR is to pass the replied content to
'.comment-form-reply' button if easyMDE is not yet initialized (quote
reply first clicked) and put the replied content into it the after
easyMDE is created.
Now quote reply on first click:
https://user-images.githubusercontent.com/17645053/221452823-fc699d50-1649-4af1-952e-f04fc8d2978e.mov
<br />
Update:
The above change is not appropriate as stated in the
[comment](https://github.com/go-gitea/gitea/pull/23168#issuecomment-1445562284 )
Use await instead
Close #22075 .
Close #23247 .
Co-authored-by: HesterG <hestergong@gmail.com >
2023-03-02 16:36:21 -06:00
Giteabot and Blender Defender
9309098eab
Fix switched citation format ( #23250 ) ( #23253 )
...
Backport #23250
Due to switched input parameters, the citation texts for Bibtex and Apa
were switched.
This pull request fixes #23244
Co-authored-by: Blender Defender <contact.blenderdefender@gmail.com >
2023-03-02 14:05:10 -06:00
Giteabot and yp05327
790a79b04c
Fix missed .hide class ( #23208 ) ( #23237 )
...
Backport #23208
https://github.com/go-gitea/gitea/pull/22950 removed `hide` class, and
use `gt-hidden`
But there are some missed `hide`....
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-02 11:45:42 -06:00
Giteabot and Sybren
f8a40dafb9
Allow <video> in MarkDown ( #22892 ) ( #23236 )
...
Backport #22892
As you can imagine, for the Blender development process it is rather
nice to be able to include videos in issues, pull requests, etc.
This PR allows the `<video>` HTML tag to be used in MarkDown, with the
`src`, `autoplay`, and `controls` attributes.
## Help Needed
To have this fully functional, personally I feel the following things
are still missing, and would appreciate some help from the Gitea team.
### Styling
Some CSS is needed, but I couldn't figure out which of the LESS files
would work. I tried `web_src/less/markup/content.less` and
`web_src/less/_base.less`, but after running `make` the changes weren't
seen in the frontend.
This I would consider a minimal set of CSS rules to be applied:
```css
video {
max-width: 100%;
max-height: 100vh;
}
```
### Default Attributes
It would be fantastic if Gitea could add some default attributes to the
`<video>` tag. Basically `controls` should always be there, as there is
no point in disallowing scrolling through videos, looping them, etc.
### Integration with the attachments system
Another thing that could be added, but probably should be done in a
separate PR, is the integration with the attachments system. Dragging in
a video should attach it, then generate the appropriate MarkDown/HTML.
Co-authored-by: Sybren <122987084+drsybren@users.noreply.github.com >
2023-03-02 11:49:05 -05:00
Giteabot and wxiaoguang
9843a0b741
Close the temp file when dumping database to make the temp file can be deleted on Windows ( #23249 ) ( #23251 )
...
Backport #23249
There was no `dbDump.Close()` before, Windows doesn't like to delete
opened files.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-02 11:47:07 -05:00
085a4debd5
Fix incorrect checkbox behaviors in the dashboard repolist's filter ( #23147 ) ( #23205 )
...
Backport #23147
Co-author: yp05327 , this PR is based on yp05327's #22813 .
The problems of the old DashboardRepoList / repolist.tmpl:
* It mixes many different frameworks together
* It "just works", bug on bug
* It uses many anti-pattern of Vue
This PR:
* Fix bugs and close #22800
* Decouple the "checkbox" elements from Fomantic UI (only use CSS
styles)
* Simplify the HTML layout
* Simplify JS logic
* Make it easier to refactor the DashboardRepoList into a pure Vue
component in the future.
### Screenshots
#### Default
#### Click "Archived" to make it checked
#### Click "Archived" to make it intermediate
#### Click "Archived" to make it unchecked
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-02 15:12:33 +08:00
4c1e24864f
Order pull request conflict checking by recently updated, for each push ( #23220 ) ( #23225 )
...
Backport #23220
When a change is pushed to the default branch and many pull requests are
open for that branch, conflict checking can take some time.
Previously it would go from oldest to newest pull request. Now
prioritize pull requests that are likely being actively worked on or
prepared for merging.
This only changes the order within one push to one repository, but the
change is trivial and can already be quite helpful for smaller Gitea
instances where a few repositories have most pull requests. A global
order would require deeper changes to queues.
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-02 13:12:41 +08:00
Giteabot and Lauris BH
5d5f907e7f
Add loading yaml label template files ( #22976 ) ( #23232 )
...
Backport #22976
Extract from #11669 and enhancement to #22585 to support exclusive
scoped labels in label templates
* Move label template functionality to label module
* Fix handling of color codes
* Add Advanced label template
Co-authored-by: Lauris BH <lauris@nix.lv >
2023-03-01 21:57:34 -05:00
Giteabot and Brecht Van Lommel
39178b5756
Do not create commit graph for temporary repos ( #23219 ) ( #23229 )
...
Backport #23219
When fetching remotes for conflict checking, skip unnecessary and
potentially slow writing of commit graphs.
In a test with the Blender repository, this reduces conflict checking
time for one pull request from about 2s to 0.1s.
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2023-03-02 01:53:41 +02:00
Giteabot and wxiaoguang
3d8412dd51
Use the correct selector to hide the checkmark of selected labels on clear ( #23224 ) ( #23228 )
...
Backport #23224
Regression of #10107
(https://github.com/go-gitea/gitea/pull/10107/files#diff-a15e36f2f9c13339f7fdd38bc2887db2ff2945cb8434464318ab9105fcc846bdR460 )
Fix #22222
Before: the "clear" action couldn't remove these check marks.
After: the "clear" action can remove these check marks.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-01 15:59:36 -05:00
Giteabot and Philip Peterson
13918ad344
Pass --global when calling git config --get, for consistency with git config --set ( #23157 ) ( #23199 )
...
Backport #23157
This arose out of #22451 ; it seems we are checking using non-global
settings to see if a config value is set, in order to decide whether to
call another global(-indeed) configuration command. This PR changes it
so that both the check and the set are for global configuration.
Co-authored-by: Philip Peterson <philip-peterson@users.noreply.github.com >
2023-02-28 17:53:15 -05:00
Giteabot and wxiaoguang
7528ce60e7
Make gitea serv respect git binary home ( #23138 ) ( #23197 )
...
Backport #23138
Close #23137
The old code is too old (8-9 years ago)
Let's try to execute the git commands from git bin home directly.
The verb has been checked above, it could only be:
* git-upload-pack
* git-upload-archive
* git-receive-pack
* git-lfs-authenticate
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-02-28 16:46:23 -06:00
GiteaBot
e31c6166ee
[skip ci] Updated translations via Crowdin
2022-05-31 00:10:30 +00:00
GiteaBot
fe4c846ccb
[skip ci] Updated translations via Crowdin
2022-05-30 00:10:14 +00:00
GiteaBot
76681883ec
[skip ci] Updated translations via Crowdin
2022-05-29 00:10:54 +00:00
GiteaBot
cfb4c23a50
[skip ci] Updated translations via Crowdin
2022-05-28 00:10:25 +00:00
GiteaBot
7671a3322b
[skip ci] Updated translations via Crowdin
2022-05-24 00:10:14 +00:00
GiteaBot
d2a91e5e59
[skip ci] Updated translations via Crowdin
2022-05-23 00:10:14 +00:00
GiteaBot
fa5dec966c
[skip ci] Updated licenses and gitignores
2022-05-22 00:10:22 +00:00
GiteaBot
6d54799bbc
[skip ci] Updated translations via Crowdin
2022-05-17 00:10:28 +00:00
GiteaBot
761d4f40be
[skip ci] Updated translations via Crowdin
2022-05-15 00:10:15 +00:00
GiteaBot
cafa2dcb87
[skip ci] Updated translations via Crowdin
2022-05-13 00:10:14 +00:00
GiteaBot
d985dcc922
[skip ci] Updated translations via Crowdin
2022-05-12 00:10:15 +00:00
GiteaBot
9fc194d2d9
[skip ci] Updated translations via Crowdin
2022-05-10 00:10:16 +00:00
GiteaBot
cd99540cdc
[skip ci] Updated translations via Crowdin
2022-05-09 00:10:13 +00:00
GiteaBot
5a9c505e14
[skip ci] Updated translations via Crowdin
2022-05-07 00:10:19 +00:00
GiteaBot
5a75a5463e
[skip ci] Updated translations via Crowdin
2022-05-05 00:10:22 +00:00
GiteaBot
05234adfa8
[skip ci] Updated translations via Crowdin
2022-05-02 00:10:25 +00:00
GiteaBot
094c8fdc87
[skip ci] Updated licenses and gitignores
2022-05-01 00:25:27 +00:00
GiteaBot
bf7258be9c
[skip ci] Updated translations via Crowdin
2022-04-30 00:10:15 +00:00
GiteaBot
53829b84f0
[skip ci] Updated translations via Crowdin
2022-04-29 00:10:15 +00:00
GiteaBot
960b813a33
[skip ci] Updated translations via Crowdin
2022-04-28 00:10:43 +00:00
GiteaBot
741c55b4ea
[skip ci] Updated translations via Crowdin
2022-04-26 00:10:13 +00:00
GiteaBot
5e4134b117
[skip ci] Updated translations via Crowdin
2022-04-25 00:10:29 +00:00
GiteaBot
0abd8b0abc
[skip ci] Updated translations via Crowdin
2022-04-24 00:10:14 +00:00
GiteaBot
9550e5a23e
[skip ci] Updated translations via Crowdin
2022-04-23 00:10:15 +00:00
GiteaBot
0dfc2e55ea
[skip ci] Updated translations via Crowdin
2022-04-22 00:10:36 +00:00
GiteaBot
f7a8e5c8f2
[skip ci] Updated translations via Crowdin
2022-04-21 00:10:26 +00:00
GiteaBot
b74322dfce
[skip ci] Updated translations via Crowdin
2022-04-18 00:10:09 +00:00
GiteaBot
490065b93b
[skip ci] Updated licenses and gitignores
2022-04-17 00:10:24 +00:00
GiteaBot
3255ba9305
[skip ci] Updated translations via Crowdin
2022-04-13 00:10:15 +00:00
GiteabotandHester Gong
