sebastian-sauer and GitHub
e116ad4500
Load reviewer before sending notification ( #27063 )
...
The
[template](https://github.com/go-gitea/gitea/blob/main/templates/mail/issue/default.tmpl#L51 )
uses the Reviewer.Name property - this was not loaded.
Fixes #27035
2023-09-13 19:48:36 +00:00
sebastian-sauer and GitHub
70647bd04c
Use yellow if an approved review is stale ( #26312 )
...
By using a different color it's clear that the review isn't pointing to
the latest commit.
**Screenshots:**
Not stale review:
Stale review:
fixes #26306
2023-08-04 00:28:21 +03:00
55532061c8
Add commits dropdown in PR files view and allow commit by commit review ( #25528 )
...
This PR adds a new dropdown to select a commit or a commit range
(shift-click like github) of a Pull Request.
After selection of a commit only the changes of this commit will be shown.
When selecting a range of commits the diff of this range is shown.
This allows to review a PR commit by commit or by viewing only commit ranges.
The "Show changes since your last review" mechanism github uses is implemented, too.
When reviewing a single commit or a commit range the "Viewed" functionality is disabled.
## Screenshots
### The commit dropdown
### Selecting a commit range
### Show changes of a single commit only
### Show changes of a commit range
Fixes https://github.com/go-gitea/gitea/issues/20989
Fixes https://github.com/go-gitea/gitea/issues/19263
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-07-28 21:18:12 +02:00
sebastian-sauer and GitHub
d473de0c2d
Make add line comment buttons focusable ( #25894 )
...
Use a real button and add an aria-label.
Additionally, show the button whenever it is focused.
See https://codeberg.org/forgejo/forgejo/issues/998 for explanation.
Our handling of this button is now equal to that of GitHub.
Nothing has changed visually.
2023-07-15 11:45:34 +02:00
sebastian-sauer and GitHub
b81c013057
Don't stack PR tab menu on small screens ( #25789 )
...
the stacking takes up screen space - display the tabs as the navigation
bar. github uses the same layout.
Screenshots (left before, right after):
Large screen:
2023-07-14 01:54:20 +00:00
d2c3a90ee2
Show edit title button on commits tab of PR, too ( #25791 )
...
All 3 tabs of the PR (Conversation, Commits and Files changed) should
show the edit title button.
Before this commit the edit button was not shown on commits tab
Screenshots:
After:
Before:
Just for reference the edit button in files changed tab:
Co-authored-by: Giteabot <teabot@gitea.io >
2023-07-10 09:05:59 +02:00
f03d95f0a9
Allow/fix review (approve/reject) of empty PRs ( #25690 )
...
gitea allows to create empty PRs.
Currently when you need approvals for a merge, you have to manually add
/files to the url to get to the files tab to approve / reject the PR.
This PR allows to open the files tab via the normal tab / link and then
fixes the layout of the files tab.
**Screenshots:**
Before:
After:
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-07-06 15:33:04 +00:00
sebastian-sauer and GitHub
ed8a8af99f
Use AfterCommitId to get commit for Viewed functionality ( #25529 )
...
the PullHeadCommitID is not always available when the PR is merged.
Not sure if this is the best solution but in my simple tests it looks
like this fixes the problem - happy to get any feedback.
hopefully fixes https://github.com/go-gitea/gitea/issues/24813
2023-07-01 00:08:18 +08:00
sebastian-sauer and GitHub
7609f2f27e
Link to existing PR when trying to open a new PR on the same branches ( #25494 )
...
when trying to create a PR for an existing PRs branch combination link
to the PR directly and not just to the repo.
Before:
After:
2023-06-25 10:03:36 +00:00
77e449f0be
Highlight viewed files differently in the PR filetree ( #24956 )
...
fixes #24566
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-06-25 08:46:30 +08:00
25455bc670
Show outdated comments in files changed tab ( #24936 )
...
If enabled show a clickable label in the comment. A click on the label
opens the Conversation tab with the comment focussed - there you're able
to view the old diff (or original diff the comment was created on).
**Screenshots**
When resolved and outdated:
Option to enable/disable this (stored in user settings - default is
disabled):
fixes #24913
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-06-21 16:08:12 +00:00
31f934c1d8
Add filetree on left of diff view ( #21012 )
...
This PR adds a filetree to the left side of the files/diff view.
Initially the filetree will not be shown and may be shown via a new
"Show file tree" button.
Showing and hiding is using the same icon as github. Folders are
collapsible. On small devices (max-width 991 PX) the file tree will be
hidden.
Close #18192
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2022-09-27 13:22:19 +08:00
6fb7fb6cfc
Force color-adjust for markdown checkboxes ( #17146 )
...
this forces browsers to render background correctly
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2021-09-25 14:45:55 +08:00
92328a3394
Add API to get commits of PR ( #16300 )
...
* Add API to get commits of PR
fixes #10918
Co-authored-by: Andrew Bezold <andrew.bezold@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
2021-07-02 14:19:57 +02:00
sebastian-sauer and GitHub
e8c6cead0f
Fix list_options GetStartEnd ( #16303 )
...
end is start + pageSize and not start + page
2021-06-29 22:42:23 +01:00
sebastian-sauer and GitHub
6c3433151f
API: Allow COMMENT reviews to not specify a body ( #16229 )
...
* Allow COMMENT reviews to not specify a body
when using web ui there is no need to specify a body.
so we don't need to specify a body if adding a COMMENT-review
via our api.
* Ensure comments or Body is provided
and add some integration tests for reviewtype COMMENT.
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com >
2021-06-25 00:05:51 +02:00
sebastian-sauer and GitHub
66f8da538a
Use pulls url if issue is a pull request ( #16230 )
...
if a pull request is displayed use the /pulls path
if a pull requests diff is displayed use the /pulls/{id}/files url
if an issue is displayed use the issues url
Fixes #16102
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com >
2021-06-22 21:13:31 +01:00
90eeb6363c
Fix layout of milestone view ( #15927 )
...
fix #15047
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2021-05-20 17:53:55 -04:00
sebastian-sauer and zeripath
84076211b3
Config option to disable automatic repo watching ( #5852 )
...
Add a new config option to enable / disable the automatic watching of
repos for new repositories and if a user is added to a team.
Fixes #653
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com >
2019-01-27 09:25:21 +00:00
sebastian-sauer and techknowlogick
8656a3c62d
Move input fields to add members to a team and repos to a team ( #5853 )
...
Move input fields to the top so no scrolling is needed to add
new members / repos to a team.
Signed-off-by: Sebastian Sauer <sauer.sebastian@gmail.com >
2019-01-25 19:14:35 -05:00
sebastian-sauerandGitHub
