silverwind
45d8d63621
Remove -v from vulncheck ( #23953 ) ( #25654 )
...
Backport https://github.com/go-gitea/gitea/pull/23953 to 1.19 to fix the
branch build:
https://drone.gitea.io/go-gitea/gitea/75155/1/9
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-07-03 16:16:23 -04:00
Giteabot
b4bfaf7d4d
Add link to support page for commercial support ( #25293 ) ( #25299 )
...
Backport #25293 by @techknowlogick
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-06-16 14:19:26 +08:00
Jonathan Tran
1650a26eb5
Fix task list checkbox toggle to work with YAML front matter ( #25184 ) ( #25236 )
...
Backport https://github.com/go-gitea/gitea/pull/25184 by @jtran
Closes #25225 .
Fixes https://github.com/go-gitea/gitea/issues/25160 .
`data-source-position` of checkboxes in a task list was incorrect
whenever there was YAML front matter. This would result in issue content
or PR descriptions getting corrupted with random `x` or space characters
when a user checked or unchecked a task.
2023-06-13 20:22:59 +02:00
Giteabot
a9ebf911fa
Hide limited users if viewed by anonymous ghost ( #25214 ) ( #25224 )
...
Backport #25214 by @KN4CK3R
The ghost user leads to inclusion of limited users/orgs in
`BuildCanSeeUserCondition`.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-06-13 03:26:47 -04:00
Giteabot
de6ac4bf2a
Add WithPullRequest for actionsNotifier ( #25144 ) ( #25196 )
...
Backport #25144 by @Zettat123
Fix #25093
If
[`WithPullRequest`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L90-L96 )
is not called, the `Ref` in
[`notifyInput`](https://github.com/go-gitea/gitea/blob/679b1f7949aa40d4f962ef27f91b0b384b9c56a5/services/actions/notifier_helper.go#L55-L65 )
will be empty, so the workflows in the head branch will not be found and
triggered.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-06-11 17:29:25 +08:00
Lauris BH
a9030052a7
Fix open redirect check for more cases ( #25143 ) ( #25155 )
...
Backport https://github.com/go-gitea/gitea/pull/25143
If redirect_to parameter has set value starting with \\example.com
redirect will be created with header Location: /\\example.com that will
redirect to example.com domain.
2023-06-08 13:03:15 -04:00
HesterG
ed78711e46
Fix broken links in documents v1.19 ( #25142 )
...
Partially port #24630
2023-06-08 16:45:29 +08:00
HesterG
c23ab427e1
Change branch name from master to main in some documents' links ( #25126 ) ( #25139 )
...
Backport #25126
As title. And needs to backport to 1.19
2023-06-08 04:31:55 -04:00
sillyguodong
e3cdb050fa
add zh-cn for Upgrade from old Gitea in v1.19 ( #25022 )
...
as title
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-06-06 11:39:53 -04:00
techknowlogick
8df6713a6e
update labels link to correct location in 1.19 docs ( #25105 )
2023-06-06 11:29:16 -04:00
Giteabot
3ef97932d5
Fix parallelly generating index failure with Mysql ( #24567 ) ( #25081 )
...
Backport #24567 by @lunny
- Fix possible parallel creating commit status index problem and
creating issues/pull request index problem work with Mysql5/Mysql8
- Add parallel tests
- Reenable TestRepoCommitsStatusParallel on CI
Fix #22109
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-06-05 11:05:52 -04:00
Giteabot
15adec19e7
improve permission documentation ( #23942 ) ( #25078 )
2023-06-05 18:04:59 +08:00
Giteabot
8e94b715cc
GitLab migration: Sanitize response for reaction list ( #25054 ) ( #25059 )
...
Backport #25054 by @6543
Co-authored-by: 6543 <6543@obermui.de >
2023-06-02 17:13:33 -04:00
HesterG
b2ec116c60
Add oauth Chinese document for v1.19 ( #25020 )
2023-06-02 10:52:53 -04:00
HesterG
edfa2c5b78
Port Chinese document for localization to v1.19 ( #25021 )
2023-06-02 10:49:33 -04:00
Giteabot
73ae6b21d1
Fix users cannot visit issue attachment bug ( #25019 ) ( #25027 )
...
Backport #25019 by @lunny
Caused by #24362
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-06-01 19:22:26 +02:00
silverwind
b83e4f295d
Run markdownlint on drone, fix lint issue ( #25040 )
...
It currently does not run on 1.19 branch, resulting in lint error having
landed in https://github.com/go-gitea/gitea/pull/25016 .
2023-06-01 10:34:40 -05:00
sillyguodong
95bf09fca0
Add chinese documentations for Packages ( #24914 ) ( #25016 )
...
backport: #24914
2023-05-31 15:55:01 +08:00
sillyguodong
3b5cc02345
Add chinese documentations for installation ( #24904 ) ( #25015 )
...
backport #24904
2023-05-31 14:17:19 +08:00
HesterG
37b73b3337
Add Chinese docs for help, contribution and development ( #24925 ) ( #25011 )
...
Backport #24925 , partially backport #24934
(`docs/content/doc/help/faq.zh-cn.md` file)
Part of backport has already done by #24942
Also backport #24881 to avoid "deadlock"
---------
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-05-31 14:12:37 +08:00
HesterG
d2c9fb02dd
Unify doc links to use paths relative to doc folder ( #24979 ) ( #25000 )
...
Backport #24979
Changes:
1. Use uniform links types relative to doc folder (start with `doc/`)
2. According to [docusaurus
links](https://docusaurus.io/docs/markdown-features/links ), if `<a>` is
used, the `href` is resolved as URL location, but not file location. So
need to use `[text]({{< relref "path" >}})` instead.
2023-05-30 18:08:32 +08:00
HesterG
cdeb55f6e5
Remove unnecessary content on docs ( #24976 ) ( #25001 )
...
Backport #24976
2023-05-30 17:21:03 +08:00
Giteabot
0ef7b66018
Update from-binary.en-us.md ( #24975 ) ( #24999 )
...
Backport #24975 by @team-epk
Fixed link to the creating a systemd service in Ubuntu document.
2023-05-30 14:01:06 +08:00
sillyguodong
826b7b979c
Fix missing reference prefix of commits when sync mirror repository ( #24994 )
...
replace #24868
just a patch to fix #24824 in v1.19.4
The reference name of commits when synchronizing should also has prefix
like refs/heads/<branch-name>.
2023-05-30 13:12:21 +08:00
Amos (LFlare) Ng
7dc46ffbaa
Match unqualified references when syncing pulls as well ( #23070 )
...
It seems that `opts.RefFullName` may occassionally be set
to just the branch name, without the `refs/heads/` prefixing.
2023-05-29 11:32:32 +02:00
Giteabot
3a7e0953c1
zh-cn translation for usage docs (#24897 ) ( #24977 )
...
Backport #24897 by @Zettat123
- [x] agit-support
- [x] clone-filter
- [x] incoming-email
- [x] labels
- [x] linked-references
- [x] merge-message-templates
- [x] permissions
- [x] profile-readme
- [x] protected-tags
- [x] push
- [x] repo-mirror
- [x] secrets
- [x] template-repositories
- [x] webhooks
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-05-29 11:53:11 +08:00
Giteabot
9da84a36eb
simple docs fixes: 'pull request' page (en-us & zh-tw) link path to 'issue-pull-request-templates' ( #24961 ) ( #24970 )
...
Backport #24961 by @jonkeim
Co-authored-by: Jon Keim <jon@windless.org >
Co-authored-by: silverwind <me@silverwind.io >
2023-05-28 21:51:53 -04:00
Giteabot
8a6a1143a4
Remove reference to caddy v1 in docs ( #24962 ) ( #24964 )
...
Backport #24962 by @techknowlogick
caddy v1 is loong eol. v2 should be used.
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-05-28 05:34:50 -04:00
HesterG
b4cd1028d9
Fix doc for 1.19 backend guideline ( #24942 )
...
Port the file change in
https://github.com/go-gitea/gitea/pull/24925/files from `main` to
`v1.19` to fix docs
2023-05-26 17:22:38 +08:00
Giteabot
d1af0a3e4c
Merge two translation contributing documents ( #23939 ) ( #24933 )
...
Backport #23939 by @lunny
This PR also adjusts the weights.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2023-05-25 12:07:25 -04:00
wxiaoguang
a83d597989
Merge different languages for language stats ( #24900 ) ( #24921 )
...
Backport #24900
Fix #24896
If users set different languages by `linguist-language`, the `stats` map
could be: `java: 100, Java: 200`.
Language stats are stored as case-insensitive in database and there is a
unique key.
So, the different language names should be merged to one unique name:
`Java: 300`
2023-05-25 07:12:21 +02:00
Paweł Bogusławski
c5dee8823c
Hiding Secrets options when Actions feature is disabled ( #24792 )
...
`Secrets` options should be hidden if `Actions` feature is disabled.
This fixes in release/v1.19. In main probably fixed in
63a401ac40 (didn't check).
Fixes: 659055138b
Author-Change-Id: IB#1134011
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl >
2023-05-24 18:01:11 +08:00
Giteabot
275abd6593
Only validate changed columns when update user ( #24867 ) ( #24903 )
...
Backport #24867 by @lunny
Fix #23211
Replace #23496
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-24 04:24:02 -04:00
wxiaoguang
d19d5bc5b8
Make DeleteIssue use correct context ( #24885 )
...
Fix #24884 , the `ctx.Repo.GitRepo` might be nil.
2023-05-23 13:11:19 -04:00
Lunny Xiao
e7757aa4be
Remove unnecessary prefix usage ( #24888 )
...
Since now all articles have a class, the `Usage:` is unnecessary. This
PR will remove them.
2023-05-24 00:34:31 +08:00
silverwind
e81d38b0f6
Set --font-weight-bold to 600 ( #24840 )
...
Backport of https://github.com/go-gitea/gitea/pull/24827 to 1.19, just
the font weight reduction.
2023-05-22 10:56:41 +08:00
Giteabot
f29c52a169
Return 404 in the API if the requested webhooks were not found ( #24823 ) ( #24830 )
...
Backport #24823 by @sonjek
Should resolve first point of the issue
https://github.com/go-gitea/gitea/issues/24574
Co-authored-by: Yevhen Pavlov <yevhen.pavlov.ua@gmail.com >
2023-05-21 14:05:58 -04:00
Giteabot
04f9ab1aa9
Fix topics deleted via API not being deleted in org page ( #24825 ) ( #24829 )
...
Backport #24825 by @yardenshoham
The topics are saved in the repo_topic table with a repoID key. They are
also saved directly in the repository table.
Before this PR, only `AddTopic` and `SaveTopics` made sure the `topics`
field in the repository field was synced with the repo_topic table.
This PR makes sure `GenerateTopics` and `DeleteTopic` also sync the
`topics` in the repository table.
`RemoveTopicsFromRepo` doesn't need to sync the data as it is only used
to delete a repository.
- Fixes #24820
2023-05-21 20:48:54 +08:00
Giteabot
b369ed579d
Fix Actions being enabled accidentally ( #24802 ) ( #24810 )
...
Backport #24802 by @wolfogre
Regression of #24536 . If the user doesn't explicitly disable Actions, it
will be enabled.
1. Gitea will call `loadRepositoryFrom` before `loadActionsFrom`.
https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/setting.go#L234-L237
2. In `loadRepositoryFrom`,
`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` will set
`actions.ENABLED` with `true`.
https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/repository.go#L313-L315
3. In `loadActionsFrom`, `rootCfg.Section("actions")` will get a section
with Actions enabled.
https://github.com/go-gitea/gitea/blob/25d4f95df25dae5226e96e813dde87b071d9155e/modules/setting/actions.go#L23-L26
Although the cause of the problem was using `true` by copy-paste
mistake, it also surprised me that
**`rootCfg.Section("actions").Key("ENABLED").MustBool(true)` doesn't
only read, but also write.**
Co-authored-by: Jason Song <i@wolfogre.com >
2023-05-19 15:17:48 +02:00
wxiaoguang
64cc691b7f
Fix safari cookie session bug ( #24772 )
...
Partically backport #24330
Related: #24176
Maybe fix #24770
2023-05-18 09:10:23 +08:00
Giteabot
1bad05da3d
Fix missed table name on iterate lfs meta objects ( #24768 ) ( #24774 )
...
Backport #24768 by @lunny
Fix #24763
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-17 20:35:20 +02:00
Giteabot
57f520e7e5
Make mailer SMTP check have timed context ( #24751 ) ( #24759 )
...
Backport #24751 by @wxiaoguang
Make mailer SMTP check have timed context
Otherwise Gitea may block for long time if the DNS request blocks.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-05-17 06:08:39 -04:00
Giteabot
e4f200e616
Respect original content when creating secrets ( #24745 ) ( #24746 )
...
Backport #24745 by @wolfogre
Fix #24721 .
Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.
Did some tests with:
```yaml
name: secrets
on: push
jobs:
show_secrets:
runs-on: ubuntu-latest
steps:
- name: Dump secrets context
run: echo '${{ toJSON(secrets) }}' | base64
```
`AAAAAA`:
```text
AAAAAA
AAAAAA
```
`BBBBBB`:
```text
BBBBBB
BBBBBB
```
On GitHub:
<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8 ">
On Gitea (before):
<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2 ">
On Gitea (after):
<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a ">
Co-authored-by: Jason Song <i@wolfogre.com >
2023-05-16 03:33:47 -04:00
wxiaoguang
6ecd2e782f
Fix Pull Mirror out-of-sync bugs ( #24732 ) ( #24733 )
...
Backport #24732
Bug-fix only
2023-05-15 20:30:21 +02:00
Giteabot
2fea93b2d3
Fix run list broken when trigger user deleted ( #24706 ) ( #24709 )
...
Backport #24706 by @lunny
Fix #24682
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-14 04:55:58 -04:00
Giteabot
0ee51a5221
Add test for api team organization ( #24699 ) ( #24702 )
...
Backport #24699 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-13 18:08:53 -04:00
Giteabot
da1c38dd47
Fix organization field being null in GET /api/v1/teams/{id} ( #24694 ) ( #24696 )
...
Backport #24694 by @yardenshoham
Enabled the organization loading flag.
- Fixes #20399
# Before
```json
{
...
"description": "",
"organization": null,
"includes_all_repositories": true,
"permission": "owner",
...
}
```
# After
```json
{
...
"description": "",
"organization": {
"id": 2,
"name": "bigorg",
"full_name": "",
"avatar_url": "https://3000-yardenshoham-gitea-3gfrlc9gn4h.ws-us96b.gitpod.io/avatars/e2649b0c016d9102664a7d4349503eb9 ",
"description": "",
"website": "",
"location": "",
"visibility": "public",
"repo_admin_change_team_access": true,
"username": "bigorg"
},
"includes_all_repositories": true,
"permission": "owner",
...
}
```
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: Yarden Shoham <git@yardenshoham.com >
2023-05-13 21:01:54 +02:00
Giteabot
aa984f21fa
Fix docs documenting invalid @every for OLDER_THAN cron settings ( #24695 ) ( #24698 )
...
Backport #24695 by @yardenshoham
Looks like a copy-paste leftover
- Fixes #20868
Co-authored-by: Yarden Shoham <git@yardenshoham.com >
2023-05-13 23:47:56 +08:00
Giteabot
8f722012f6
Fix issues list page multiple selection update milestones ( #24660 ) ( #24663 )
...
Backport #24660 by @lunny
Fix #24651
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-12 14:58:46 -04:00
oliverpool
cb7ba8969d
fix: release page for empty or non-existing target ( #24659 )
...
Backport #24470
Fixes #24145
---
To solve the bug, I added a "computed" `TargetBehind` field to the
`Release` model, which indicates the target branch of a release. This is
particularly useful if the target branch was deleted in the meantime (or
is empty).
I also did a micro-optimization in `calReleaseNumCommitsBehind`. Instead
of checking that a branch exists and then call `GetBranchCommit`, I
immediately call `GetBranchCommit` and handle the `git.ErrNotExist`
error.
This optimization is covered by the added unit test.
_contributed in the context of @forgejo_
2023-05-12 14:14:41 -04:00