silverwind and GitHub
2c92c7c522
Add typescript guideline and typescript-specific eslint plugins and fix issues ( #31521 )
...
1. Add some general guidelines how to write our typescript code
2. Add `@typescript-eslint/eslint-plugin`, general typescript rules
3. Add `eslint-plugin-deprecation` to detect deprecated code
4. Fix all new lint issues that came up
2024-07-03 17:48:14 +02:00
silverwind and GitHub
b270b30aeb
Update golang.org/x/image to v0.18.0 ( #31541 )
...
Result of `go get -u golang.org/x/image && make tidy`
Fixes: https://github.com/go-gitea/gitea/security/dependabot/67
2024-07-02 15:41:14 -04:00
silverwind and GitHub
5821d22891
Use stable version of fabric ( #31526 )
...
Fabric 6 is [now
stable](https://github.com/fabricjs/fabric.js/releases/tag/v6.0.0-rc5 ),
use it.
2024-06-29 18:37:18 +03:00
silverwind and GitHub
e82f3caa6b
Always use HTML attributes for avatar size ( #31509 )
...
Many avatars were rendered in HTML with certain width/height but then
resized again in CSS. This was pointless so I removed all these cases
and made the HTML size match the previous render size.
Also did a few CSS cleanups in the tribute rendering:
<img width="648" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/cb2fafb3-5e20-46e9-814f-07df20038beb ">
2024-06-28 21:29:15 +00:00
silverwind and GitHub
08579d6cbb
Add initial typescript config and use it for eslint,vitest,playwright ( #31186 )
...
This enables eslint to use the typescript parser and resolver which
brings some benefits that eslint rules now have type information
available and a tsconfig.json is required for the upcoming typescript
migration as well. Notable changes done:
- Add typescript parser and resolver
- Move the vue-specific config into the root file
- Enable `vue-scoped-css/enforce-style-type` rule, there was only one
violation and I added a inline disable there.
- Fix new lint errors that were detected because of the parser change
- Update `i/no-unresolved` to remove now-unnecessary workaround for the
resolver
- Disable `i/no-named-as-default` as it seems to raise bogus issues in
the webpack config
- Change vitest config to typescript
- Change playwright config to typescript
- Add `eslint-plugin-playwright` and fix issues
- Add `tsc` linting to `make lint-js`
2024-06-28 16:15:51 +00:00
silverwind and GitHub
62b3738968
Fix JS error with disabled attachment and easymde ( #31511 )
...
Not sure if this is a regression from
https://github.com/go-gitea/gitea/pull/30513 , but when attachments are
disabled, `this.dropzone` is null and the code had failed in
`initEasyMDEPaste` trying to access `dropzoneEl.dropzone`.
2024-06-28 13:59:22 +08:00
silverwind and GitHub
996037fb6a
Fix deprecated Dockerfile ENV format ( #31450 )
...
See
https://docs.docker.com/reference/build-checks/legacy-key-value-format/ .
Fixes these warnings seen during the docker build:
```
4 warnings found (use --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 5)
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 9)
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 75)
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 76)
```
Introduced in: https://github.com/moby/buildkit/pull/4923
2024-06-21 11:08:42 -04:00
silverwind and GitHub
6f2e150aeb
README Badge maintenance ( #31441 )
...
1. Remove tickgit badge, the service [only gives
errors](https://www.tickgit.com/browse?repo=github.com/go-gitea/gitea&branch=main )
and the repo [seems
unmaintained](https://github.com/augmentable-dev/tickgit ).
2. Color the gitpod badge green because grey badges look odd.
2024-06-21 13:18:39 +00:00
silverwind and GitHub
1c15452687
Reduce air verbosity ( #31417 )
...
Make `air` log less. Uses the option added in
https://github.com/air-verse/air/pull/367 .
2024-06-19 19:42:06 +00:00
silverwind and GitHub
566d87bb8e
Fix new issue/pr avatar ( #31419 )
...
The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.
2024-06-19 16:19:59 +00:00
17baf1af10
Update JS dependencies, remove eslint-plugin-jquery ( #31402 )
...
- Result of `make update-js`
- Added 1 new eslint rule
- Autofixed 1 new eslint issue
- Remove `eslint-plugin-jquery` as `eslint-plugin-no-jquery` does all it
does and is actually the maintained fork of it.
- Tested all affected `dependencies`
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-06-18 08:10:30 +00:00
4b6eb46e69
Fix double border in system status table ( #31363 )
...
Fix regression from https://github.com/go-gitea/gitea/pull/30712 where
the introduction of this `<div>` caused the `.ui.attached:not(.message)
+ .ui.attached.segment:not(.top)` CSS selector to no longer work and
cause a double border.
Before:
<img width="200" alt="Screenshot 2024-06-13 at 19 06 12"
src="https://github.com/go-gitea/gitea/assets/115237/a9fa0688-adf0-4b2d-a958-6a7679a62031 ">
After:
<img width="232" alt="Screenshot 2024-06-13 at 19 05 57"
src="https://github.com/go-gitea/gitea/assets/115237/025b780f-f72f-4049-86de-a5d84851bd1d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-06-17 15:21:59 +02:00
silverwind and GitHub
90bcdf9829
Fix line number widths ( #31341 )
...
Fixes regression
https://github.com/go-gitea/gitea/pull/31307#issuecomment-2162554913
Table CSS is weird. A `auto` value does not work and causes the
regression while any pixel value causes another regression in diff where
the code lines do not stretch. Partially revert that PR and clean up
some related too-deep CSS selectors.
<img width="109" alt="Screenshot 2024-06-12 at 15 07 22"
src="https://github.com/go-gitea/gitea/assets/115237/756c5dea-44b8-49f9-8a08-acef68075f62 ">
<img width="119" alt="Screenshot 2024-06-12 at 15 07 43"
src="https://github.com/go-gitea/gitea/assets/115237/28ae1adc-118e-4016-8d09-033b9f1c9a6f ">
<img width="151" alt="Screenshot 2024-06-12 at 15 07 07"
src="https://github.com/go-gitea/gitea/assets/115237/08db7ed9-de4e-405e-874d-c7ebe3082557 ">
<img width="141" alt="Screenshot 2024-06-12 at 15 07 14"
src="https://github.com/go-gitea/gitea/assets/115237/c4a5492b-1bf1-4773-bc8d-64eb36d823f9 ">
2024-06-12 15:23:42 +00:00
21ba5ca03b
Fix navbar + menu flashing on page load ( #31281 )
...
Fixes
https://github.com/go-gitea/gitea/pull/31273#issuecomment-2153771331 .
Same method as used in https://github.com/go-gitea/gitea/pull/30215 . All
left-opening dropdowns need to use it method.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-06-12 14:58:03 +00:00
fc2d75f86d
Enable unparam linter ( #31277 )
...
Enable [unparam](https://github.com/mvdan/unparam ) linter.
Often I could not tell the intention why param is unused, so I put
`//nolint` for those cases like webhook request creation functions never
using `ctx`.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2024-06-11 18:47:45 +00:00
silverwind and GitHub
397930d8c1
Fix line number width in code preview ( #31307 )
...
Line numbers were using some hacky CSS `width: 1%` that did nothing to
the code rendering as far as I can tell but broken the inline preview in
markup when line numbers are greater than 2 digits. Also I removed one
duplicate `font-family` rule (it is set below in the `.lines-num,
.lines-code` selector.
2024-06-11 04:54:39 +00:00
507fbf4c3c
Use querySelector over alternative DOM methods ( #31280 )
...
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164 ,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md )
and autofixing all except 10 issues.
According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/ ),
querySelector may be faster as well, so it's a win-win.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-06-10 22:49:33 +02:00
a2304cb163
Remove jQuery .text() ( #30506 )
...
Remove and forbid [.text()](https://api.jquery.com/text/ ). Tested some,
but not all functionality, but I think these are pretty safe
replacements.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-06-10 18:12:31 +08:00
291a00dc57
Fix and clean up ConfirmModal ( #31283 )
...
Bug: orange button color was removed in
https://github.com/go-gitea/gitea/pull/30475 , replaced with red
Bug: translation text was not html-escaped
Refactor: Replaced as much jQuery as possible, added useful
`createElementFromHTML`
Refactor: Remove colors checks that don't exist on `.link-action`
<img width="381" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/5900bf6a-8a86-4a86-b368-0559cbfea66e ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
2024-06-07 13:42:31 +00:00
silverwind and GitHub
15debbbe4e
Enable poetry non-package mode ( #31282 )
...
[Poetry
1.8.0](https://github.com/python-poetry/poetry/releases/tag/1.8.0 ) added
support for [non-package
mode](https://python-poetry.org/docs/basic-usage/#operating-modes ), e.g.
projects that are not python packages themselves like we are. Make use
of that and remove the previous workaround via `--no-root`.
2024-06-07 15:37:33 +02:00
silverwind and GitHub
24dace8f76
Update golang.org/x/net ( #31260 )
...
Result of `go get -u golang.org/x/net && make tidy`. ~~Fixes
https://pkg.go.dev/vuln/GO-2024-2887.~~
2024-06-06 04:29:42 +00:00
6a3c487d07
Add replacement module for mholt/archiver ( #31267 )
...
Switch to this fork tag:
https://github.com/anchore/archiver/releases/tag/v3.5.2 which includes
https://github.com/anchore/archiver/commit/82ca88a2eb24d418c30bf960ef071b0bbec04631 .
Ref: https://pkg.go.dev/vuln/GO-2024-2698
Ref: https://github.com/advisories/GHSA-rhh4-rh7c-7r5v
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2024-06-06 03:37:08 +00:00
silverwind and GitHub
816222243a
Add lint-go-gopls ( #30729 )
...
Uses `gopls check <files>` as a linter. Tested locally and brings up 149
errors currently for me. I don't think I want to fix them in this PR,
but I would like at least to get this analysis running on CI.
List of errors:
```
modules/indexer/code/indexer.go:181:11: impossible condition: nil != nil
routers/private/hook_post_receive.go:120:15: tautological condition: nil == nil
services/auth/source/oauth2/providers.go:185:9: tautological condition: nil == nil
services/convert/issue.go:216:11: tautological condition: non-nil != nil
tests/integration/git_test.go:332:9: impossible condition: nil != nil
services/migrations/migrate.go:179:24-43: unused parameter: ctx
services/repository/transfer.go:288:48-69: unused parameter: doer
tests/integration/api_repo_tags_test.go:75:41-61: unused parameter: session
tests/integration/git_test.go:696:64-74: unused parameter: baseBranch
tests/integration/gpg_git_test.go:265:27-39: unused parameter: t
tests/integration/gpg_git_test.go:284:23-29: unused parameter: tmpDir
tests/integration/gpg_git_test.go:284:31-35: unused parameter: name
tests/integration/gpg_git_test.go:284:37-42: unused parameter: email
```
2024-06-05 09:22:38 +08:00
silverwind and GitHub
138e946c3d
Replace gt-word-break with tw-break-anywhere ( #31183 )
...
`overflow-wrap: anywhere` is a superior alternative to `word-wrap:
break-word` and we were already setting it in the class. I tested a few
cases, all look good.
2024-06-04 13:57:11 +00:00
silverwind and GitHub
4ca65fabda
Remove .segment from .project-column ( #31204 )
...
Using `.segment` on the project columns is a major abuse of that class,
so remove it and instead set the border-radius directly on it.
Fixes: https://github.com/go-gitea/gitea/issues/31129
2024-06-04 07:46:05 +00:00
silverwind and GitHub
1f8ac27b31
Fix overflow on push notification ( #31179 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30063
<img width="1301" alt="Screenshot 2024-05-30 at 14 43 24"
src="https://github.com/go-gitea/gitea/assets/115237/00443af0-088d-49a5-be9e-8c9adcc2c01d ">
2024-06-04 07:14:24 +00:00
silverwind and GitHub
4f9b8b397c
Fix overflow on notifications ( #31178 )
...
Fixes https://github.com/go-gitea/gitea/issues/31170 .
<img width="1312" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/627711ed-93ca-4be6-b958-10d673ae9517 ">
2024-06-04 06:10:04 +00:00
silverwind and GitHub
a7557494ca
Update chroma to v2.14.0 ( #31177 )
...
https://github.com/alecthomas/chroma/releases/tag/v2.14.0
Tested it with a typescript file.
2024-06-04 05:34:34 +00:00
silverwind and GitHub
8c68c5e436
Move custom tw- helpers to tailwind plugin ( #31184 )
...
Move the previous custom `tw-` classes to be defined in a tailwind
plugin. I think it's cleaner that way and I also verified double-class
works as expected:
<img width="299" alt="Screenshot 2024-05-30 at 19 06 24"
src="https://github.com/go-gitea/gitea/assets/115237/003cbc76-2013-46a0-9e27-63023fa7c7a4 ">
2024-06-03 18:21:28 +00:00
silverwind and GitHub
0f0db6a14f
Remove unnecessary inline style for tab-size ( #31224 )
...
Move the rule to the parent node. `tab-size` is inherited so will work
just as before.
2024-06-03 17:21:45 +00:00
silverwind and GitHub
4b20b51f82
Update golangci-lint to v1.59.0 ( #31221 )
...
One new error regarding `fmt.Fscanf` error return in `gitdiff.go` but
I'm not touching that further right now as handling the error would
introduce a behaviour difference.
2024-06-03 07:04:35 +00:00
silverwind and GitHub
9b05bfb173
Fix overflow in issue card ( #31203 )
...
Before:
<img width="373" alt="Screenshot 2024-06-01 at 01 31 26"
src="https://github.com/go-gitea/gitea/assets/115237/82a210f2-c82e-4b7e-ac43-e70e46fa1186 ">
After:
<img width="376" alt="Screenshot 2024-06-01 at 01 31 32"
src="https://github.com/go-gitea/gitea/assets/115237/82d1b9f7-4fad-47bd-948a-04e1e7e006e6 ">
2024-06-03 00:09:51 +00:00
silverwind and GitHub
7034efc7dc
Use vertical layout for multiple code expander buttons ( #31122 )
...
Fixes: https://github.com/go-gitea/gitea/issues/31068
- Now it only does a single call to `GetExpandDirection` per line
instead of multiples.
- Exposed `data-expand-direction` to frontend so it can correctly size
the buttons (it's a pain to do in tables).
<img width="142" alt="Screenshot 2024-05-27 at 20 44 56"
src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941 ">
<img width="142" alt="Screenshot 2024-05-27 at 20 44 51"
src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892 ">
<img width="132" alt="Screenshot 2024-05-27 at 20 44 46"
src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 33"
src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8 ">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 26"
src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199 ">
<img width="78" alt="Screenshot 2024-05-27 at 20 44 20"
src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28 ">
Would backport as trivial enhancement.
2024-05-29 06:08:45 +00:00
silverwind and GitHub
1e3c4d8fc7
Improve mobile review ui ( #31091 )
...
Fixes: https://github.com/go-gitea/gitea/issues/31071
Not perfect but much better than before.
Before: Overflows, sticky not working, filename unreadable:
<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f ">
After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c ">
2024-05-28 13:41:37 +00:00
silverwind and GitHub
858d4f221d
Fix DashboardRepoList margin ( #31121 )
...
Fixes: https://github.com/go-gitea/gitea/issues/31115
<img width="476" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/ba508ba9-b02d-47c6-ad9f-495101c81330 ">
2024-05-28 02:13:42 +00:00
silverwind and GitHub
b6b32a5529
Update JS dependencies ( #31120 )
...
- Add `eslint-plugin-no-use-extend-native` to exclude list because it
requires flat config
- Exclude `@github/text-expander-element` because new version has broken
positioning
- Tested mermaid, monaco, swagger, chartjs
2024-05-28 01:50:28 +00:00
silverwind and GitHub
6e140b58dd
Prevent tab shifting, remove extra margin on fluid pages ( #31090 )
...
1. Extend concept of https://github.com/go-gitea/gitea/pull/29831 to all
tabular menus, there were only three left that weren't already
`<overflow-menu>`.
<img width="634" alt="Screenshot 2024-05-27 at 00 42 16"
src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd ">
<img width="965" alt="Screenshot 2024-05-27 at 00 29 32"
src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff ">
2. Remove extra padding on `fluid padded` container like for example PR
diff view. The page margin is already correctly sized via
`.ui.container`, so this was just extraneous padding that looked ugly.
Before:
<img width="1351" alt="Screenshot 2024-05-27 at 00 45 11"
src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472 ">
After:
<img width="1344" alt="Screenshot 2024-05-27 at 00 45 22"
src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b ">
3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title,
fixing overflow.
Before:
<img width="1333" alt="Screenshot 2024-05-27 at 00 50 14"
src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb ">
After:
<img width="1316" alt="Screenshot 2024-05-27 at 00 50 26"
src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8 ">
2024-05-27 06:45:16 +00:00
silverwind and GitHub
145baa2b3f
Fix border radius on hovered secondary menu ( #31089 )
...
Presumably a regression from
https://github.com/go-gitea/gitea/pull/30325 , these menus were showing a
border radius on hover, which is fixed with this change.
<img width="154" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf ">
2024-05-27 04:48:41 +00:00
silverwind and GitHub
2ced31e81d
Change --border-radius-circle to --border-radius-full ( #30936 )
...
Percentage-based `border-radius` [creates undesirable
ellipse](https://jsfiddle.net/silverwind/j9ko5wnt/4/ ) on non-square
content. Instead, use pixel value and use same wording `full` like
tailwind does, but increast to 99999px over their 9999px.
2024-05-25 14:33:34 +00:00
silverwind and GitHub
028992429a
Clean up revive linter config, tweak golangci output ( #30980 )
...
The `errorCode` and `warningCode` options were removed at some point,
they are not recognized by golangci-lint any more at least and they do
not match their published json schema. `confidence` and
`ignore-generated-header` are at the default value so does not need to
be configured.
https://golangci-lint.run/usage/linters/#revive
2024-05-18 08:53:28 +00:00
silverwind and GitHub
a73e3c6a69
Upgrade tqdm dependency ( #30996 )
...
Result of `make update-py`
Fixes: https://github.com/go-gitea/gitea/security/dependabot/65
2024-05-16 19:40:57 +00:00
silverwind and GitHub
ea8e4baacc
Put web editor into a segment ( #30966 )
...
Implement
https://github.com/go-gitea/gitea/pull/30707#issuecomment-2084126206
Diff without whitespace:
https://github.com/go-gitea/gitea/pull/30966/files?diff=unified&w=1
Might as well backport.
2024-05-15 14:54:34 +00:00
ed25676a9a
Restyle release list, fix branch dropdown ( #30837 )
...
Fixes https://github.com/go-gitea/gitea/issues/30821 and restyles the
release list.
Desktop:
<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd ">
Mobile:
<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-05-13 23:33:51 +02:00
silverwind and GitHub
301eaf60bf
Fix file path width in repo non-homepage view ( #30951 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30940
<img width="1310" alt="Screenshot 2024-05-11 at 20 48 41"
src="https://github.com/go-gitea/gitea/assets/115237/f163dfd4-1299-421f-a99e-cd0c793e0e3d ">
2024-05-12 04:02:25 +00:00
silverwind and GitHub
46b7004f05
Enable declaration-block-no-redundant-longhand-properties ( #30950 )
...
Enable
[`declaration-block-no-redundant-longhand-properties`](https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/ )
and autofix issues. The exclusions are because I find these two
shorthands to be harder to read.
2024-05-12 02:33:05 +00:00
silverwind and GitHub
3c2406a2f3
Use CSS inset shorthand ( #30939 )
...
Use [inset](https://developer.mozilla.org/en-US/docs/Web/CSS/inset )
shorthand instead of longhands. There may be more cases but these ones I
was able to definitely identify.
2024-05-11 14:28:56 +00:00
silverwind and GitHub
1f3ada47a3
Update JS dependencies, add new eslint rules ( #30840 )
2024-05-10 18:53:43 +00:00
silverwind and GitHub
5556782ebe
Forbid deprecated break-word in CSS ( #30934 )
...
Forbid
[deprecated](https://drafts.csswg.org/css-text-3/#word-break-property )
`break-word` and fix all occurences.
Regarding `overflow-wrap: break-word` vs `overflow-wrap: anywhere`:
Example of difference: https://jsfiddle.net/silverwind/1va6972r/
[Here](https://stackoverflow.com/questions/77651244 ) it says:
> The differences between normal, break-word and anywhere are only clear
if you are using width: min-content on the element containing the text,
and you also set a max-width. A pretty rare scenario.
I don't think this difference will make any practical impact as we are
not hitting this rare scenario.
2024-05-10 12:25:49 +00:00
silverwind and GitHub
d9b37d085a
Remove obsolete monaco workaround ( #30893 )
...
This workaround is not neccessary any more since monaco 0.35.0.
Ref: https://github.com/microsoft/monaco-editor/issues/2962
Ref: https://github.com/microsoft/vscode/pull/173688
2024-05-08 02:42:33 +00:00
c4e875402b
Fix JS error on pull request page ( #30838 )
...
Fix this error seen on PR page, regression from
https://github.com/go-gitea/gitea/pull/30803 :
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-05-03 10:12:10 +08:00
b30b7df9f4
Fix body margin shifting with modals, fix error on project column edit ( #30831 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30816 , regression from
https://github.com/go-gitea/gitea/pull/30723 .
Fixes: https://github.com/go-gitea/gitea/pull/30815 , regression from
https://github.com/go-gitea/gitea/pull/30723 .
Fomantic [expects a
callback](https://github.com/fomantic/Fomantic-UI/blob/59d9b409879ad9413ea0a3efa4ab2e51017ad9b9/src/definitions/modules/modal.js#L530-L534 )
to be called during `hide` which we did not do, so it could never remove
the margin it added to `body`.
I do observe the body content shifting to right by 1px when modal opens,
but this is a bug that existed on v1.21 as well, so not a regression.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-05-03 01:48:24 +00:00
silverwind and GitHub
c445a85528
Improve repo button row layout ( #30668 )
...
Since there is now a second `<input>` in the repo buttons, we can make a
better-looking layout with no empty space, except on mobile.
Also I fixed one bug with focus border on clone panel.
## Large
<img width="1163" alt="Screenshot 2024-04-23 at 22 25 22"
src="https://github.com/go-gitea/gitea/assets/115237/8135a572-aa67-4672-ad49-b76b06890b52 ">
## Medium
<img width="870" alt="Screenshot 2024-04-23 at 22 25 34"
src="https://github.com/go-gitea/gitea/assets/115237/9e93f61c-3315-4a78-8328-8cefad5b50fa ">
## Mobile
<img width="416" alt="Screenshot 2024-04-23 at 22 25 52"
src="https://github.com/go-gitea/gitea/assets/115237/859e341f-807a-48e6-8bcf-31715963216c ">
2024-05-02 19:10:49 +00:00
silverwind and GitHub
6f89d5e3a0
Add hover outline to heatmap squares ( #30828 )
...
Makes it easier to use because you see which square is currently
hovered:
<img width="314" alt="Screenshot 2024-05-02 at 15 38 20"
src="https://github.com/go-gitea/gitea/assets/115237/3a15dad1-2259-4f28-9fae-5cf6ad3d8798 ">
I did try a `scoped` style for this, but that did not work for some
reason.
2024-05-02 14:56:17 +00:00
silverwind and GitHub
9235442ba5
Remove external API calls in TestPassword ( #30716 )
...
The test had a dependency on `https://api.pwnedpasswords.com ` which
caused many failures on CI recently:
```
--- FAIL: TestPassword (2.37s)
pwn_test.go:41: Get "https://api.pwnedpasswords.com/range/e6b6a ": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
FAIL
coverage: 82.9% of statements
```
2024-05-02 14:43:23 +00:00
silverwind and GitHub
b1bb3642e5
Improve context popup rendering ( #30824 )
...
Before, lot of empty space when no labels or body:
<img width="281" alt="Screenshot 2024-05-02 at 13 51 29"
src="https://github.com/go-gitea/gitea/assets/115237/8a980ccd-d53c-43a3-a059-dc8c614621e1 ">
After, empty space collapsed:
<img width="306" alt="Screenshot 2024-05-02 at 13 51 16"
src="https://github.com/go-gitea/gitea/assets/115237/8d9c154d-5de1-43d0-8536-afd9194d99b3 ">
All `<p>` (unsuitable) and `<small>` (discouraged in favor of css) tags
are removed.
2024-05-02 15:42:33 +02:00
silverwind and GitHub
82eca44581
Fix rounded border for segment followed by pagination ( #30809 )
...
Fixes https://github.com/go-gitea/gitea/issues/30673 , specifically
https://github.com/go-gitea/gitea/issues/30673#issuecomment-2085329812 .
2024-05-02 09:25:55 +00:00
silverwind and GitHub
564102ce89
Rework and fix stopwatch ( #30732 )
...
Fixes https://github.com/go-gitea/gitea/issues/30721 and overhauls the
stopwatch. Time is now shown inside the "dot" icon and on both mobile
and desktop. All rendering is now done by `<relative-time>`, the
`pretty-ms` dependency is dropped.
Desktop:
<img width="557" alt="Screenshot 2024-04-29 at 22 33 27"
src="https://github.com/go-gitea/gitea/assets/115237/3a46cdbf-6af2-4bf9-b07f-021348badaac ">
Mobile:
<img width="640" alt="Screenshot 2024-04-29 at 22 34 19"
src="https://github.com/go-gitea/gitea/assets/115237/8a2beea7-bd5d-473f-8fff-66f63fd50877 ">
Note for tippy:
Previously, tippy instances defaulted to "menu" theme, but that theme is
really only meant for `.ui.menu`, so it was not optimal for the
stopwatch popover.
This introduces a unopinionated `default` theme that has no padding and
should be suitable for all content. I reviewed all existing uses and
explicitely set the desired `theme` on all of them.
2024-04-30 14:52:46 +00:00
610802df85
Fix tautological conditions ( #30735 )
...
As discovered by https://github.com/go-gitea/gitea/pull/30729 .
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-30 14:34:40 +02:00
a3d9f0d915
Fix all rounded borders, change affected tab menus to pills ( #30707 )
...
Fixes https://github.com/go-gitea/gitea/issues/30673 , all 23 issues.
Notes:
- Tab bar menus had to change to pills because of unsolvable issue with
the border-radius as tab bar renders a overlapping border onto the box
below. And I think pills look better.
- Added padding to code editor empty preview message
- Hide monaco's built-in blue focus border, we don't need it and it
never showed before either.
- Label add menu is simplified, removing the nested segment.
<img width="1322" alt="Screenshot 2024-04-25 at 22 26 19"
src="https://github.com/go-gitea/gitea/assets/115237/7e394e0c-b7ad-417d-8e9f-12f1dea93ed1 ">
<img width="1326" alt="Screenshot 2024-04-25 at 22 28 00"
src="https://github.com/go-gitea/gitea/assets/115237/66c8499f-aa9f-4d95-8cca-ef13dfa82c65 ">
<img width="997" alt="Screenshot 2024-04-25 at 22 36 53"
src="https://github.com/go-gitea/gitea/assets/115237/07896102-c71d-4246-8173-c2bc2e1d3cae ">
<img width="832" alt="Screenshot 2024-04-25 at 22 56 09"
src="https://github.com/go-gitea/gitea/assets/115237/d83afc96-08ca-4adc-baf4-3d02804be57c ">
<img width="361" alt="Screenshot 2024-04-25 at 22 57 12"
src="https://github.com/go-gitea/gitea/assets/115237/c7371a68-00b5-47d8-84d0-ddc5268b2b2c ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-29 20:53:15 +00:00
silverwind and GitHub
a21ca9b5a5
Remove fomantic dimmer module ( #30723 )
...
Tested extensively using modal which is the only dependant.
2024-04-29 14:49:50 +00:00
silverwind and GitHub
d89bf3d3ec
add built js files to eslint ignore ( #30737 )
...
For the rare case that some overzealous tooling wants to lint our output
files.
2024-04-28 22:27:14 +08:00
b93c87b6fe
Issue card improvements ( #30687 )
...
Fixes https://github.com/go-gitea/gitea/issues/30682 and does a few
improvements:
- Use gap instead of margin/padding
- Don't render empty image div
- Remove `right floated` class that did nothing
<img width="406" alt="Screenshot 2024-04-24 at 20 21 20"
src="https://github.com/go-gitea/gitea/assets/115237/2fa88707-c2c4-40df-aee7-a684c3097ed0 ">
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-04-27 13:35:26 +00:00
silverwind and GitHub
238eb3ff9f
Update JS dependencies ( #30713 )
...
- Update all JS dependencies
- Remove
[now-unnecessary](https://github.com/microsoft/monaco-editor/issues/4325 )
monaco workaround
- Update stylelint config for new rule
- Tested Monaco, Swagger UI, Mermaid
2024-04-27 11:28:28 +00:00
silverwind and GitHub
b2abac5e5f
Improve diff stats bar ( #30669 )
...
Minor tweaks:
- Remove unnecessary `item` class which was causing unwanted padding to
be added.
- Add some padding and prevent wrapping so it looks better on mobile.
- Increase width by 4px.
<img width="116" alt="Screenshot 2024-04-24 at 00 15 07"
src="https://github.com/go-gitea/gitea/assets/115237/1f1cf54c-8053-4297-b309-71d9c2ceb9ee ">
<img width="441" alt="Screenshot 2024-04-24 at 00 14 57"
src="https://github.com/go-gitea/gitea/assets/115237/2f3a33dc-edad-4b97-b64c-6812aae513cb ">
2024-04-27 11:22:55 +00:00
silverwind and GitHub
9b2536b78f
Update misspell to 0.5.1 and add misspellings.csv ( #30573 )
...
Misspell 0.5.0 supports passing a csv file to extend the list of
misspellings, so I added some common ones from the codebase. There is at
least one typo in a API response so we need to decided whether to revert
that and then likely remove the dict entry.
2024-04-27 08:03:49 +00:00
silverwind and GitHub
dcc3c17e5c
Suppress browserslist warning in webpack target ( #30571 )
...
1. Set
[`BROWSERSLIST_IGNORE_OLD_DATA`](https://github.com/browserslist/browserslist/blob/c6ddf7b3870a4585822d06ec77e8dd2401b8e1ed/node.js#L400 )
to avoid warning on outdated browserslist data which the end user can
likely not do anything about and which is currently visible in the v1.21
branch.
2. Suppress all command echoing and add a "Running webpack..." message
in place.
Warning in question was this:
```
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
```
2024-04-27 07:21:07 +00:00
silverwind and GitHub
c93eefb42b
Diff color enhancements, add line number background ( #30670 )
...
1. Bring back the background on line numbers. This feature was lost a
long time ago.
<img width="457" alt="Screenshot 2024-04-24 at 01 36 09"
src="https://github.com/go-gitea/gitea/assets/115237/76a7f5a9-c22a-4c72-9f0a-ebf16a66513e ">
<img width="473" alt="Screenshot 2024-04-24 at 01 22 47"
src="https://github.com/go-gitea/gitea/assets/115237/eef06cf2-f1b9-40e3-947d-dd5852ec12a3 ">
<img width="457" alt="Screenshot 2024-04-24 at 02 13 18"
src="https://github.com/go-gitea/gitea/assets/115237/59e317d4-76a7-468c-8a19-10d88c675cc3 ">
<img width="459" alt="Screenshot 2024-04-24 at 01 23 21"
src="https://github.com/go-gitea/gitea/assets/115237/f1a46f8d-8846-4d78-a9d7-8b7dc18ac6e4 ">
2. Expanded lines background is now full-line, including line numbers:
<img width="1303" alt="Screenshot 2024-04-24 at 01 37 12"
src="https://github.com/go-gitea/gitea/assets/115237/271eefe2-0869-424e-93fb-ccd8adc87806 ">
3. Sort affected colors alphabetically in the CSS
Fixes #14603
2024-04-26 19:37:21 +00:00
d0bfc978de
Fix active item in tab menu ( #30690 )
...
Before, item would also resize on hover because of font weight:
<img width="381" alt="Screenshot 2024-04-25 at 01 28 53"
src="https://github.com/go-gitea/gitea/assets/115237/4f3291fc-90be-4d66-ae8b-3c2f763cb956 ">
After:
<img width="381" alt="Screenshot 2024-04-25 at 01 28 40"
src="https://github.com/go-gitea/gitea/assets/115237/06145bf2-1ddd-4171-9217-d92c100ea405 ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-25 12:53:39 +02:00
silverwind and GitHub
3f19a63345
Fix border-radius of header+segment boxes ( #30667 )
...
This is a very old bug with the bottom border-radiuses not being there
and the `:has` selector now makes it possible to cleanly solve it. It
affects all header+segment boxes, which there are many throughout the
UI:
<img width="1017" alt="Screenshot 2024-04-23 at 20 47 21"
src="https://github.com/go-gitea/gitea/assets/115237/870fe352-cc38-4bd6-bfe6-9fe8c3066f92 ">
2024-04-24 13:11:52 +00:00
silverwind and GitHub
1a2ae64b16
Fix checkbox field markup ( #30666 )
...
Fixes https://github.com/go-gitea/gitea/issues/30664 .
Previous use was not a supported way by fomantic and the misuse only
became visible after the checkbox migration.
2024-04-23 21:53:57 +00:00
silverwind and GitHub
370b1bdb37
Fix project name wrapping, remove horizontal margin on header ( #30631 )
...
Enable wrapping of unbroken lines:
<img width="1308" alt="Screenshot 2024-04-22 at 00 31 33"
src="https://github.com/go-gitea/gitea/assets/115237/1a28ade1-d708-4260-96a3-cf508b6dcb79 ">
Remove extra margin added by nested `.ui.container` on certain
viewports:
Before:
<img width="1305" alt="Screenshot 2024-04-22 at 00 40 23"
src="https://github.com/go-gitea/gitea/assets/115237/d3d8c0d1-380c-4867-b95c-4d53d70d4a93 ">
After:
<img width="1310" alt="Screenshot 2024-04-22 at 00 40 33"
src="https://github.com/go-gitea/gitea/assets/115237/2ba7b9f2-db2f-4bcc-8cce-5c415625ddea ">
2024-04-23 04:17:51 +00:00
silverwind and GitHub
99c5683da5
Enable jquery-related eslint rules that have no violations ( #30632 )
...
All these have no violations, so enable them.
2024-04-22 14:24:47 +00:00
silverwind and GitHub
74f0c84fa4
Enable more revive linter rules ( #30608 )
...
Noteable additions:
- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches
Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.
2024-04-22 11:48:42 +00:00
aff7b7bdd2
Remove obsolete CSS text classes ( #30576 )
...
- `.text-thin` and `.text-italic` are not present in CSS so were doing nothing and I removed them.
- `.text.middle` was unused so I removed it.
- `.text.italic` is replaced with `tw-italic`.
- `.text.normal` had exactly one use and it wasn't even needed.
- add a `muted` class to the link to `org_profile_avatar.tmpl`.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-22 11:21:06 +00:00
silverwind and GitHub
0386a42f70
Hide diff stats on empty PRs ( #30629 )
...
When a PR is empty, e.g. has neither additions nor deletions, we don't
need to show this:
<img width="125" alt="Screenshot 2024-04-21 at 23 25 38"
src="https://github.com/go-gitea/gitea/assets/115237/0b987eb5-66f5-4b9b-b5aa-7e9e267e9b52 ">
2024-04-22 10:48:14 +00:00
silverwind and GitHub
1b1b8500ae
Fix flash on dashboard ( #30572 )
...
Fixes https://github.com/go-gitea/gitea/issues/30566 , regression from
https://github.com/go-gitea/gitea/pull/30214 .
2024-04-21 20:24:56 +00:00
silverwind and GitHub
acfe29fc2b
Enable npm cache on setup-node action ( #30577 )
...
Enable npm dependency cache in
[setup-node](https://github.com/actions/setup-node ). This should work
reliably and across branches as well.
2024-04-19 03:29:08 +00:00
silverwind and GitHub
dd8e6ae270
Improve "Reference in new issue" modal ( #30547 )
...
Fixes: https://github.com/go-gitea/gitea/issues/29994
Also some misc enhancements done to the form in the modal.
<img width="840" alt="Screenshot 2024-04-17 at 23 02 55"
src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43 ">
2024-04-18 19:31:53 +00:00
silverwind and GitHub
354705450a
Add a few root files to lint-spell ( #30530 )
...
Files in root were not linted, add them. No new violations.
2024-04-18 18:54:40 +00:00
d4ec6b3d16
Add form field id generation, remove duplicated ids ( #30546 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 09:01:06 +00:00
31538133c3
Fix border-radius on view, blame and code search ( #30545 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30540
1. Fix all these boxes by adding `bottom attached` and removing a
problematic CSS rule:
<img width="1319" alt="Screenshot 2024-04-17 at 22 25 31"
src="https://github.com/go-gitea/gitea/assets/115237/346445a4-4944-4003-a1ef-6f5b0eda624e ">
<img width="643" alt="Screenshot 2024-04-17 at 22 21 18"
src="https://github.com/go-gitea/gitea/assets/115237/10f17ed3-9ad6-48de-92fa-bac6621815b9 ">
2. Change the "last commit" box to `ui segment` which has correct
border-radius. Also included is a tiny tweak to make author name ellipse
instead of wrap.
<img width="1331" alt="Screenshot 2024-04-17 at 22 23 23"
src="https://github.com/go-gitea/gitea/assets/115237/285fbd45-ced0-4d33-abe3-7384ffa03188 ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 08:34:23 +00:00
49b80f8ac1
Disable enter key for accepting code completion in Monaco ( #30548 )
...
Fixes https://github.com/go-gitea/gitea/issues/28114 and behaviour
matches vscode on desktop as well.
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 10:06:56 +02:00
silverwind and GitHub
8e12ef911a
Run go generate and go vet on all packages ( #30529 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30512
I think this does mean those tools would run on a potential `vendor`
directory, but I'm not sure we really support vendoring of dependencies
anymore.
`release` has a `vendor` prerequisite so likely the source tarballs
contain vendor files?
2024-04-17 09:40:35 +00:00
311f5261cd
Fix and tweak pull request commit list ( #30528 )
...
Fixes https://github.com/go-gitea/gitea/issues/30493 , regression from
https://github.com/go-gitea/gitea/pull/30374 .
Also did the flexbox convertion as suggested by the existing comment.
<img width="850" alt="Screenshot 2024-04-16 at 22 28 48"
src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 08:58:08 +00:00
4f276a3363
Fix install page checkboxes and dropdown width ( #30526 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30523
1. Fix checkbox rendering
2. Fix width of selection dropdowns (was too small)
---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 15:30:46 +08:00
silverwind and GitHub
5ccd042f70
Tweak and fix toggle checkboxes ( #30527 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30524 . Slightly restyled
them so that the "knob" is contained inside the background.
<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba ">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0 ">
2024-04-17 00:39:19 +02:00
3746a625f5
Tweak repo buttons on mobile and labeled button border-radius ( #30503 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30514
Fixes:
https://github.com/go-gitea/gitea/pull/30288#issuecomment-2057466623
- Fix border-radius regression from
https://github.com/go-gitea/gitea/pull/30475
- Fix and simplify hover state
- Move the modal HTML so it does not interfere with the CSS
- Make the star and unwatch text show on mobile. There is still plenty
of space, below is iPhone 12 viewport size
<img width="696" alt="Screenshot 2024-04-15 at 20 34 03"
src="https://github.com/go-gitea/gitea/assets/115237/af90bb00-4671-4973-a255-8eb44ee6ba8d ">
<img width="230" alt="Screenshot 2024-04-15 at 20 31 42"
src="https://github.com/go-gitea/gitea/assets/115237/986ef533-7a01-4bb0-8dcd-fd19e4259e84 ">
<img width="233" alt="Screenshot 2024-04-15 at 20 31 47"
src="https://github.com/go-gitea/gitea/assets/115237/5b825dd8-0ccc-4d56-9d8f-774abb935b68 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-16 17:46:12 +02:00
silverwind and GitHub
a658e2f277
Fix long branch name overflows ( #30345 )
...
Fixes: https://github.com/go-gitea/gitea/issues/27971
Fixes: https://github.com/go-gitea/gitea/pull/28010
<img width="689" alt="Screenshot 2024-04-09 at 00 19 57"
src="https://github.com/go-gitea/gitea/assets/115237/7c895a47-274f-40a6-a126-290658f1982d ">
Also fixes a similar issue in issue list where CSS was there but not
active because of missing `display: block`.
<img width="372" alt="Screenshot 2024-04-09 at 00 18 25"
src="https://github.com/go-gitea/gitea/assets/115237/cfbee7cd-2e15-4ac7-96ce-020816f48798 ">
2024-04-16 08:52:45 +00:00
silverwind and GitHub
b9f69b4a4d
Fix various overflows on actions view ( #30344 )
...
Fix a number of text overflow issues in actions view and run list. Also
improve mobile view of run list.
Fixes: https://github.com/go-gitea/gitea/issues/30328
<img width="782" alt="Screenshot 2024-04-08 at 23 10 16"
src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb ">
<img width="935" alt="Screenshot 2024-04-08 at 23 17 46"
src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12 ">
<img width="1008" alt="Screenshot 2024-04-08 at 23 49 05"
src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647 ">
<img width="397" alt="Screenshot 2024-04-08 at 23 55 30"
src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6 ">
2024-04-15 19:46:52 +00:00
silverwind and GitHub
3b40ebf895
Remove active border on pointing menu ( #30486 )
...
It looks better when these menus don't flash a border-bottom on click.
2024-04-15 18:22:53 +00:00
silverwind and GitHub
2dc7e9e5fe
Fix button color on red and green buttons ( #30500 )
...
Previously these colors were provided by fomantic css. I missed them.
Fixes: https://github.com/go-gitea/gitea/issues/30499
Regressed by: https://github.com/go-gitea/gitea/pull/30475
2024-04-15 17:20:32 +00:00
1508a85f62
Fix overflow on issue dependency ( #30484 )
...
Small tweak here to prevent this and likely other events from
overflowing in the timeline:
<img width="895" alt="Screenshot 2024-04-14 at 22 53 17"
src="https://github.com/go-gitea/gitea/assets/115237/001b4f6b-f649-44ff-b2f0-c8e0dedeb384 ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-15 10:49:48 +02:00
994920c677
Kill all gitea processes before air build ( #30477 )
...
So it happened to me multiple times that air leaves zombie processes
after termination. I think ultimately it's some kind of bug in air, but
we can work around.
The change in the delay is unrelated to the zombie processes but seems
to help a bit with duplicate changes resulting in duplicate `make
generate` as seen here:
<img width="424" alt="Screenshot 2024-04-14 at 17 05 47"
src="https://github.com/go-gitea/gitea/assets/115237/6dd1d787-6be3-4fb2-8b0b-cd711c281793 ">
---------
Co-authored-by: delvh <dev.lh@web.de >
2024-04-15 08:24:36 +00:00
ef3941f2eb
Revert 100% label max-width ( #30481 )
...
Partial revert of https://github.com/go-gitea/gitea/pull/30479
It's causing problems at least here:
https://github.com/go-gitea/gitea/pull/30344#discussion_r1564895591
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-15 01:04:02 +00:00
9946353282
Remove fomantic button module ( #30475 )
...
CSS-only module. Button colors are reduced to this:
<img width="639" alt="Screenshot 2024-04-14 at 15 36 07"
src="https://github.com/go-gitea/gitea/assets/115237/882d6c02-d1de-44f2-b707-db02a9f5070d ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-14 17:53:52 +00:00
f3267548ab
Remove fomantic menu module ( #30325 )
...
A lot of variants are in use, so the diff stat isn't so great.
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-14 11:43:46 +00:00
044cc169e7
Use flex-container for dashboard layout ( #30214 )
...
Added new class `flex-container-sidebar` to cover the dashboard sidebar.
Previously this was 37.5% with more padding. Now there is less empty
space between the two columns and this matches other pages like repo or
admin settings page.
Desktop:
<img width="1345" alt="Screenshot 2024-03-31 at 15 11 36"
src="https://github.com/go-gitea/gitea/assets/115237/717389d9-d42c-466e-a8fe-e968f79447fd ">
Mobile:
<img width="444" alt="Screenshot 2024-03-31 at 15 11 44"
src="https://github.com/go-gitea/gitea/assets/115237/7faa840b-513a-411b-bf2d-26d52b9b71a0 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-14 13:39:11 +02:00
4b1063f3db
Rewrite and restyle reaction selector and enable no-sizzle eslint rule ( #30453 )
...
Enable `no-sizzle` lint rule, there was only one use in `initCompReactionSelector` and:
- Remove all jQuery except the necessary fomantic dropdown init
- Remove the recursion, instead bind event listeners to common parent container nodes
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-14 18:44:11 +08:00
silverwind and GitHub
6999a88fd9
Pulse page improvements ( #30149 )
...
1. add border-radius and spacing to bars
2. use tailwind background classes
3. Add more space around activity list headers
<img width="983" alt="Screenshot 2024-03-27 at 23 40 54"
src="https://github.com/go-gitea/gitea/assets/115237/70f72c30-e69f-4ecb-882f-32b8bc94d638 ">
<img width="1020" alt="Screenshot 2024-03-27 at 23 41 02"
src="https://github.com/go-gitea/gitea/assets/115237/a35dbbda-515c-40b0-938a-d759f9686b8e ">
2024-04-14 09:21:16 +00:00
ce130ae8da
Fix JS error when opening to expanded code comment ( #30463 )
...
Fix regression from
https://github.com/go-gitea/gitea/commit/e0b018706fa7703ef1759d9a75a1399383715808
where opening to a code comment via hash link would give this error:
<img width="1247" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/f9aaeded-8492-4416-9a73-afa0c56220a7 ">
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-14 15:16:03 +08:00
silverwindandGitHub
