yp05327 and GitHub
0870e0bc9b
Implement some action notifier functions ( #29173 ) ( #29308 )
...
Backport #29173
Fix #29166
Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
2024-02-22 03:55:03 +00:00
yp05327 and GitHub
f80ea95eb5
Fix gitea-action user avatar broken on edited menu ( #29190 ) ( #29307 )
...
Backport #29190
Fix #29178
2024-02-22 02:53:38 +00:00
yp05327 and GitHub
96141e4e55
Revert move installation/upgrade-from-gogs.md in 1.21 ( #28235 )
...
https://github.com/go-gitea/gitea/pull/28233#discussion_r1405539630
2023-11-27 15:28:48 +01:00
yp05327 and GitHub
29d3949271
Avoid run change title process when the title is same ( #27467 ) ( #27558 )
...
Backport #27467 manually.
2023-10-10 09:01:46 +02:00
yp05327 and GitHub
076eca8158
Fix incorrect default branch label while switching between branches ( #27053 )
...
Fix #27008
2023-09-14 03:54:25 +00:00
yp05327 and GitHub
0850be6750
Fix the display of org level badges ( #26504 )
...
Follow #24654 #22705 #24232
In some pages we still have missing badges, for example:



2023-09-06 14:38:14 +08:00
yp05327 and GitHub
915cabdb14
Fix context filter has no effect in dashboard ( #26695 )
...
Fix #26686
2023-08-29 12:46:52 +00:00
yp05327 and GitHub
008f5d8cf1
Add default label in branch select list ( #26697 )
2023-08-29 12:15:19 +00:00
60ca3d04a4
Add fix incorrect can_create_org_repo for org owner team ( #26683 )
...
Related to: #8312 #26491
In migration v109, we only added a new column `CanCreateOrgRepo` in Team
table, but not initial the value of it.
This may cause bug like #26491 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-08-29 01:11:23 +00:00
d2e4039def
Add member, collaborator, contributor, and first-time contributor roles and tooltips ( #26658 )
...
GitHub like role descriptor



---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-08-24 13:06:17 +08:00
yp05327 and GitHub
7e30986667
Remove ref name in PR commits page ( #25876 )
...
The branch name display here is based on the repo's default branch which
is not correct.

For example, if I changed the default branch, the branch name here will
also be changed:


you can confirm this in :
https://try.gitea.io/yp05327/testrepo/pulls/1/commits
I think we do not need to display branch name here, as we already have
the branch info above.

2023-08-24 01:31:54 +00:00
yp05327 and GitHub
75689b8973
Improve repo sub menu ( #26531 )
...
Before:

After:

Icons are not in the middle of the line.
2023-08-22 09:20:09 +00:00
yp05327 and GitHub
c052f76266
Fix organization list in dashboard ( #26650 )
...
Fix ui problem comes from #26326
Before:

After:

2023-08-22 08:49:00 +00:00
yp05327 and GitHub
bd8a253220
Improve show role ( #26621 )
...
Add a general show role template.
2023-08-22 05:30:33 +00:00
a4a567f29f
Check disabled workflow when rerun jobs ( #26535 )
...
In GitHub, we can not rerun jobs if the workflow is disabled.
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-08-22 10:30:02 +08:00
yp05327 and GitHub
f6e7798405
Add link to job details and tooltip to commit status in repo list in dashboard ( #26326 )
...
Tooltip:

Link to the target job:

2023-08-21 15:26:10 +08:00
yp05327 and GitHub
9665622378
Differentiate better between user settings and admin settings ( #26538 )
...
User settings page and admin settings page are too similar. I thinlk
this will be better of using `User Settings` and `Admin Settings` as the
navbar's title.
Before:


After:


2023-08-16 10:12:03 +00:00
yp05327 and GitHub
82f6e3d845
Improve deadline icon location in milestone list page ( #26532 )
2023-08-16 16:22:25 +08:00
yp05327 and GitHub
bc930f332f
Fix typo of RunerOwnerID ( #26508 )
2023-08-15 23:10:40 +00:00
8703b6c954
Improve clickable area in repo action view page ( #26115 )
...
Before:

After:

In current design, the clickable area is too small, and it is hard to
find the correct clickable area as the area with background color (div
with class name `job-brief-item selected`) is bigger than it.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-16 00:44:43 +02:00
7f8028e5a1
Fix display problems of members and teams unit ( #26363 )
...
Fix:
- display member count and team count in the menu bar

- Also display member unit in the menu bar if there are no hidden
members in public org

- hidden member board when there's no seeable members.
In this org, we only have hidden members:

We will hidden the member board when doer is not the member of this org

Before:

If you click the number in the members board, you will access the
members page, which is not expected.

---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-15 16:00:35 +02:00
yp05327 and GitHub
9fc68b680f
Fix 404 error when remove self from an organization ( #26362 )
...
Same to #24322
Not only `leave` action but also `remove` action should check whether
user still belongs to the org.
2023-08-12 07:02:22 +00:00
yp05327 and GitHub
918d0f033d
Fix the display of orgs listed in user profile ( #26424 )
...
Before:

After:

In #26214 , we changed each row's display into `flex` which caused this
problem.


In old version:

Maybe we can add paddings here?

In old version;

2023-08-11 03:28:36 +08:00
e5011a0e6d
Remove commit load branches and tags in wiki repo ( #26304 )
...
If click `load branches and tags`, you will get 500 error from backend,
as it is a wiki repo.


Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-04 15:49:43 +00:00
945a0cb96b
Add highlight to selected repos in milestone dashboard ( #26300 )
...
Before:

After:

Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-04 15:16:56 +00:00
30eae5a40c
Fix incorrect color of selected assignees when create issue ( #26324 )
...
Before:

After:

Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-04 14:14:30 +00:00
yp05327 and GitHub
6832a8eb06
Add locale for deleted head branch ( #26296 )
...
As title.
It will be displayed in:

2023-08-03 22:07:15 +00:00
d74c2228e3
Remove nonsense <a> for commit status check icon ( #26287 )
...
We are using `<a>` for commit status check icon with no link. So it is
clickable but this is no sense.
I think we can convert this to `div`.

Co-authored-by: Giteabot <teabot@gitea.io >
2023-08-03 19:58:41 +02:00
yp05327 and GitHub
36732005b4
Disable download action logs button when there's no logs ( #26114 )
...
If there's no logs, you can also click the download button, then you
will get `job is not started` page

https://gitea.com/yp05327/testrepo/actions/runs/38
After:
If there's no steps displayed, the download button will be disabled.

2023-07-26 20:51:26 +02:00
yp05327 and GitHub
1c6c38fa6e
Improve display of Labels/Projects/Assignees sort options ( #25886 )
...
Labels:
Before: (no highlights)

After:


Projects:
Before: (no highlights)

After:


Assignee:
Before: (no highlights)

After:


2023-07-26 13:00:50 +00:00
yp05327 and GitHub
f9e5d980bc
Fix wrong branch name in rename branch modal ( #26146 )
...
Before:

After:

2023-07-26 11:26:17 +00:00
yp05327 and GitHub
74ca4377ff
Drop the correct deleted branch table ( #26028 )
...
There's a typo in #22743
The correct table name is `deleted_branch` not `deleted_branches`
2023-07-26 08:41:33 +08:00
7a687caca4
Fix wrong commit status in web ui ( #26121 )
...
Before:

After:

There's a bug in the recent logic, `CalcCommitStatus` will always return
the first item of `statuses` or error status, because `state` is defined
with default value which should be `CommitStatusSuccess`
Then
``` golang
if status.State.NoBetterThan(state) {
```
this `if` will always return false unless `status.State =
CommitStatusError` which makes no sense.
So `lastStatus` will always be `nil` or error status.
Then we will always return the first item of `statuses` here or only
return error status, and this is why in the first picture the commit
status is `Success` but not `Failure`.
https://github.com/go-gitea/gitea/blob/af1ffbcd63569df8646b20c524378f25710f129e/models/git/commit_status.go#L204-L211
Co-authored-by: Giteabot <teabot@gitea.io >
2023-07-25 12:46:02 +00:00
yp05327 and GitHub
d817b199ca
Fix wrong workflow status when rerun a job in an already finished workflow ( #26119 )
...
Before:

After:

After workflow finished, if you rerun a single job, the workflow status
will become to `Running` which is not correct as no jobs are running in
this workflow.
2023-07-25 09:13:36 +00:00
yp05327 and GitHub
d57e55cd47
Fix escape problems in the branch selector ( #25875 )
...
Fix #25865
2023-07-21 06:18:40 +00:00
yp05327 and GitHub
3add4ca216
Fix incorrect milestone count when provide a keyword ( #25880 )
...
You can confirm this issue in:
https://try.gitea.io/yp05327/testrepo/milestones?state=open&q=a
There's no milestone, but the count is 1.

2023-07-16 03:43:51 +00:00
yp05327 and GitHub
ec35af470c
Avoid opening/closing PRs which are already merged ( #25883 )
...
We can select PRs to open/close them by one click, but we forgot to
check whether it is merged.
You can get an opening merged PR:

You can confirm this in:
https://try.gitea.io/yp05327/testrepo/pulls/5
2023-07-15 22:10:49 +00:00
dc679fc9fa
Fix incorrect release count ( #25879 )
...
Release count is not correct:
https://try.gitea.io/yp05327/testrepo/tags

https://try.gitea.io/yp05327/testrepo/releases

https://try.gitea.io/yp05327/testrepo/releases/tag/testtag

We already have correct release count, no need to calculate it again.
https://github.com/go-gitea/gitea/blob/c5e187c389b35b9e080a3187b93a775a3c81e585/modules/context/repo.go#L547
Co-authored-by: Giteabot <teabot@gitea.io >
2023-07-14 08:47:17 +00:00
yp05327 and GitHub
1c8073b483
Add Github related extensions in devcontainer ( #25800 )
2023-07-14 15:58:02 +08:00
yp05327 and GitHub
52f46919dc
Add error info if no user can fork the repo ( #25820 )
...
Before: (Owner list is empty)

After: (Disable the button and show the error info)

2023-07-14 15:56:20 +08:00
yp05327 and GitHub
61c9268c56
Fix wrong usage of PathEscapeSegments in branch list page ( #25864 )
...
Before:

emmm, don't know how to write a good title to describe this issue.
If you have a good idea, I can change the title.
The fix code is copied from L122. Not sure it is right or not.
@lunny
Maybe `DefaultBranchBranch` is also typo?
Two `Branch` in variable name .
2023-07-14 06:08:38 +00:00
8b89563bf1
Fix empty project displayed in issue sidebar ( #25802 )
...
Before:

After:

This issue comes from the change in #25468 .
`LoadProject` will always return at least one record, so we use
`ProjectID` to check whether an issue is linked to a project in the old
code.
As other `issue.LoadXXX` functions, we need to check the return value
from `xorm.Session.Get`.
In recent unit tests, we only test `issueList.LoadAttributes()` but
don't test `issue.LoadAttributes()`. So I added a new test for
`issue.LoadAttributes()` in this PR.
---------
Co-authored-by: Denys Konovalov <privat@denyskon.de >
2023-07-12 16:10:35 +02:00
yp05327 and GitHub
44572e9243
Fix incorrect oldest sort in project list ( #25806 )
...
sort type `oldest` should be `Asc`.
Added a test for this.
2023-07-11 20:47:50 +02:00
yp05327 and GitHub
a95a7bcdf3
Add git-lfs support to devcontainer ( #25385 )
2023-06-20 19:28:46 +00:00
yp05327 and GitHub
0052395351
Use qwtel.sqlite-viewer instead of alexcvzz.vscode-sqlite ( #25386 )
...
`alexcvzz.vscode-sqlite` doesn't work well in devcontainer.
qwtel.sqlite-viewer works well, maybe we can use this one instead.
2023-06-20 19:06:42 +00:00
yp05327 and GitHub
3afc3e4a71
Add missing v in migrations.go ( #25252 )
2023-06-14 12:35:35 +00:00
22a39bb961
Fix profile render when the README.md size is larger than 1024 bytes ( #25131 )
...
Fixes https://github.com/go-gitea/gitea/issues/25094
`GetBlobContent` will only get the first 1024 bytes, if the README.md
size is larger than 1024 bytes,
We can not render the rest of them.
After this fix, we should provide the limited size to read when call
`GetBlobContent`.
After:

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-06-13 09:02:25 +00:00
81211db077
Fix #25133 ( #25162 )
...
Fix #25133
Thanks @wxiaoguang @silverwind.
I'm sorry I made a mistake, it will be fixed in this PR.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
Co-authored-by: silverwind <me@silverwind.io >
2023-06-09 10:27:10 +00:00
yp05327 and GitHub
b5a2bb9ab3
Fix strange UI behavior of cancelling dismiss review modal ( #25133 )
...
Fixes https://github.com/go-gitea/gitea/issues/25130
The old code uses `$(this).next()` to get `dismiss-review-modal`.
At first, it will get `$(#dismiss-review-modal)`, but the next time it
will get `$(#dismiss-review-modal).next();`
and then `$(#dismiss-review-modal).next().next();`.
Because div `dismiss-review-modal` will be removed when
`dismiss-review-btn` clicked.
Maybe the right usage is adding `show-modal` class and `data-modal`
attribute.
2023-06-08 08:52:35 +00:00
e4f9eb7e12
Fix incorrect git ignore rule and add missing license files ( #25135 )
...
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-06-08 09:36:53 +02:00
yp05327 and GitHub
fd1967c3a4
Fix can’t move anymore items in repo project boards ( #24892 )
...
Fix #24879
Related to #24589
In #24589 , I changed the css, but didn't reflect the changes in
repo-level projects template.
2023-05-24 14:05:50 +08:00
yp05327 and GitHub
5c0745c034
Add validations.required check to dropdown field ( #24849 )
...
If dropdown is marked as required, we should not provide the `remove`
button.
This will cause user may post empty value which seems like a bug.
Definition:

Post request form:

Result:

2023-05-22 21:26:48 +00:00
yp05327 and GitHub
922c83eea3
Remove In your repositories link in milestones dashboard ( #24853 )
...
It is unnecessary to it.
2023-05-22 11:42:57 +00:00
a3a8594f75
Fix 500 error when select No assignee filter in issue list page ( #24854 )
...
Access the issue list page and select `No assignee`, you will get 500
error:

You can see this page in try.gitea.io:
https://try.gitea.io/yp05327/testrepo/issues?q=&type=all&sort=&state=open&labels=&milestone=0&project=0&assignee=-1&poster=0
Caused by
https://github.com/go-gitea/gitea/pull/24707/files#diff-d7c7dc2da4fcfdc09997648e11a018414dc116472054350b5590ab407adcd44dR1748
Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-22 13:08:27 +02:00
yp05327 and GitHub
bebc3433c5
Add IsErrRepoFilesAlreadyExist check when fork repo ( #24678 )
...
Before:

After:

2023-05-22 18:21:46 +08:00
f4ef7eed00
Fix missing yes/no in delete time log modal ( #24851 )
...
Before:

After:

Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-22 09:46:50 +00:00
b5c26fa825
Add markdown preview to Submit Review Textarea ( #24672 )
...
Before:

After:

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-12 10:53:41 +00:00
49808136c5
Display owner of a runner as a tooltip instead of static text ( #24377 )
...
Before:

After:


---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-05-12 08:43:27 +00:00
yp05327 and GitHub
4aec1f87a4
Remove highlight in repo list ( #24675 )
...
Before:

After:

private or internal repos have `lock` icon, no need to add highlights to
them.
2023-05-12 10:00:17 +02:00
yp05327 and GitHub
bc719f549e
Update pin and add pin-slash ( #24669 )
...
Continue #23531
Thanks for the update in https://github.com/primer/octicons/issues/940 ,
@CameronFoxly


2023-05-12 14:38:59 +08:00
b3af7484bc
Fix missing badges in org settings page ( #24654 )
...
Improve #24232
Before:

After:

Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-11 06:56:25 +00:00
yp05327 and GitHub
2ee72d011f
Add permission check for moving issue action in project view page ( #24589 )
...
Fix #22954
Only users who have write permission can move issues in the project view page.
2023-05-09 00:50:16 -04:00
c4303efc23
Support markdown editor for issue template ( #24400 )
...
Fixes #24398
Task:
- [x] Reusing "textarea" like GitHub seems more friendly to users.
- [x] ^V image pasting and file uploading handling.
<details><summary>screenshots</summary>


Display only one markdown editor:

Support file upload and ^V image pasting

</details>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-05-08 22:22:52 +00:00
yp05327 and GitHub
f5b70a029c
Fix close org projects ( #24588 )
...
A part of #22865
We can not close org projects now. This PR will fix it.
2023-05-08 12:19:27 +00:00
dbb3736785
Fix incorrect webhook time and use relative-time to display it ( #24477 )
...
Fixes #24414
After click replay this webhook, it will display `now`

---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-03 19:53:43 -04:00
bcdd3c30af
Fix test delivery button in repo webhook settings page ( #24478 )
...
Caused by
https://github.com/go-gitea/gitea/pull/24246/files#diff-2bfe41d93dbb409583a4f945902e46bb513f60f1c9301649c1689200c4f1466eR1
Class `new` was removed in #24246 , but in function
`initCompWebHookEditor`, it will check `.new.webhook`.
So in repo webhook settings page, `initCompWebHookEditor` will init
nothing, and no response after click the test delivery button.
https://github.com/go-gitea/gitea/blob/da65b7ad47e8d0d82f47cb24ee9ac2a0ec50dc25/web_src/js/features/comp/WebHookEditor.js#L6-L9
Co-authored-by: Giteabot <teabot@gitea.io >
2023-05-02 21:58:18 +02:00
5987f00523
Add rerun workflow button and refactor to use SVG octicons ( #24350 )
...
Changes:
- Add rerun workflow button. Then users can rerun the whole workflow by
only one-click.
- Refactor to use SVG octicons in RepoActionView.vue



---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-05-01 22:14:20 +08:00
cc64a92560
Add follow organization and fix the logic of following page ( #24345 )
...


Maybe we can fix user card tmpl in #24319 ?
Or maybe a list is better here

---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io >
2023-04-29 15:13:58 -04:00
yp05327 and GitHub
5bc9f7fcf9
Improve commit date in commit graph ( #24399 )
...
The commit date time is based on server's time zone not user's local
time zone.
Before:

After:

2023-04-28 14:58:59 -04:00
yp05327 and GitHub
5141bbd9ba
Display 'Unknown' when runner.version is empty ( #24378 )
...
Before:

After:

2023-04-27 16:44:38 +08:00
yp05327 and GitHub
62ca5825f7
Fix incorrect last online time in runner_edit.tmpl ( #24376 )
...
Before:

After:

2023-04-27 15:56:49 +08:00
yp05327 and GitHub
df9a62b5f9
Fix 404 error when leaving the last private org team ( #24322 )
...
If the user only belongs to one org team and the org is private,
leaving the org team will redirect to `ctx.Org.OrgLink + "/teams/"`
which is inaccessible.
So we need to check whether the user still belongs to the org.
2023-04-26 12:27:46 -04:00
61d08f446a
Fix wrong error info in RepoRefForAPI ( #24344 )
...
Co-authored-by: Giteabot <teabot@gitea.io >
2023-04-26 04:14:35 -04:00
yp05327 and GitHub
62eafea3f9
Add missed column title in runner management page ( #24328 )
...

2023-04-26 03:46:25 -04:00
yp05327 and GitHub
5f21e0f8eb
Automatically select the org when click create repo from org dashboard ( #24325 )
...

In org dashboard, the create repo link will be `repo/create?org={orgId}`
2023-04-25 22:25:29 -04:00
8cc60ee01a
Remove org users who belong to no teams ( #24247 )
...
Fix #24128
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-04-24 15:52:38 -04:00
yp05327 and GitHub
9c33cbd344
Fix no edit/close/delete button in org repo project view page ( #24301 )
...
Part of #23318 .
2023-04-24 04:51:44 -04:00
20b6ae0e53
Add project type descriptions in issue badge and improve project icons ( #23437 )
...
Changes:
- ~~Add project icons to issue badge~~
~~After:~~

Use `tooltip` to add a description of project type to the project name.

- improve project icons
we can use `project.icon` to get the svg name, which looks better and is
easy to change all of them in templates.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-04-21 17:15:17 -04:00
8ea33baa1c
Introduce eslint-plugin-no-jquery/no-event-shorthand ( #24198 )
...
https://github.com/go-gitea/gitea/pull/24098#issuecomment-1514010690
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-04-20 05:28:27 -04:00
da6e9f63df
Add owner team permission check test ( #24096 )
...
Add test for https://github.com/go-gitea/gitea/pull/23675
Should be merged after #24117
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-04-19 19:19:13 -04:00
yp05327 and GitHub
f30cc9faa9
Add unset default project column ( #23531 )
...
Close: https://github.com/go-gitea/gitea/issues/23401
2023-04-19 10:28:28 -04:00
yp05327 and GitHub
01214c8ada
Add runner check in repo action page ( #24124 )
...

Maybe we can also add online runner check? e.g. : Target runner is
offline.
2023-04-19 20:51:20 +08:00
yp05327 and GitHub
fa3495183b
Add migration to fix external unit access mode of owner/admin team ( #24117 )
...
Fix the incorrect migration in #23675 and #24012
External Unit (Tracker and Wiki) access mode should be `read` in
owner/admin team.
2023-04-15 09:52:44 -04:00
yp05327 and GitHub
5768bafeb2
Fix incorrect server error content in RunnersList ( #24118 )
2023-04-14 11:34:10 +08:00
yp05327 and GitHub
b7221bec34
Fix admin team access mode value in team_unit table ( #24012 )
...
Same as https://github.com/go-gitea/gitea/pull/23675
Feedback:
https://github.com/go-gitea/gitea/pull/23879#issuecomment-1500923636
2023-04-13 21:06:10 +02:00
yp05327 and GitHub
bb6c670cff
Add actions support to package auth verification ( #23729 )
...
Partly fixes https://github.com/go-gitea/gitea/issues/23642
Error info:

ActionsUser (userID -2) is used to login in to docker in action jobs.
Due to we have no permission policy settings of ActionsUser now,
ActionsUser can only access public registry by this quick fix.
2023-04-10 15:21:03 +08:00
yp05327 and GitHub
8bc8ca1953
Improve GetBoards and getDefaultBoard ( #22981 )
...
Change
`GetBoards(ctx context.Context, projectID int64)`
to
`(p *Project) GetBoards(ctx context.Context) (BoardList, error)`
`getDefaultBoard` is same.
2023-04-09 22:07:23 +08:00
yp05327 and GitHub
68aac691c1
Add job.duration in web ui ( #23963 )
...


Maybe we can change the location of it.
2023-04-07 18:20:50 -04:00
yp05327 and GitHub
26a0cd7143
Allow repo admins too to delete the repo ( #23940 )
...
Fixes https://github.com/go-gitea/gitea/issues/23934
We need to check `AccessModeAdmin` in `CanUserDelete` instead of
`AccessModeOwner`
2023-04-07 11:21:02 -04:00
bbf83f5d4b
Improve permission check of packages ( #23879 )
...
At first, we have one unified team unit permission which is called
`Team.Authorize` in DB.
But since https://github.com/go-gitea/gitea/pull/17811 , we allowed
different units to have different permission.
The old code is only designed for the old version. So after #17811 , if
org users have write permission of other units, but have no permission
of packages, they can also get write permission of packages.
Co-authored-by: delvh <dev.lh@web.de >
2023-04-06 22:18:29 +08:00
yp05327 and GitHub
01d9466bfd
Convert .Source.SkipVerify to $cfg.SkipVerify ( #23839 )
...
`Source` doesn't have `SkipVerify`, it is defined in `cfg`
2023-04-03 12:06:16 -04:00
yp05327 and GitHub
6eb856c614
Fix owner team access mode value in team_unit table ( #23675 )
...
All `access_mode` value of Owner Teams are 0(AccessModeNone) in
`team_unit` table, which should be 4(AccessModeOwner)
In `team` table:

In `team_unit` table:

ps: In https://github.com/go-gitea/gitea/pull/23630 , `access_mode` in
`team_unit` is used to check the team unit permission, but I found that
user can not see issues in owned org repos.
2023-04-03 10:36:35 -04:00
yp05327 and GitHub
29133f3d04
Fix submit button won't refresh in New Repository Fork page ( #22994 )
...
Fork a repo, and input an invalid repo name, you will get an error.
Then rename the repo name to a valid one, the submit button is still
disabled.
In other pages, for example, in create repo page, the submit button will
not be disabled.
So I removed the codes to disable the submit button.
2023-04-03 22:11:05 +08:00
yp05327 and GitHub
0ed62db213
Prefill input values in oauth settings as intended ( #23829 )
2023-04-02 21:08:34 +08:00
yp05327 and GitHub
6e58f8400e
Fix 500 error if there is a name conflict when edit authentication source ( #23832 )
2023-03-31 22:32:18 +08:00
yp05327 and GitHub
06d9d9e407
Fix incorrect/Improve error handle in edit user page ( #23805 )
...
Changes:
- `RenderWithErr` should render `tplUserEdit` not `tplUserNew` in edit
page
- If error occurred in `HandleUsernameChange` redirect to original edit
page instead of user list page
2023-03-30 13:27:00 -04:00
yp05327 and GitHub
c09eab5485
Fix incorrect visibility dropdown list in add/edit user page ( #23804 )
...
Visibility dropdown list will not work in add/edit user page when error
occurred
2023-03-30 12:29:57 -04:00
yp05327 and GitHub
22fec1650a
Add commit info in action page ( #23210 )
...
Add more commit info in action detail page.

2023-03-27 18:34:09 +08:00
yp05327 and GitHub
d673a6f832
Fix incorrect package doc link ( #23679 )
...
package doc link is changed in
https://github.com/go-gitea/gitea/pull/23629
2023-03-24 23:45:06 +08:00
1a4efa0ee9
Use project.IconName instead of repeated unreadable if-else chains ( #23538 )
...
The project type will be changed in
https://github.com/go-gitea/gitea/pull/23353 , so the old fix
https://github.com/go-gitea/gitea/pull/23325 will not work as well.
And I also found that there were some problems in the old fix....
---------
Co-authored-by: Lauris BH <lauris@nix.lv >
2023-03-19 14:44:48 +02:00