gitea

13,564 Commits 19 Branches 243 Tags

3 Commits

Author	SHA1	Message	Date
JonRBandGitHub	eee51d8366	Ensure that graceful start-up is informed of unused SSH listener (#20877 ) The graceful manager waits for 4 listeners to be created or to be told that they are not needed. If it is not told about them it will indefinitely and timeout. This leads to SVC hosts not being told of being in the readyState but on Unix would lead to the termination of the process. There was an unfortunate regression in #20299 which missed this subtly and in the case whereby SSH is disabled the `builtinUnused()` is not called. This PR adds a call to `builtinUnused()` when not using the builtin ssh to allow `createServerWaitGroup.Done()` to be called. In addition it was noted that the if/else clauses for timeout informing of the SVC host were in the wrong order. These have been swapped. Fix #20609	2022-08-21 20:18:22 +08:00
JonRB GitHub Lunny Xiao	aa60cd91b2	Update nginx reverse proxy docs (#18922 ) Add additional config lines for the set_header to forward additional information (eg the IP) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>	2022-02-26 19:32:09 +01:00
JonRB GitHub zeripath	483409716d	Place inline diff comment dialogs in the 4th column. (#18321 ) Comment dialogs for inline comments should appear in 4th column (not 3rd column), this PR changes the column that the inline review comment is associated with. This problem has occurred due to an unrecognised conflict between #17562 and #17315. Fix as zeripath suggested in #18320 Fix #18320 Co-authored-by: zeripath <art27@cantab.net>	2022-01-18 10:28:45 +00:00

Author

SHA1

Message

Date

JonRBandGitHub

eee51d8366

Ensure that graceful start-up is informed of unused SSH listener (#20877 )

The graceful manager waits for 4 listeners to be created or to be told that they are not needed. If it is not told about them it will indefinitely and timeout. 

This leads to SVC hosts not being told of being in the readyState but on Unix would lead to the termination of the process.

There was an unfortunate regression in #20299 which missed this subtly and in the case whereby SSH is disabled the `builtinUnused()` is not called.

This PR adds a call to `builtinUnused()` when not using the builtin ssh to allow `createServerWaitGroup.Done()` to be called. 

In addition it was noted that the if/else clauses for timeout informing of the SVC host were in the wrong order. These have been swapped.

Fix #20609

2022-08-21 20:18:22 +08:00

aa60cd91b2

Update nginx reverse proxy docs (#18922 )

Add additional config lines for the set_header to forward additional information (eg the IP)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

2022-02-26 19:32:09 +01:00

483409716d

Place inline diff comment dialogs in the 4th column. (#18321 )

Comment dialogs for inline comments should appear in 4th column (not 3rd column), this PR changes the column that the inline review comment is associated with.

This problem has occurred due to an unrecognised conflict between #17562 and #17315. 

Fix as zeripath suggested in #18320

Fix #18320 

Co-authored-by: zeripath <art27@cantab.net>

2022-01-18 10:28:45 +00:00