Giteabot and Yarden Shoham
912a418920
Fix broken clone script on an empty archived repo ( #24339 ) ( #24348 )
...
Backport #24339 by @yardenshoham
I made it render the script even if the repo is archived
- Fixes #24324
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: Yarden Shoham <git@yardenshoham.com >
2023-04-26 10:13:16 +02:00
Giteabot and silverwind
cc7a4f17e0
Don't set meta theme-color by default ( #24340 ) ( #24346 )
...
Backport #24340 by @silverwind
Fixes https://github.com/go-gitea/gitea/issues/24321 . By not setting
this meta tag, Safari will use body color for chrome and out-of-viewport
areas, which looks much better then static mismatching green.
As per
[MDN](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name/theme-color )
it's really only Apple browsers who still support this tag, most others
have dropped support.
Before:
<img width="347" alt="Screenshot 2023-04-25 at 19 59 13"
src="https://user-images.githubusercontent.com/115237/234363180-0fe667ef-5469-4f5f-b31a-c9d73aff10ac.png ">
After:
<img width="361" alt="Screenshot 2023-04-25 at 20 00 00"
src="https://user-images.githubusercontent.com/115237/234363185-e2d2b62f-0133-4316-944d-b614ffb84eb0.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-26 01:33:15 -04:00
Giteabot and Gary Moon
1bbbeb24ef
Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC ( #24035 ) ( #24333 )
...
Backport #24035 by @garymoon
This change prevents Gitea from bypassing the manual approval process
for newly registered users when OIDC is used.
- Resolves https://github.com/go-gitea/gitea/issues/23392
Signed-off-by: Gary Moon <gary@garymoon.net >
Co-authored-by: Gary Moon <garymoon@users.noreply.github.com >
2023-04-25 15:25:08 -04:00
Giteabot and JakobDev
1254a8271e
Wrap too long push mirror addresses ( #21120 ) ( #24334 )
...
Backport #21120 by @JakobDev
I noticed that it is possible to break the push mirror list by entering
a too long URL. This should fix it.
| Before | After |
|--------------|-----------|
|||
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-04-25 12:47:26 -04:00
ef3e3afc05
Fix typo in API route ( #24310 ) ( #24332 )
...
Backport #24310 by @silverwind
Continuation of https://github.com/go-gitea/gitea/pull/23995
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: bilogic <946010+bilogic@users.noreply.github.com >
2023-04-25 10:57:33 -04:00
b1094ff28c
Remove org users who belong to no teams ( #24247 ) ( #24313 )
...
Backport #24247 by @yp05327
Fix #24128
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-04-24 22:50:32 -04:00
Giteabot and techknowlogick
8044d87c18
Unify nightly naming across binaries and docker images ( #24116 ) ( #24308 )
...
Backport #24116 by @techknowlogick
Proposal found here: https://github.com/go-gitea/gitea/issues/23654
TODO: make non-breaking (can we publish docker image using dev and
nightly prefix? at same time). if anyone has advice please comment :)
If this PR is merged, then I can add redirects to the downloads site.
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-04-24 12:23:01 -04:00
Giteabot and Zettat123
1b8e36587e
Upgrade act ( #24298 ) ( #24300 )
...
Backport #24298 by @Zettat123
Upgrade act to version `v0.243.4`
- Support `configuration variables`
([#43 ](https://gitea.com/gitea/act/pulls/43 ))
- Support specifying command for `services` containers
([#50 ](https://gitea.com/gitea/act/pulls/50 ))
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-04-24 10:18:47 +02:00
a2f52f3561
Fix bug when deleting wiki with no code write permission ( #24274 ) ( #24295 )
...
Backport #24274 by @lunny
Fix #24125
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2023-04-23 20:20:45 -04:00
Giteabot and Jason Song
65de747b13
Handle canceled workflow as a warning instead of a fail ( #24282 ) ( #24292 )
...
Backport #24282 by @wolfogre
Follow what Drone CI does:
Co-authored-by: Jason Song <i@wolfogre.com >
2023-04-23 15:44:45 -04:00
Giteabot
7e86dffc35
Load reviewer for comments when dismissing a review ( #24281 ) ( #24288 )
2023-04-23 12:44:57 -04:00
Giteabot and KN4CK3R
7297cceda7
Only delete secrets belonging to its owner ( #24284 ) ( #24286 )
...
Backport #24284 by @KN4CK3R
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-04-23 16:36:20 +02:00
Giteabot and harryzcy
b00f7c3c54
Fix access token issue on some public endpoints ( #24194 ) ( #24259 )
...
Backport #24194 by @harryzcy
- [x] Identify endpoints that should be public
- [x] Update integration tests
Fix #24159
Co-authored-by: harryzcy <harry@harryzheng.com >
2023-04-21 14:59:17 -04:00
Giteabot and wxiaoguang
51fd730147
Show commit history for closed/merged PRs ( #24238 ) ( #24261 )
...
Backport #24238 by @wxiaoguang
Close #24237
Before:
<details>
</details>
After:
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-21 14:15:00 -04:00
Giteabot and silverwind
7117355169
Fix label color, fix divider in dropdown ( #24215 ) ( #24244 )
...
Backport #24215 by @silverwind
Two small CSS fixes:
1. Fix basic primary label hover:
Before:
<img width="172" alt="Screenshot 2023-04-19 at 20 00 32"
src="https://user-images.githubusercontent.com/115237/233161903-eec2de54-1a58-44ac-a6ef-2d77157317f6.png ">
After:
<img width="179" alt="Screenshot 2023-04-19 at 20 05 29"
src="https://user-images.githubusercontent.com/115237/233162028-995404ac-5852-4d03-821f-6eb4a918a9e3.png ">
2. Fix border color of divider in dropdown and remove margin so it looks
better with hover effect, as discussed in
https://github.com/go-gitea/gitea/pull/24143 :
<img width="205" alt="Screenshot 2023-04-19 at 20 03 24"
src="https://user-images.githubusercontent.com/115237/233162102-3f4a4142-9634-4c95-acf0-be57072ce7eb.png ">
<img width="311" alt="Screenshot 2023-04-19 at 20 03 55"
src="https://user-images.githubusercontent.com/115237/233162109-faa616f6-02e4-43d3-95fa-66787a7f914c.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-20 22:28:55 -05:00
Giteabot and Krzysztof Jeziorny
7d717e22a8
Vertical widths of containers removed ( #24184 ) ( #24211 )
...
Backport #24184 by @krzysztofjeziorny
A vertical overflow appears in Firefox 112/MacOS 12.6 when the system
setting for scrollbars is to "Always" show them.
Here, the fixed 100vw container widths are removed, which removes the
overflow. It is, however, only simulated in Developer Tools in latest
Firefox and Chromium, so please test on a Gitea installation.
Co-authored-by: Krzysztof Jeziorny <872730+krzysztofjeziorny@users.noreply.github.com >
2023-04-20 09:02:38 +08:00
Giteabot and Lunny Xiao
dc66ceadac
Don't list root repository on compare page if pulls not allowed ( #24183 ) ( #24210 )
...
Backport #24183 by @lunny
Fix #24165
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-19 19:07:47 -04:00
Giteabot and Brecht Van Lommel
8cd5483e8a
Fix template error in pull request with deleted head repo ( #24192 ) ( #24216 )
...
Backport #24192 by @brechtvl
Rendering of Allow Edits from Maintainers did not check if the head repo
exists, while other parts of the page handle it gracefully.
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2023-04-19 17:20:19 -04:00
Giteabot and wxiaoguang
2e6e5bc9c9
Fix incorrect CORS default values ( #24206 ) ( #24217 )
...
Backport #24206 by @wxiaoguang
Document:
```
;ALLOW_DOMAIN = *
;METHODS = GET,HEAD,POST,PUT,PATCH,DELETE,OPTIONS
```
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-19 16:23:25 -04:00
Giteabot and John Olheiser
f134229bf2
Use correct locale key for forks page ( #24172 ) ( #24175 )
...
Backport #24172 by @jolheiser
https://github.com/go-gitea/gitea/blob/4014200021a1997283c779a815fe9e5febf1fda1/options/locale/locale_en-US.ini#L873
https://github.com/go-gitea/gitea/blob/4014200021a1997283c779a815fe9e5febf1fda1/options/locale/locale_en-US.ini#L943
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-04-17 17:21:53 -04:00
Giteabot and wxiaoguang
3d3c740636
Fix Org edit page bugs: renaming detection, maxlength ( #24161 ) ( #24171 )
...
Backport #24161 by @wxiaoguang
## Before
* The renaming detection is wrong (eg: pasting a new name into the input
doesn't trigger the detection)
* The renaming prompt layout is not good
* Some MaxSize/maxlength rules is missing
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-17 12:20:47 -04:00
Giteabot and Lunny Xiao
c4f569b9a5
Support converting varchar to nvarchar for mssql database ( #24105 ) ( #24168 )
...
Backport #24105 by @lunny
In #12269 , all string fields of struct will generate a NVARCHAR column
in database, but for those Gitea instances installed before that PR,
users have to convert columns themselves.
In this PR, we update the `./gitea admin convert` commands to support
both MySQL and MSSQL database converting. Previously, it only supported
converting `utf8 -> utf8mb4` for MySQL.
Now, it will check the database types.
If it's MSSQL, it will convert `VARCHAR -> NVARCHAR` as well.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-17 10:10:15 -04:00
Giteabot and Jonathan Tran
494e373292
Fix 2-dot direct compare to use the right base commit ( #24133 ) ( #24150 )
...
Backport #24133 by @jtran
For 2-dot direct compare, we should use the base commit in the title and
templates, as is used elsewhere, not the common ancestor which is used
for 3-dot compare. I believe that this change should have been included
in #22949 .
Co-authored-by: Jonathan Tran <jonnytran@gmail.com >
2023-04-16 13:17:13 +02:00
Giteabot and yp05327
67a73dd05f
Fix incorrect server error content in RunnersList ( #24118 ) ( #24121 )
...
Backport #24118 by @yp05327
Co-authored-by: yp05327 <576951401@qq.com >
2023-04-14 12:52:21 +08:00
Giteabot and wxiaoguang
93c7611c32
Improve LFS error logs ( #24072 ) ( #24082 )
...
Backport #24072 by @wxiaoguang
The error logs were not clear.
Help (but not fix) #24053
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-12 16:23:57 -04:00
Giteabot and sillyguodong
607801ec41
Update the value of the diffEnd when click Show More btn in the DiffFileTree ( #24069 ) ( #24078 )
...
Backport #24069 by @sillyguodong
In the component `DiffFileTree`,if don't update the value of the
`diffEnd` in the callback of ajax request, click `Show More` btn will
always return the same response, duplicate files are appended to the
file list.
Before:
https://user-images.githubusercontent.com/33891828/231371188-82d169af-10bb-47e2-8aca-83ced2597f2d.mov
After:
https://user-images.githubusercontent.com/33891828/231369805-39a5a4d0-662c-4f08-bc5a-7d31e8782453.mov
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-04-12 15:27:53 -04:00
Giteabot and sillyguodong
37d3e0ec33
Fix accidental overwriting of LDAP team memberships ( #24050 ) ( #24065 )
...
Backport #24050 by @sillyguodong
In the `for` loop, the value of `membershipsToAdd[org]` and
`membershipsToRemove[org]` is a slice that should be appended instead of
overwritten.
Due to the current overwrite, the LDAP group sync only matches the last
group at the moment.
## Example reproduction
- an LDAP user is both a member of
`cn=admin_staff,ou=people,dc=planetexpress,dc=com` and
`cn=ship_crew,ou=people,dc=planetexpress,dc=com`.
- configuration of `Map LDAP groups to Organization teams ` in
`Authentication Sources`:
```json
{
"cn=admin_staff,ou=people,dc=planetexpress,dc=com":{
"test_organization":[
"admin_staff",
"test_add"
]
},
"cn=ship_crew,ou=people,dc=planetexpress,dc=com":{
"test_organization":[
"ship_crew"
]
}
```
- start `Synchronize external user data` task in the `Dashboard`.
- the user was only added for the team `test_organization.ship_crew`
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-04-12 07:22:02 -04:00
Giteabot and Lunny Xiao
580da8f353
Fix branch protection priority ( #24045 ) ( #24061 )
...
Backport #24045 by @lunny
Fix #24044
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-11 21:07:38 +02:00
8644993699
Update documentation to explain which projects allow Gitea to host static pages ( #23993 ) ( #24058 )
...
Backport #23993 by @6543
close #23521
Signed-off-by: 6543 <6543@obermui.de >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: a1012112796 <1012112796@qq.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-11 18:43:35 +02:00
Giteabot and yp05327
27dbe97542
Add actions support to package auth verification ( #23729 ) ( #24028 )
...
Backport #23729 by @yp05327
Partly fixes https://github.com/go-gitea/gitea/issues/23642
Error info:
ActionsUser (userID -2) is used to login in to docker in action jobs.
Due to we have no permission policy settings of ActionsUser now,
ActionsUser can only access public registry by this quick fix.
Co-authored-by: yp05327 <576951401@qq.com >
2023-04-10 10:36:21 +02:00
Giteabot and Lunny Xiao
abf0386e2e
Fix protected branch for API ( #24013 ) ( #24027 )
...
Backport #24013 by @lunny
Fix #23998
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-10 14:48:02 +08:00
Giteabot and silverwind
2b10eebed8
Show errors for KaTeX and mermaid on the preview tab ( #24009 ) ( #24019 )
...
Backport #24009 by @silverwind
There is a conflicting fomantic rule that hid the error messages inside
the markdown preview tab for things like mermaid or katex. Overruled it
to always show these errors.
<img width="774" alt="image"
src="https://user-images.githubusercontent.com/115237/230738528-322814c1-8994-495e-b901-bbb79b924ccb.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-09 08:48:28 -04:00
695738fb31
Show protected branch rule names again ( #23907 ) ( #24018 )
...
Backport #23907 by @HesterG
`!important`s for one of the primary label selectors are removed by
#23774 , so the repository branch protection settings ui will not have
the demanding css. This PR modifies `.ui.primary.label` to fix it.
Before:
<img width="1408" alt="飞书20230404-115410"
src="https://user-images.githubusercontent.com/17645053/229683221-ef9c7d5c-68a8-42b0-ba19-ef2d5dfce5f9.png ">
After:
<img width="1419" alt="截屏2023-04-04 11 56 32"
src="https://user-images.githubusercontent.com/17645053/229683469-70cfc92d-d7ef-4323-a7f5-2247810fabce.png ">
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-09 14:06:16 +02:00
Giteabot and Daniel Gunzinger
cfde557e23
fix: do not escape space between PyPI repository url and package name… ( #23981 ) ( #24008 )
...
Backport #23981 by @Gunzinger
…; add trailing slash to PyPI repository URL (in accordance to PEP-503)
This should solve Issue #23980 , by moving the space in front of the
package name and the package name out of the `gitea-origin-url` block.
It also adds a trailing slash to the PyPI repository URL in accordance
to [Python PEP-503](https://peps.python.org/pep-0503/ ).
Co-authored-by: Daniel Gunzinger <daniel.gunzinger@gmail.com >
2023-04-08 23:13:43 +02:00
3dbc63777f
Adjust sticky pr header to cover background ( #23956 ) ( #23999 )
...
Backport #23956 by @silverwind
Very minor CSS tweak: Adjust sticky PR header to cover the box-shadow of
selected files.
Before:
<img width="1250" alt="Screenshot 2023-04-06 at 22 54 59"
src="https://user-images.githubusercontent.com/115237/230492218-4d71da48-a362-4c52-a7f7-01daf4ffa458.png ">
After:
<img width="1255" alt="Screenshot 2023-04-06 at 22 54 46"
src="https://user-images.githubusercontent.com/115237/230492227-c7142210-e535-4da8-b610-37d33dcbb549.png ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-08 18:36:11 +02:00
Giteabot and sillyguodong
4aabd8e823
Set ref to fully-formed of the tag when trigger event is release ( #23944 ) ( #23989 )
...
Backport #23944 by @sillyguodong
Fix #23943
When trigger event is `release`, ref should be like
`refs/tags/<tag_name>` instead of `CommitID`
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-04-08 20:43:46 +08:00
Giteabot and Lunny Xiao
6a5b8eb7b6
Fix redirect bug when creating issue from a project ( #23971 ) ( #23997 )
...
Backport #23971 by @lunny
Fix #23966
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-08 12:38:56 +02:00
Giteabot and ChristopherHX
a00e473341
Remove Repository.getFilesChanged to fix Actions paths and paths-ignore filter ( #23920 ) ( #23969 )
...
Backport #23920 by @ChristopherHX
Remove the misbehaving function and call
Repository.GetFilesChangedBetween instead.
Fixes #23919
---
~~_TODO_ test this~~ `Repository.getFilesChanged` seems to be only used
by Gitea Actions, but a similar function already exists
**Update** I tested this change and the issue is gone.
Co-authored-by: ChristopherHX <christopher.homberger@web.de >
2023-04-08 16:16:21 +08:00
Giteabot and silverwind
4019a6d4b2
Discolor pull request tab labels ( #23950 ) ( #23987 )
...
Backport #23950 by @silverwind
https://github.com/go-gitea/gitea/pull/22687 has discolored the repo tab
labels. This does the same for PR tabs for consistency. Value `0` is
still rendered like before.
Before:
<img width="502" alt="Screenshot 2023-04-06 at 19 35 24"
src="https://user-images.githubusercontent.com/115237/230454329-db6244ff-7d7e-4a2f-9240-f618a1c57f8c.png ">
After:
<img width="497" alt="Screenshot 2023-04-06 at 19 35 07"
src="https://user-images.githubusercontent.com/115237/230454321-a0be6551-8c31-45e4-a1fb-ffc0d85d87bf.png ">
<img width="497" alt="Screenshot 2023-04-06 at 19 38 37"
src="https://user-images.githubusercontent.com/115237/230454570-2fe2aa67-dfa7-4b2e-8c04-8dd40e6e99fc.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-07 22:32:42 -04:00
Giteabot and wxiaoguang
3a7cb1a83b
Use Get/Set instead of Rename when Regenerate session id ( #23975 ) ( #23983 )
...
Backport #23975 by @wxiaoguang
Do not use Rename here, because the old sid and new sid may be in
different redis cluster slot.
Fix #23869
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-07 14:21:20 -05:00
Giteabot and Jason Song
f317186aa6
Do not crash when parsing an invalid workflow file ( #23972 ) ( #23976 )
...
Backport #23972 by @wolfogre
Fix #23658 .
Related to https://gitea.com/gitea/act/pulls/39
Co-authored-by: Jason Song <i@wolfogre.com >
2023-04-07 09:55:59 -04:00
Giteabot and silverwind
5b7df68555
Ensure RSS icon is present on all repo tabs ( #23904 ) ( #23973 )
...
Backport #23904 by @silverwind
Previously, not all repo tabs had shown the RSS icon in the repo header
because the context data was not being set. Added this context data in a
new function.
Before:
<img width="806" alt="image"
src="https://user-images.githubusercontent.com/115237/229639615-9cc00e75-3a26-4ff4-a6f2-316c1fccc596.png ">
After:
<img width="815" alt="Screenshot 2023-04-04 at 00 16 17"
src="https://user-images.githubusercontent.com/115237/229639201-2e1c015b-1f13-46d4-aa14-e7a82fab3982.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-07 14:55:30 +02:00
Giteabot and techknowlogick
833a4b1775
Hardcode path to docker images ( #23955 ) ( #23968 )
...
Backport #23955 by @techknowlogick
Fix #23954
This allows for building on platforms that don't have docker hub as the
default container registry.
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-04-07 14:54:28 +02:00
Giteabot and Zettat123
1b8ecd179b
Title can be empty when creating tag only ( #23917 ) ( #23961 )
...
Backport #23917 by @Zettat123
Fixes #23809
Make the title not required. If the title is empty when creating release
(not tag), an error message will be displayed.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-04-07 20:13:57 +08:00
Giteabot and Lunny Xiao
001d3fb820
Delete deleted release attachments immediately from storage ( #23913 ) ( #23958 )
...
Backport #23913 by @lunny
Previously, deleted release attachments were kept forever on the
external storage.
Note: It may be very slow now if there are many attachments to be
deleted on this release.
Fix #23728
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-04-06 18:38:34 -04:00
Giteabot and wxiaoguang
55239cbab7
Fix image border-radius ( #23886 ) ( #23930 )
...
Backport #23886 by @wxiaoguang
1. Instead of polluting the `border-radius` style globally, each "img"
usage should declare their own styles.
2. There were some bugs in code, I believe the `.img` selector was done
by mistake.
After:
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-05 17:07:44 +02:00
Giteabot and Jimmy Praet
df74ee0376
Scroll collapsed file into view ( #23702 ) ( #23929 )
...
Backport #23702 by @jpraet
Fixes #23701 , #23515 .
Alternate approach to #23604 using CSS scroll-margin-top, which is also
taken into account for direct links to files in a diff:
* On the PR diff, this currently shows the previous file first:
https://try.gitea.io/jpraet/test/pulls/13/files#diff-b94d08b409f9d05fb65b6cccaf7b3e4ecc7cc333
* On the commit diff, the first line of the linked file is currently
under the sticky header:
https://try.gitea.io/jpraet/test/commit/1a19e6b14e31d295b7372f3346580c3e85690ff5#diff-b94d08b409f9d05fb65b6cccaf7b3e4ecc7cc333
Co-authored-by: Jimmy Praet <jimmy.praet@ksz-bcss.fgov.be >
2023-04-05 13:49:22 +03:00
Giteabot and alex
8d88f148d7
docs: make the required backticks in email password more explicit ( #23923 ) ( #23926 )
...
Backport #23923 by @teauxfu
updated the example config to make the needed backticks around the
password more obvious
Co-authored-by: alex <alexmw777@gmail.com >
2023-04-04 15:06:54 -04:00
Giteabot and alex
7bfab90a8f
docs: fix typo ( #23924 ) ( #23925 )
...
Backport #23924 by @teauxfu
fixes a minor typo in the email templates page
Co-authored-by: alex <alexmw777@gmail.com >
2023-04-04 18:13:09 +02:00
Giteabot and wxiaoguang
7c180ff8eb
Fix code view (diff) broken layout ( #23096 ) ( #23918 )
...
Backport #23096 by @wxiaoguang
Close #22911
I think it's ready for review now, feel free to test it, welcome to help
to improve.
### Before
### After
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-04 16:02:29 +02:00
Giteabot and KN4CK3R
c34f7cdb1a
Use ghost user if package creator does not exist ( #23822 ) ( #23915 )
...
Backport #23822 by @KN4CK3R
Fixes #23818
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-04-04 20:37:28 +08:00
Giteabot and silverwind
fd0baf637d
Org pages style fixes ( #23901 ) ( #23914 )
...
Backport #23901 by @silverwind
Few fixes/enhancements around org pages:
Use flexbox for member and repo lists and tweak rendering of tabs and
list:
<img width="765" alt="Screenshot 2023-04-03 at 22 54 24"
src="https://user-images.githubusercontent.com/115237/229625716-92a834c3-9121-4729-8b9b-3a3973cf9a91.png ">
<img width="771" alt="Screenshot 2023-04-03 at 22 55 15"
src="https://user-images.githubusercontent.com/115237/229625719-acc08ce8-4489-44a6-a9b9-e36755c55b1d.png ">
Vertically center remove/leave buttons, add link to avatar:
<img width="1223" alt="Screenshot 2023-04-03 at 21 51 20"
src="https://user-images.githubusercontent.com/115237/229612616-b662b795-e754-41a1-a77a-381c267e6104.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-04-04 19:05:41 +08:00
Giteabot and 6543
dff3ce089d
User/Org Feed render description as per web ( #23887 ) ( #23906 )
...
Backport #23887 by @6543
User descriptions should be rendered so that links and other markup
appear correct in RSS feeds.
test will be added by #23874
Co-authored-by: 6543 <6543@obermui.de >
2023-04-04 00:44:50 -04:00
Giteabot and wxiaoguang
9836b7db7b
Use User.ID instead of User.Name in ActivityPub API for Person IRI ( #23823 ) ( #23905 )
...
Backport #23823 by @wxiaoguang
Thanks to @trwnh
Close #23802
The ActivityPub id is an HTTPS URI that should remain constant, even if
the user changes their name.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-03 22:41:57 -05:00
Giteabot and wxiaoguang
d752f0d7d0
Add git dashes separator to some "log" and "diff" commands ( #23606 ) ( #23720 )
...
Backport #23606 by @wxiaoguang
Reference:
https://github.com/go-gitea/gitea/issues/22578#issuecomment-1444180053
Credits to @tdesveaux , thank you very much for catching the problem. If
you'd like to open a PR, feel free to replace this one.
Git reports fatal errors for ambiguous arguments:
```
fatal: ambiguous argument 'refs/a...refs/b': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
```
So the `--` separator is necessary in some cases.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-03 21:43:51 -04:00
Giteabot and wxiaoguang
669c76c0fd
Fix cases.Title crash for concurrency ( #23885 ) ( #23903 )
...
Backport #23885 by @wxiaoguang
Regression of #19676 and #21814
Fix #23872
`cases.Title` is not thread-safe, it has internal state, so it can't be
used as a global shared variable.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-04 01:26:14 +02:00
Giteabot and wxiaoguang
ac57ec5c47
Fix user profile description rendering ( #23882 ) ( #23902 )
...
Backport #23882 by @wxiaoguang
Found an UI problem when testing #23874
The `ul li` styles were polluted.
Before:
After:
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-03 16:00:24 -05:00
Giteabot and yp05327
f6dab64412
Convert .Source.SkipVerify to $cfg.SkipVerify ( #23839 ) ( #23899 )
...
Backport #23839 by @yp05327
`Source` doesn't have `SkipVerify`, it is defined in `cfg`
Co-authored-by: yp05327 <576951401@qq.com >
2023-04-03 13:02:28 -04:00
Giteabot and silverwind
847f0bb9f3
Fix review box viewport overflow issue ( #23800 ) ( #23898 )
...
Backport #23800 by @silverwind
Fix regression that came likely from
https://github.com/go-gitea/gitea/pull/23271 :
Long lines of text currently cause the review box's CodeMirror element
to resize which apparently is not recognized by [popper's resize
detection](https://popper.js.org/docs/v2/modifiers/event-listeners/ ) and
which causes the element to go partially out of viewport until a reflow
happens:
Fix this by setting the element to a static width derived from viewport
width and remove the previously clumsy media queries.
Co-authored-by: silverwind <me@silverwind.io >
2023-04-03 12:11:08 -04:00
Giteabot and Jason Song
1886bd6a01
Rename actions unit to repo.actions and add docs for it ( #23733 ) ( #23881 )
...
Backport #23733 by @wolfogre
I neglected that the `NameKey` of `Unit` is not only for translation,
but also configuration. So it should be `repo.actions` to maintain
consistency.
## ⚠️ BREAKING ⚠️
If users already use `actions.actions` in `DISABLED_REPO_UNITS` or
`DEFAULT_REPO_UNITS`, it will be treated as an invalid unit key.
Co-authored-by: Jason Song <i@wolfogre.com >
2023-04-03 12:54:36 +02:00
Giteabot and yp05327
c68650a7fb
Prefill input values in oauth settings as intended ( #23829 ) ( #23871 )
...
Backport #23829 by @yp05327
Co-authored-by: yp05327 <576951401@qq.com >
2023-04-03 04:33:12 +02:00
Giteabot and Zettat123
fe7caa05cc
Check IsActionsToken for LFS authentication ( #23841 ) ( #23875 )
...
Backport #23841 by @Zettat123
Close #23824
Actions cannot fetch LFS objects from private repos because we don't
check if the user is the `ActionUser`.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-04-02 21:30:33 +01:00
Giteabot
026167f854
Remove assertion debug code for show/hide refactoring ( #23576 ) ( #23868 )
...
Backport #23576 by @wxiaoguang
When doing the refactoring:
* #22950
I added some debug mode code (assertShown) to help to catch bugs, it did
catch some bugs like:
* #23074
If it has been proved that there is no more bugs, this assertion could
be removed easily and clearly.
Feel free to decide when to remove it (feel free to convert it from
Draft to Ready for Review).
2023-04-02 16:20:06 +08:00
Giteabot and wxiaoguang
8abfbe2165
Fix JS error when changing PR's target branch ( #23862 ) ( #23864 )
...
Backport #23862 by @wxiaoguang
Caught by @justusbunsi
An old bug from #6488
In `pullrequest_targetbranch_change`, the `data` might be empty, because
`UpdatePullRequestTarget` may respond `http.StatusNoContent`.
And the old code's `$branchTarget.text(data.base_branch);` doesn't make
sense, because in the end, the page will be always reloaded.
So, just remove the `$branchTarget.text(data.base_branch);`, everything
should be fine.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-04-01 21:15:46 -04:00
Giteabot and yp05327
16bfe983c2
Fix 500 error if there is a name conflict when edit authentication source ( #23832 ) ( #23852 )
...
Backport #23832 by @yp05327
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-31 12:53:25 -04:00
Giteabot and silverwind
503af4b807
CSS color tweaks ( #23828 ) ( #23842 )
...
Backport #23828 by @silverwind
Change grey shades in arc-green to match the theme more:
<img width="661" alt="Screenshot 2023-03-30 at 21 42 34"
src="https://user-images.githubusercontent.com/115237/228957952-8e099e56-6923-4aa6-8ce9-3c1cd898b73e.png ">
Adjusted grey shade in light theme:
<img width="652" alt="image"
src="https://user-images.githubusercontent.com/115237/228963876-3bde6181-8397-4dc2-be72-33982e6c7acb.png ">
Increase contrast in arc-green, change background to slightly darker
shade, change forgeground to slightly brighter colors:
<img width="283" alt="Screenshot 2023-03-30 at 22 33 20"
src="https://user-images.githubusercontent.com/115237/228957957-272c24a5-dd0b-427a-b6b7-e62836bdd73c.png ">
Increase contrast of grey text in light theme as well by making them
darker:
<img width="273" alt="Screenshot 2023-03-30 at 22 33 35"
src="https://user-images.githubusercontent.com/115237/228957959-283139c7-6fa7-4b68-9fdd-16c668ad1301.png ">
Add color rule for border multiple select items:
<img width="183" alt="Screenshot 2023-03-30 at 22 29 31"
src="https://user-images.githubusercontent.com/115237/228957954-6b5a752d-bbb0-4519-ab35-d02c0804d955.png ">
<img width="181" alt="Screenshot 2023-03-30 at 22 29 46"
src="https://user-images.githubusercontent.com/115237/228957956-fca9790a-d6c9-4f31-8d1b-d183ab3ac669.png ">
Added color rule for red `*` on required form fields:
<img width="97" alt="image"
src="https://user-images.githubusercontent.com/115237/228958760-517ad9ef-565d-4349-b734-9b559ab42429.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-31 17:24:09 +08:00
Giteabot and yp05327
8b3dd7de5d
Fix incorrect visibility dropdown list in add/edit user page ( #23804 ) ( #23833 )
...
Backport #23804 by @yp05327
Visibility dropdown list will not work in add/edit user page when error
occurred
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-31 16:25:21 +08:00
Giteabot and sillyguodong
a04535e212
[Patch] Fix closed PR also triggers Webhooks and actions ( #23782 ) ( #23834 )
...
Backport #23782 by @sillyguodong
Fix #23707
Cause by #23189
This PR is a quick fix that, when pushing commits to closed PR, webhook
and actions also be triggered.
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-03-31 14:29:23 +08:00
Giteabot and zeripath
494721cc90
Don't apply the group filter when listing LDAP group membership if it is empty ( #23745 ) ( #23788 )
...
Backport #23745 by @zeripath
When running listLdapGroupMemberships check if the groupFilter is empty
before using it to list memberships.
Fix #23615
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2023-03-29 15:00:12 -04:00
Giteabot and silverwind
d27e693ecf
Add CSS rules for basic colored labels ( #23774 ) ( #23777 )
...
Backport #23774 by @silverwind
Before:
<img width="164" alt="Screenshot 2023-03-28 at 23 35 46"
src="https://user-images.githubusercontent.com/115237/228372437-663111b9-7285-4fa2-9125-fb5e1cad21d7.png ">
After:
<img width="166" alt="Screenshot 2023-03-28 at 23 35 54"
src="https://user-images.githubusercontent.com/115237/228372441-49430517-6b2d-4389-b11c-c30a724f6de7.png ">
Also I removed the `!important` on the primary label as it's very likely
unnecessary with the amount of specificity the selector already has.
Co-authored-by: silverwind <me@silverwind.io >
2023-03-29 14:15:00 -04:00
Giteabot and Balki
d977e7ec10
Add creation time in tag list page ( #23693 ) ( #23773 )
...
Backport #23693 by @balki
Fixes #21699
Co-authored-by: Balki <189196+balki@users.noreply.github.com >
2023-03-28 18:00:07 -04:00
428d26d4a8
fix br display for packages curls ( #23737 ) ( #23764 )
...
Backport #23737 by @HesterG
Before:
<img width="1403" alt="截屏2023-03-27 15 48 23"
src="https://user-images.githubusercontent.com/17645053/227875392-399debf7-db75-4d9a-9436-409f75447c65.png ">
This happens because the `<br>` matches this
[rule](https://github.com/go-gitea/gitea/blob/e6e602fd8d35471f1e2f4a42669a1f17e76e0176/web_src/css/markup/content.css#L428 ),
which is not necessary here (This is introduced by #22861 , did a quick
check, and this is the only place used `<br>` inside `<code>` from the
PR):
```css
.markup code br,
.markup tt br {
display: none;
}
```
After:
<img width="1398" alt="截屏2023-03-27 15 46 50"
src="https://user-images.githubusercontent.com/17645053/227875244-b7fba432-b32c-42f7-9517-4e05bb2e64ea.png ">
Co-authored-by: Hester Gong <hestergong@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-28 07:31:42 +01:00
Giteabot and wxiaoguang
a254c26df9
Fix issue due date edit toggle bug ( #23723 ) ( #23758 )
...
Backport #23723 by @wxiaoguang
Use `toggleElem` instead of jQuery's `fadeToggle`, which can't be caught
by eslint jquery plugin.
Hopefully this could be the last bug for the jQuery show/hide
refactoring.
Need to backport.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-27 21:13:11 -05:00
Giteabot and wxiaoguang
1fed0e1adc
Fix profile page email display, respect settings ( #23747 ) ( #23756 )
...
Backport #23747 by @wxiaoguang
Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate`
setting.
* It doesn't make sense to show user's own E-mail to themself.
* Always hide the E-mail if KeepEmailPrivate=true, then the user could
know how their profile page looks like for others.
* Revert the `setting.UI.ShowUserEmail` change from #4981 . This setting
is used to control the E-mail display, not only for the user list page.
ps: the incorrect `<div .../>` tag on the profile page has been fixed by
#23748 together, so this PR becomes simpler.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-28 07:55:20 +08:00
Giteabot and ChristopherHX
35039b8563
Use GitHub Actions compatible globbing for branches, tag, path filter ( #22804 ) ( #23740 )
...
Backport #22804 by @ChristopherHX
Replaces the current globbing library with a
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
compatible one.
This adds support for
- `paths-ignore`, `tags-ignore` and `branches-ignore` filters.
- negative patterns in `paths`, `tags` and `branches` filters
- using both `tags` and `paths` filter on the push event
Original PR https://gitea.com/gitea/act/pulls/13 .
nektos/act PR https://github.com/nektos/act/pull/1618 for the
workflowpattern package (It can take some months for it to appear in
https://gitea.com/gitea/act )
Related to https://github.com/go-gitea/gitea/issues/13539
Co-authored-by: ChristopherHX <christopher.homberger@web.de >
2023-03-27 14:01:46 -04:00
Giteabot and yp05327
62afc0a727
Redirect to project again after editing it ( #23326 ) ( #23739 )
...
Backport #23326 by @yp05327
A part of https://github.com/go-gitea/gitea/pull/22865
We have edit buttons in projects list page and project view page.
But after user edit a project, it will always redirect to the projects
list page.
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-27 21:42:47 +08:00
Giteabot
f23b587fe7
Describe Gitea's purpose more accurately ( #23698 ) ( #23710 )
2023-03-26 17:33:32 +08:00
305cac291d
Remove row clicking from notification table ( #22695 ) ( #23706 )
...
Backport #22695 by @jolheiser
Resolves #22692
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-03-26 01:21:40 +02:00
Giteabot and Zettat123
6705b215db
Fix incorrect HookEventType of pull request review comments ( #23650 ) ( #23678 )
...
Backport #23650 by @Zettat123
`HookEventType` of pull request review comments should be
`HookEventPullRequestReviewComment` but some event types are
`HookEventPullRequestComment` now.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-03-24 20:56:15 -04:00
Giteabot and sillyguodong
a9b4aa4cc4
Create commit status when event is pull_request_sync ( #23683 ) ( #23691 )
...
Backport #23683 by @sillyguodong
Fix : #23674
If the type of `hook_event` is `pull_request_sync`, also need to insert
a record of `commit_status` into DB.
Because `pull_request` event and `pull_request_sync` event have the same
payload, so the code is reusable.
Screenshot:
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2023-03-24 17:40:24 -04:00
Giteabot and Jason Song
1faa39b44c
Drop migration for ForeignReference ( #23605 ) ( #23666 )
...
Backport #23605 by @wolfogre
Fix
https://github.com/go-gitea/gitea/issues/21086#issuecomment-1476560381
Related to #21721
Co-authored-by: Jason Song <i@wolfogre.com >
2023-03-24 16:57:00 -04:00
Giteabot and yp05327
484cb22f14
Fix incorrect package doc link ( #23679 ) ( #23689 )
...
Backport #23679 by @yp05327
package doc link is changed in
https://github.com/go-gitea/gitea/pull/23629
Co-authored-by: yp05327 <576951401@qq.com >
2023-03-24 14:43:02 -04:00
a28863bff7
Fix codeblocks in the cheat sheet ( #23664 ) ( #23669 )
...
Backport #23664 by @SuperSandro2000
Conflicts fixed by Andrew Thornton <art27@cantab.net >
Co-authored-by: Sandro <sandro.jaeckel@gmail.com >
Co-authored-by: Andrew Thornton <art27@cantab.net >
2023-03-23 16:50:56 -04:00
Giteabot
e7a5429d7a
Improve workflow event triggers ( #23613 ) ( #23648 )
2023-03-23 16:34:05 +08:00
Giteabot
9dfdfe2389
Remove conflicting CSS rules on notifications, improve notifications table ( #23565 ) ( #23621 )
...
Backport #23565 by @silverwind
Dropdowns on `/notifications/subscriptions` before and after:
<img width="157" alt="Screenshot 2023-03-18 at 20 37 12"
src="https://user-images.githubusercontent.com/115237/226133906-e4ad6a0a-de24-4324-8e1d-94081d23fe85.png ">
<img width="152" alt="Screenshot 2023-03-18 at 20 41 29"
src="https://user-images.githubusercontent.com/115237/226134038-c3946c32-a424-4b92-ad15-890e1036cafe.png ">
These selectors are meant to target the notification list which I
improved:
<img width="1145" alt="Screenshot 2023-03-19 at 01 52 11"
src="https://user-images.githubusercontent.com/115237/226147907-1c35736a-4bc9-4698-9813-21a20a1d2106.png ">
<img width="1148" alt="Screenshot 2023-03-19 at 01 54 17"
src="https://user-images.githubusercontent.com/115237/226147920-626dbd84-11d3-48db-a177-6d808e3212c0.png ">
2023-03-21 17:04:01 -04:00
Giteabot and silverwind
4439a68911
Fix pagination on /notifications/watching ( #23564 ) ( #23603 )
...
Backport #23564 by @silverwind
The `q` parameter was not rendered in pagination links because
`context.Pagination:AddParam` checks for existance of the parameter in
`ctx.Data` where it was absent. Added the parameter there to fix it.
Co-authored-by: silverwind <me@silverwind.io >
2023-03-21 16:10:47 -04:00
Giteabot and 来自村里的小螃蟹
782c376c8b
fix submodule is nil panic ( #23588 ) ( #23601 )
...
Backport #23588 by @viletyy
#23587
submodule path is nil
It is panic a nil error
Co-authored-by: 来自村里的小螃蟹 <yystopf@163.com >
2023-03-21 09:39:40 +08:00
Giteabot and zeripath
a3b917151c
Improve template error reporting ( #23396 ) ( #23600 )
...
Backport #23396 by @zeripath
There are multiple duplicate reports of errors during template rendering
due to broken custom templates.
Unfortunately the error returned here is somewhat difficult for users to
understand and it doesn't return the context of the error.
This PR attempts to parse the error returned by the template renderer to
add in some further context including the filename of the template AND
the preceding lines within that template file.
Ref #23274
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2023-03-20 17:53:45 -04:00
726d6a5077
Add CHANGELOG for 1.19.0 ( #23583 ) ( #23586 )
...
Backport #23583 by @delvh
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-20 16:34:28 +08:00
Giteabot and silverwind
4730ed18f1
Add .patch to attachment.ALLOWED_TYPES ( #23580 ) ( #23582 )
...
Backport #23580 by @silverwind
Updated this default to GitHub's latest, adding the `.patch` file
extension to allowed types.
Co-authored-by: silverwind <me@silverwind.io >
2023-03-19 16:48:44 -04:00
937996c74c
Match api migration behavior to web behavior ( #23552 ) ( #23573 )
...
Backport #23552 by @atomaka
When attempting to migrate a repository via the API endpoint comments
are always included. This can create a problem if your source repository
has issues or pull requests but you do not want to import them into
Gitea that displays as something like:
> Error 500: We were unable to perform the request due to server-side
problems. 'comment references non existent IssueIndex 4
There are only two ways to resolve this:
1. Migrate using the web interface
2. Migrate using the API including at issues or pull requests.
This PR matches the behavior of the API migration router to the web
migration router.
Co-authored-by: Andrew Tomaka <atomaka@atomaka.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-19 15:30:02 +08:00
3f253b3f5a
Fix some broken css ( #23560 ) ( #23567 )
...
Backport #23560 by @wxiaoguang
1. The "close" inside "modal" are likely broken for long time
* There is no var called `--body-color`
* There is no `fullscreen modal`
* The `.ui.modal > .close.inside` doesn't seem to match most icons. It
only matches a few like "fork-repo-modal" or "adopt repo". Other places
are just buggy code copied again and again.
2. Convert the legacy `&:hover` LESS syntax to CSS syntax
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: delvh <leon@kske.dev >
2023-03-18 21:37:16 -04:00
Giteabot and silverwind
f5a98b0f5b
Fix sticky header in diff view ( #23554 ) ( #23568 )
...
Backport #23554 by @silverwind
Ressurection of #23549 .
Fix regression
https://github.com/go-gitea/gitea/pull/23513#issuecomment-1474356817
from #23271 .
The previous sticky CSS did assume the content is always 2 rows, but
since that PR, it's single-row above 993px width.
Adjust the sticky offset to match and add a small tweak that hides
content behind the `border-radius`.
Single row:
<img width="1264" alt="Screenshot 2023-03-17 at 21 33 05"
src="https://user-images.githubusercontent.com/115237/226034050-a04b131d-fd3f-45c0-bc72-413738a59825.png ">
Double row:
<img width="1243" alt="Screenshot 2023-03-17 at 21 32 53"
src="https://user-images.githubusercontent.com/115237/226034163-2f1c6aa9-fc72-432f-bc46-9a7119da8677.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-19 01:29:16 +01:00
Giteabot and silverwind
1a97a84023
Fix JS error on compare page ( #23551 ) ( #23566 )
...
Backport #23551 by @silverwind
Fix regression from https://github.com/go-gitea/gitea/pull/23271 . This
code apparently runs on the compare page where there is no review button
so check for existance of both button and content.
<img width="1226" alt="Screenshot 2023-03-17 at 21 42 47"
src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png ">
Fixes #23562
Co-authored-by: silverwind <me@silverwind.io >
2023-03-18 16:48:13 -05:00
Giteabot and Hester Gong
22911a1ece
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) ( #23513 ) ( #23540 )
...
Backport #23513 by @HesterG
Close #23466
Right now on pull request "files Changed" tab, if a file is viewed, when
the comments' links are visited, the comment will not be shown as the
file is folded after viewed. This PR is to improve the behavior, to make
the comment seen even the related file is folded, like on github.
And right now scroll position will be remembered and hence it won’t
scroll to hashed comment after refreshing, this PR also adjust the
scroll position remembering behavior: When there is hash comment in url,
do not remember the scroll position.
Before:
https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov
After:
https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov
Update - long comment's behavior after using `scrollTop ` (Comment div
scroll to the position which is 30px below the diff header, or 30px
below top on conversation tab):
https://user-images.githubusercontent.com/17645053/225614460-0602c1a6-229c-41f4-84d2-334e78251486.mov
Co-authored-by: Hester Gong <hestergong@gmail.com >
2023-03-17 22:59:18 -04:00
Giteabot and silverwind
4b763d8d37
Fix diff detail buttons wrapping, use tippy for review box ( #23271 ) ( #23546 )
...
Backport #23271 by @silverwind
Fix visual regression introduced by
https://github.com/go-gitea/gitea/pull/22986 .
Before:
<img width="1277" alt="image"
src="https://user-images.githubusercontent.com/115237/222792814-d70c2173-0c7c-4db2-8839-95be63cdc8ee.png ">
<img width="649" alt="image"
src="https://user-images.githubusercontent.com/115237/222792989-9b1f5e12-becd-40cc-b02c-e9f59a8e72a4.png ">
After:
<img width="1274" alt="image"
src="https://user-images.githubusercontent.com/115237/222792769-e7a9702f-4b6a-46c4-9385-da103ed4dff0.png ">
<img width="565" alt="image"
src="https://user-images.githubusercontent.com/115237/222793084-6de6482b-11dc-4d38-b514-15884d20e140.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-17 14:52:04 -04:00
bd1a915bdb
Use octicon-verified for gpg signatures ( #23529 ) ( #23536 )
...
Backport #23529 by @silverwind
Before:
<img width="292" alt="Screenshot 2023-03-16 at 23 40 47"
src="https://user-images.githubusercontent.com/115237/225768871-43e11ced-e340-4c88-b756-25f9f7076fd2.png ">
<img width="288" alt="Screenshot 2023-03-16 at 23 51 05"
src="https://user-images.githubusercontent.com/115237/225770071-b51f3ed6-ef14-421b-a5bc-6a26e808d404.png ">
After:
<img width="291" alt="Screenshot 2023-03-16 at 23 40 37"
src="https://user-images.githubusercontent.com/115237/225768864-ea4956c7-8c57-4148-9d89-c818991a7538.png ">
<img width="281" alt="image"
src="https://user-images.githubusercontent.com/115237/225769978-0b9c6c52-9a13-4c23-b13e-8a8a692abf43.png ">
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-17 11:39:31 -04:00
Giteabot and silverwind
cab7044772
Increase horizontal page padding ( #23507 ) ( #23537 )
...
Backport #23507 by @silverwind
Add a bit more empty space on left and right side of page content for a
more pleasant viewing experience. Also tweaked the mobile navbar to
match.
Before:
<img width="1276" alt="Screenshot 2023-03-16 at 00 58 23"
src="https://user-images.githubusercontent.com/115237/225473942-f544106f-1b61-456a-99fb-3ba136cabc8d.png ">
After:
<img width="1270" alt="Screenshot 2023-03-16 at 00 58 37"
src="https://user-images.githubusercontent.com/115237/225473959-8b555359-a08d-48e1-9476-2710aabb1166.png ">
Mobile Navbar:
<img width="673" alt="Screenshot 2023-03-16 at 01 05 12"
src="https://user-images.githubusercontent.com/115237/225473966-adccef2b-4d34-44ed-8c75-d4ca46d96cf3.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-17 21:01:47 +08:00
68c9f1abd8
Use <nav> instead of <div> in the global navbar ( #23125 ) ( #23533 )
...
Backport #23125 by @delvh
Furthermore improved/deleted some comments in the template.
The appearance did not change.
Co-authored-by: delvh <leon@kske.dev >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-17 01:28:17 -04:00
Giteabot and silverwind
23a6fa9421
Make time tooltips interactive ( #23526 ) ( #23527 )
...
Backport #23526 by @silverwind
Fixes https://codeberg.org/forgejo/forgejo/issues/511
<img width="379" alt="Screenshot 2023-03-16 at 20 23 10"
src="https://user-images.githubusercontent.com/115237/225731294-4c6e4f44-bdcc-4c8c-86e2-49f7c03b377d.png ">
Co-authored-by: silverwind <me@silverwind.io >
2023-03-16 16:23:11 -05:00
GiteabotandYarden Shoham
