Zettat123 and GitHub
bcc4c62b6c
Check IsActionsToken for LFS authentication ( #23841 )
...
Close #23824
Actions cannot fetch LFS objects from private repos because we don't
check if the user is the `ActionUser`.
2023-04-02 22:43:11 +08:00
Zettat123 and GitHub
e6e602fd8d
Fix project card preview select and template select ( #23684 )
...
Now user cannot set Card Previews when creating a new project.
Before:
https://user-images.githubusercontent.com/15528715/227488883-29bbd636-8b98-45b3-b2f8-de5206b045dc.mp4
After:
https://user-images.githubusercontent.com/15528715/227488976-3447f252-805a-4f18-ae0e-1cddd921dcc3.mp4
2023-03-27 13:15:41 +08:00
Zettat123 and GitHub
b958dba1a0
Improve indices for action table ( #23532 )
...
Close #21611
Add the index mentioned in
https://github.com/go-gitea/gitea/issues/21611#issuecomment-1451113252 .
Since we already have an index for `("created_unix", "user_id",
"is_deleted")` columns on PostgreSQL, I removed the database type check
to apply this index to all types of databases.
2023-03-24 23:44:33 +08:00
Zettat123 and GitHub
9e04627aca
Fix incorrect HookEventType of pull request review comments ( #23650 )
...
`HookEventType` of pull request review comments should be
`HookEventPullRequestReviewComment` but some event types are
`HookEventPullRequestComment` now.
2023-03-24 13:13:04 +08:00
df411819eb
Check LFS/Packages settings in dump and doctor command ( #23631 )
...
Close #23622
As described in the issue, disabling the LFS/Package settings will cause
errors when running `gitea dump` or `gitea doctor`. We need to check the
settings and the related operations should be skipped if the settings
are disabled.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-23 20:30:28 +08:00
e7f0bcf884
Improve workflow event triggers ( #23613 )
...
Follow #23037
Fix [#22598
comment](https://github.com/go-gitea/gitea/issues/22958#issuecomment-1475763042 )
Workflows with `pull_request` trigger event can't be triggered by
`pull_request_sync` event. This PR adds the `canGithubEventMatch`
function to check if a Github event can match any Gitea event. If the
Github event matches a Gitea event, the related workflows should be
triggered.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-03-23 12:04:15 +08:00
46addc1f93
Return repository in npm package metadata endpoint ( #23539 )
...
Close #23444
Add `Repository` to npm package `Metadata` struct so the `repository` in
`package.json` can be stored and be returned in the endpoint.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-03-17 14:39:19 -04:00
Zettat123 and GitHub
8421b8264f
Handle missing README in create repos API ( #23387 )
...
Close #22934
In `/user/repos` API (and other APIs related to creating repos), user
can specify a readme template for auto init. At present, if the
specified template does not exist, a `500` will be returned . This PR
improved the logic and will return a `400` instead of `500`.
2023-03-13 16:55:30 -05:00
Zettat123 and GitHub
3de9e63fd0
Hide target selector if tag exists when creating new release ( #23171 )
...
Close #22649 .
|status|screenshot|
|-|-|
|empty tag name|<img
src="https://user-images.githubusercontent.com/15528715/221490165-fd3abd2e-6dc5-4562-bece-d1d6a305479e.png "
width="300px"/>|
|new tag|<img
src="https://user-images.githubusercontent.com/15528715/221490450-49b2a48e-b206-49f4-bd79-34b1ea64156f.png "
width="300px"/>|
|existing tag|<img
src="https://user-images.githubusercontent.com/15528715/221490301-4d1879dd-4947-4abc-9b9a-e77be1806981.png "
width="300px"/>|
2023-03-10 10:42:38 -06:00
Zettat123 and GitHub
15a1c2d7ef
Fix panic when getting notes by ref ( #23372 )
...
Fix #23357 .
Now the `/repos/{owner}/{repo}/git/notes/{sha}` API supports getting
notes by a ref or sha
(https://try.gitea.io/api/swagger#/repository/repoGetNote ). But the
`GetNote` func can only accept commit ID.
https://github.com/go-gitea/gitea/blob/a12f5757372f751d25f9e5ca1f168f6920ded894/modules/git/notes_nogogit.go#L18
So we need to convert the query parameter to commit ID before calling
`GetNote`.
2023-03-08 20:21:23 +08:00
Zettat123 and GitHub
611705888f
Remove useless comment in #23114 ( #23173 )
...
The `isAdmin` param is no longer used so the comment should be removed.
https://github.com/go-gitea/gitea/blob/d27d36f2f4dd389050e613967ad2a5d02d250acc/routers/web/explore/repo.go#L36-L37
2023-02-27 13:24:33 +01:00
347df0cbf0
Show empty repos in Admin Repository Management page ( #23114 )
...
The **Admin Repository Management** page and the **Explore Repository**
page both use the `RenderRepoSearch` function. In this function, the
`OnlyShowRelevant` search option is `true` when querying repositories
for admin page.
https://github.com/go-gitea/gitea/blob/edf98a2dc30956c8e04b778bb7f1ce55c14ba963/routers/web/explore/repo.go#L99-L115
Refer to
[#19361 ](https://github.com/go-gitea/gitea/pull/19361/files#diff-8058dfb85557010e0592d586675ec62ce406af7068e6311f39c160deac37f149R497 ),
the repositories with `is_empty=true` will be hidden if
`OnlyShowRelevant` is `true`.
Administrators should be able to see all repositories. So
`OnlyShowRelevant` shouldn't be set to `true` .
---------
Co-authored-by: Andrew Thornton <art27@cantab.net >
2023-02-24 19:11:31 +00:00
a6175b01d9
Fix nil context in RenderMarkdownToHtml ( #23092 )
...
Fix #23082 .
This bug is caused by a nil context in
https://github.com/go-gitea/gitea/issues/23082#issuecomment-1441276546 .
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-24 14:36:07 +08:00
4de5cd9f36
Return empty url for submodule tree entries ( #23043 )
...
Close #22614 .
Refer to [Github's
API](https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree ),
if a tree entry is a submodule, its url will be an empty string.
---------
Co-authored-by: delvh <leon@kske.dev >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-02-21 12:31:17 -05:00
Zettat123 and GitHub
7f790c70b9
Remove delete button for review comment ( #23036 )
...
Fix #23031 .
Currently, only comments with type `CommentTypeComment` or
`CommentTypeCode` can be deleted. If user create a review comment, the
type of the comment will be `CommentTypeReview` so the comment cannot be
deleted.
https://github.com/go-gitea/gitea/blob/e7be610d5773e69abbfb98d19e23112dfad6dfcc/routers/web/repo/issue.go#L2860-L2868
And in Github, user also cannot delete a review comment. There isn't a
delete button in the menu.
<img
src="https://user-images.githubusercontent.com/15528715/220275166-5ae2dc10-4003-4857-b14e-d7b02644345f.png "
width="640px" />
So we should remove the delete button from the menu when the comment's
type is `CommentTypeReview`.
2023-02-21 16:25:47 +08:00
9a83aa28a3
Get rules by id when editing branch protection rule ( #22932 )
...
When users rename an existing branch protection rule, a new rule with
the new name will be created and the old rule will still exist.
---
The reason is that the `SettingsProtectedBranchPost` function only get
branch protection rule by name before updating or creating a rule. When
the rule name changes, the function cannot find the existing rule so it
will create a new rule rather than update the existing rule. To fix the
bug, the function should get rule by id first.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-20 19:30:41 +08:00
1d64eafe8f
Add me to maintainers ( #22998 )
...
Add me to maintainers.
[List of merged
PRs](https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3AZettat123+is%3Amerged )
Co-authored-by: Jason Song <i@wolfogre.com >
2023-02-20 16:42:02 +08:00
65fc2d1b83
Fix avatar misalignment ( #22955 )
...
Fix #22818 .
| Before | After |
| ---- | ---- |
| <img
src="https://user-images.githubusercontent.com/15528715/219617504-d86e7a90-d4ac-4a92-bd8a-100dddc693d5.png "
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618645-a4045f65-bda6-49ce-a676-f03a9817bb70.png "
width="200px" />|
| <img
src="https://user-images.githubusercontent.com/15528715/219618013-844ef208-853b-44bd-a67c-36e360f0ffa7.png "
width="200px" /> | <img
src="https://user-images.githubusercontent.com/15528715/219618361-cb13c369-852e-47bf-ae30-e429d348823d.png "
width="200px" /> |
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-20 07:07:46 +08:00
5a12e95d2a
Fix 404 error viewing the LFS file ( #22945 )
...
Fix #22734 .
According to
[`view_file.tmpl`](https://github.com/go-gitea/gitea/blob/main/templates/repo/view_file.tmpl#L82 ),
`lfs_file.tmpl` should use `AssetUrlPrefix` instead of `AppSubUrl`.
Co-authored-by: Jason Song <i@wolfogre.com >
2023-02-17 11:55:33 +08:00
0ab22a1a02
fix incorrect role labels for migrated issues and comments ( #22914 )
...
Fix #22797 .
## Reason
If a comment was migrated from other platforms, this comment may have an
original author and its poster is always not the original author. When
the `roleDescriptor` func get the poster's role descriptor for a
comment, it does not check if the comment has an original author. So the
migrated comments' original authors might be marked as incorrect roles.
---------
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-15 12:29:13 -05:00
Zettat123 and GitHub
71ee488098
Fix dark-colored description text in arc-green theme ( #22908 )
...
Fix #22873 .
2023-02-14 13:05:19 -06:00
Zettat123andGitHub
