yp05327
bbf83f5d4b
Improve permission check of packages ( #23879 )
...
At first, we have one unified team unit permission which is called
`Team.Authorize` in DB.
But since https://github.com/go-gitea/gitea/pull/17811 , we allowed
different units to have different permission.
The old code is only designed for the old version. So after #17811 , if
org users have write permission of other units, but have no permission
of packages, they can also get write permission of packages.
Co-authored-by: delvh <dev.lh@web.de>
2023-04-06 22:18:29 +08:00
Lunny Xiao
5cb394ff2f
Adjust some documentations titles ( #23941 )
...
As title.
2023-04-06 11:06:32 +02:00
GiteaBot
bac9c06880
[skip ci] Updated translations via Crowdin
2023-04-06 00:07:08 +00:00
Jonathan Tran
8c3cee7a72
Update eslints for Vue 3 ( #23935 )
...
I found that some lint warnings in my editor are conflicting, and I
believe the root cause is using lints designed for Vue 2 instead of Vue
3. We moved to Vue 3 in #20044 .
I verified that the explicitly disabled rules in the changed file are
still part of the `vue/vue3-recommended` set.
See [Available rules -
eslint-plugin-vue](https://eslint.vuejs.org/rules/ ) for a full list of
lints.
2023-04-05 16:59:40 -04:00
wxiaoguang
376396a088
Fix image border-radius ( #23886 )
...
1. Instead of polluting the `border-radius` style globally, each "img"
usage should declare their own styles.
2. There were some bugs in code, I believe the `.img` selector was done
by mistake.
After:
2023-04-05 02:44:52 +02:00
GiteaBot
e485539a90
[skip ci] Updated translations via Crowdin
2023-04-05 00:07:08 +00:00
Jimmy Praet
54197b67f9
Scroll collapsed file into view ( #23702 )
2023-04-05 07:51:42 +08:00
alex
0983b237d5
docs: make the required backticks in email password more explicit ( #23923 )
...
updated the example config to make the needed backticks around the
password more obvious
2023-04-04 13:19:01 -04:00
alex
e6685fc4ce
docs: fix typo ( #23924 )
...
fixes a minor typo in the email templates page
2023-04-04 11:22:45 -04:00
Lunny Xiao
67103eb2bc
Update docs markdown file weight to make it clear ( #23909 )
...
For Docusaurus, it needs a meta data named `sidebar_position`, so we
copy all `weight` under `menu/sidebar` as top meta key.
2023-04-04 21:47:31 +08:00
Zettat123
6b0df6d8da
Add activity feeds API ( #23494 )
...
Close #5666
Add APIs for getting activity feeds.
2023-04-04 21:35:31 +08:00
wxiaoguang
d149093ce3
Fix code view (diff) broken layout ( #23096 )
...
Close #22911
I think it's ready for review now, feel free to test it, welcome to help
to improve.
### Before
### After
2023-04-04 19:05:07 +08:00
KN4CK3R
d93f3222a5
Use ghost user if package creator does not exist ( #23822 )
...
Fixes #23818
2023-04-04 16:14:46 +08:00
silverwind
62a9052075
Org pages style fixes ( #23901 )
...
Few fixes/enhancements around org pages:
Use flexbox for member and repo lists and tweak rendering of tabs and
list:
<img width="765" alt="Screenshot 2023-04-03 at 22 54 24"
src="https://user-images.githubusercontent.com/115237/229625716-92a834c3-9121-4729-8b9b-3a3973cf9a91.png ">
<img width="771" alt="Screenshot 2023-04-03 at 22 55 15"
src="https://user-images.githubusercontent.com/115237/229625719-acc08ce8-4489-44a6-a9b9-e36755c55b1d.png ">
Vertically center remove/leave buttons, add link to avatar:
<img width="1223" alt="Screenshot 2023-04-03 at 21 51 20"
src="https://user-images.githubusercontent.com/115237/229612616-b662b795-e754-41a1-a77a-381c267e6104.png ">
2023-04-04 06:49:09 +02:00
6543
2c585d62a4
User/Org Feed render description as per web ( #23887 )
...
User descriptions should be rendered so that links and other markup
appear correct in RSS feeds.
2023-04-04 04:39:47 +01:00
wxiaoguang
17f23182ff
Use User.ID instead of User.Name in ActivityPub API for Person IRI ( #23823 )
...
Thanks to @trwnh
Close #23802
The ActivityPub id is an HTTPS URI that should remain constant, even if
the user changes their name.
2023-04-04 10:08:23 +08:00
wxiaoguang
5115ffa90c
Remove fomantic ".link" selector and styles ( #23888 )
...
It's difficult to play with Fomantic's ".link" selector&styles, and it
doesn't bring any real benefit.
Instead, it sometimes introduces regressions (because of the `:not`
selector, really difficult to fine-tune).
Regression:
<details>
</details>
After this PR, there is no ".link" in code anymore. We do not need to
play the overwriting and `:not()` game anymore.
2023-04-03 20:47:23 -04:00
GiteaBot
e351a26ca6
[skip ci] Updated translations via Crowdin
2023-04-04 00:07:23 +00:00
wxiaoguang
5fc9929da7
Fix cases.Title crash for concurrency ( #23885 )
...
Regression of #19676 and #21814
Fix #23872
`cases.Title` is not thread-safe, it has internal state, so it can't be
used as a global shared variable.
2023-04-03 18:03:45 -04:00
Zettat123
cb6ed84c4b
Disable editing tags ( #23883 )
...
Fixes #23865
In GitHub, users cannot edit a tag.
<img
src="https://user-images.githubusercontent.com/15528715/229409445-4233941b-3a37-4846-bc0c-efa94b90d9e0.png "
width="600px" />
So in this PR the edit button will not be shown if the release's `IsTag`
is `true`
2023-04-03 17:08:29 -04:00
wxiaoguang
5ab1c7acec
Fix user profile description rendering ( #23882 )
...
The `ul li` styles were polluted.
Before:
After:
2023-04-03 16:11:16 -04:00
wxiaoguang
19de52e0f4
Introduce GiteaLocaleNumber custom element to handle number localization on pages. ( #23861 )
...
Follow #21429 & #22861
Use `<gitea-locale-number>` instead of backend `PrettyNumber`. All old
`PrettyNumber` related functions are removed. A lot of code could be
simplified.
And some functions haven't been used for long time (dead code), so they
are also removed by the way (eg: `SplitStringAtRuneN`, `Dedent`)
This PR only tries to improve the `PrettyNumber` rendering problem, it
doesn't touch the "plural" problem.
Screenshot:
2023-04-03 12:58:09 -04:00
yp05327
01d9466bfd
Convert .Source.SkipVerify to $cfg.SkipVerify ( #23839 )
...
`Source` doesn't have `SkipVerify`, it is defined in `cfg`
2023-04-03 12:06:16 -04:00
silverwind
d0c406a86f
Fix review box viewport overflow issue ( #23800 )
...
Fix regression that came likely from
https://github.com/go-gitea/gitea/pull/23271 :
Long lines of text currently cause the review box's CodeMirror element
to resize which apparently is not recognized by [popper's resize
detection](https://popper.js.org/docs/v2/modifiers/event-listeners/ ) and
which causes the element to go partially out of viewport until a reflow
happens:
Fix this by setting the element to a static width derived from viewport
width and remove the previously clumsy media queries.
2023-04-03 11:11:34 -04:00
yp05327
6eb856c614
Fix owner team access mode value in team_unit table ( #23675 )
...
All `access_mode` value of Owner Teams are 0(AccessModeNone) in
`team_unit` table, which should be 4(AccessModeOwner)
In `team` table:
In `team_unit` table:
ps: In https://github.com/go-gitea/gitea/pull/23630 , `access_mode` in
`team_unit` is used to check the team unit permission, but I found that
user can not see issues in owned org repos.
2023-04-03 10:36:35 -04:00
yp05327
29133f3d04
Fix submit button won't refresh in New Repository Fork page ( #22994 )
...
Fork a repo, and input an invalid repo name, you will get an error.
Then rename the repo name to a valid one, the submit button is still
disabled.
In other pages, for example, in create repo page, the submit button will
not be disabled.
So I removed the codes to disable the submit button.
2023-04-03 22:11:05 +08:00
wxiaoguang
5cc0801de9
Introduce GitHub markdown editor, keep EasyMDE as fallback ( #23876 )
...
The first step of the plan
* #23290
Thanks to @silverwind for the first try in #15394 . Close #10729 and a
lot of related issues.
The EasyMDE is not removed, now it works as a fallback, users can switch
between these two editors.
Editor list:
* Issue / PR comment
* Issue / PR comment edit
* Issue / PR comment quote reply
* PR diff view, inline comment
* PR diff view, inline comment edit
* PR diff view, inline comment quote reply
* Release editor
* Wiki editor
Some editors have attached dropzone
Screenshots:
<details>
</details>
---------
Co-authored-by: silverwind <me@silverwind.io>
2023-04-03 18:06:57 +08:00
Jason Song
d67e40684f
Improve LoadUnitConfig to handle invalid or duplicate units ( #23736 )
...
The old code just parses an invalid key to `TypeInvalid` and uses it as
normal, and duplicate keys will be kept.
So this PR will ignore invalid key and log warning and also deduplicate
valid units.
2023-04-03 16:42:38 +08:00
Hester Gong
ca905b82df
Append (comment) when a link points at a comment rather than the whole issue ( #23734 )
...
Close #23671
For the feature mentioned above, this PR append ' (comment)' to the
rendered html if it is a hashcomment.
After the PR, type in the following
```
pull request from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2
pull request from this repo:
http://localhost:3000/aaa/testA/pulls/2
issue comment from this repo:
http://localhost:3000/aaa/testA/issues/1#issuecomment-18
http://localhost:3000/aaa/testA/pulls/2#issue-9
issue comment from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue
```
Gives:
<img width="687" alt="截屏2023-03-27 13 53 06"
src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png ">
Other than the above feature, this PR also includes two other changes:
1 Right now, the render of links from file changed tab in pull request
might not be very proper, for example, if type in the following. (not
sure if this is an issue or design, if not an issue, I will revert the
changes). example on
[try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1 )
```
https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725
https://try.gitea.io/HesterG/testrepo/pulls/1/files
```
it will render the following
<img width="899" alt="截屏2023-03-24 15 41 37"
src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png ">
In this PR, skip processing the link into a ref issue if it is a link
from files changed tab in pull request
After:
type in following
```
hash comment on files changed tab:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24
files changed link:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files
```
Gives
<img width="708" alt="截屏2023-03-27 22 09 02"
src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png ">
2 Right now, after editing the comment area, there will not be tippys
attached to `ref-issue`; and no tippy attached on preview as well.
example:
https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov
In this PR, in frontend, make sure tippy is added after editing the
comment, and to the comment on preview tab
After:
https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov
2023-04-03 16:02:57 +08:00
Jason Song
977ef215fa
Rename actions unit to repo.actions and add docs for it ( #23733 )
...
I neglected that the `NameKey` of `Unit` is not only for translation,
but also configuration. So it should be `repo.actions` to maintain
consistency.
## ⚠️ BREAKING ⚠️
If users already use `actions.actions` in `DISABLED_REPO_UNITS` or
`DEFAULT_REPO_UNITS`, it will be treated as an invalid unit key.
2023-04-03 00:05:37 -04:00
wxiaoguang
c2ff2a4724
Try to catch more broken translations ( #23867 )
...
Result: #23866
Gitea should drop the ``` ` ``` as string quoter, it is not recognized
by Crowdin and it causes problem for translators.
2023-04-03 11:12:47 +08:00
GiteaBot
f020fc27e5
[skip ci] Updated translations via Crowdin
2023-04-03 00:06:56 +00:00
silverwind
af4c178452
Update JS deps ( #23853 )
...
- Update all JS dependencies
- Regenerate svgs
- Tested heatmap, swagger, citation
2023-04-02 19:47:14 -04:00
Bartlomiej Komendarczuk
d5d9c56ac2
Added close/open button to details page of milestone ( #23877 )
...
Depending on the current state, a close or open button appears.
Close https://github.com/go-gitea/gitea/issues/19083
---
2023-04-03 00:40:43 +02:00
Zettat123
bcc4c62b6c
Check IsActionsToken for LFS authentication ( #23841 )
...
Close #23824
Actions cannot fetch LFS objects from private repos because we don't
check if the user is the `ActionUser`.
2023-04-02 22:43:11 +08:00
yp05327
0ed62db213
Prefill input values in oauth settings as intended ( #23829 )
2023-04-02 21:08:34 +08:00
KN4CK3R
fbd4eaceed
Display image size for multiarch container images ( #23821 )
...
Fixes #23771
Changes the display of different architectures for multiarch images to
show the image size:
2023-04-02 17:53:37 +08:00
silverwind
f5593d08dc
Use clippie module to copy to clipboard ( #23801 )
...
Externalize clipboard copying to the
[clippie](https://github.com/silverwind/clippie ) module which I feel I
can maintain outside this repo for shared benefit with my other
projects.
The module is feature-equivalent to the previous code and has one
improvement where it sets `aria-hidden` on the fallback textarea,
preventing screen readers from picking it up. Also it support `Array` of
`content` as well to copy multiple items at once, in case it's ever
needed.
2023-04-02 17:25:36 +08:00
wxiaoguang
fcb9ef8788
Remove assertion debug code for show/hide refactoring ( #23576 )
...
When doing the refactoring:
* #22950
I added some debug mode code (assertShown) to help to catch bugs, it did
catch some bugs like:
* #23074
If it has been proved that there is no more bugs, this assertion could
be removed easily and clearly.
Feel free to decide when to remove it (feel free to convert it from
Draft to Ready for Review).
cc: @silverwind
2023-04-02 00:03:00 -04:00
GiteaBot
c9d7c83e30
[skip ci] Updated translations via Crowdin
2023-04-02 00:06:59 +00:00
silverwind
ae36113568
Remove jQuery ready usage ( #23858 )
...
Replace it with equal function of our own and enable the eslint rule to
forbid future usage.
2023-04-01 18:40:22 -04:00
wxiaoguang
eadda68ded
Fix JS error when changing PR's target branch ( #23862 )
...
Caught by @justusbunsi
An old bug from #6488
In `pullrequest_targetbranch_change`, the `data` might be empty, because
`UpdatePullRequestTarget` may respond `http.StatusNoContent`.
And the old code's `$branchTarget.text(data.base_branch);` doesn't make
sense, because in the end, the page will be always reloaded.
So, just remove the `$branchTarget.text(data.base_branch);`, everything
should be fine.
2023-04-01 22:14:38 +08:00
wxiaoguang
aa9c920980
Improve action log display with control chars ( #23820 )
...
Close #23680
Some CLI programs use "\r" and control chars to print new content in
current line.
So, the strings in one line are actually from
`\rReading...1%\rReading...5%\rReading...100%`
This PR tries to make the output better.
2023-04-01 20:57:05 +08:00
wxiaoguang
9a30b2eafa
Fix review conversation reply ( #23846 )
...
Regression of #23245
Close #23843
2023-04-01 13:50:40 +08:00
wxiaoguang
e2165854a6
Improve home page template, fix Sort dropdown menu flash ( #23856 )
...
Follow #23854
Major changes:
1. The old `<div class="ui"><div class="six wide column ...">
</div></div>` doesn't have affect any more
* So clean them, and remove other unnecessary elements/styles.
2. Add padding for narrow view.
Before
After:
2023-04-01 13:47:54 +08:00
silverwind
053df150fe
Make first section on home page full width ( #23854 )
...
Before:
<img width="1272" alt="Screenshot 2023-03-31 at 19 56 16"
src="https://user-images.githubusercontent.com/115237/229195611-4570453c-26bf-4663-865b-7e7eb9115060.png ">
After:
<img width="1270" alt="Screenshot 2023-03-31 at 20 00 14"
src="https://user-images.githubusercontent.com/115237/229195639-23841b62-38d8-4e43-8ee5-3f70cba5de6e.png ">
2023-03-31 20:58:36 -04:00
GiteaBot
366377986c
[skip ci] Updated translations via Crowdin
2023-04-01 00:06:55 +00:00
wxiaoguang
78046e5137
Fix incorrect CORS failure detection logic ( #23844 )
...
Regression of #23495
Fixes #23838
Fixes #23850
2023-03-31 11:35:48 -04:00
yp05327
6e58f8400e
Fix 500 error if there is a name conflict when edit authentication source ( #23832 )
2023-03-31 22:32:18 +08:00
Hester Gong
7df036f1a5
Use different SVG for pending and running actions ( #23836 )
...
Before:
<img width="641" alt="截屏2023-03-31 11 12 17"
src="https://user-images.githubusercontent.com/17645053/229013472-237701db-2c30-4477-a7b5-d40640361b14.png ">
<img width="576" alt="截屏2023-03-31 11 10 48"
src="https://user-images.githubusercontent.com/17645053/229013535-571aa8be-8e58-4d93-8641-9b8b5fd90108.png ">
After:
<img width="709" alt="截屏2023-03-31 11 05 44"
src="https://user-images.githubusercontent.com/17645053/229012963-ccd1e9a7-8bea-4197-aa36-865eafbf8858.png ">
<img width="528" alt="截屏2023-03-31 11 06 56"
src="https://user-images.githubusercontent.com/17645053/229012971-a7313eb6-ecd2-4da3-89a7-c20be33f4611.png ">
2023-03-31 17:24:39 +08:00
