c5c44d0951
Fix object does not exist error when checking citation file ( #28314 ) ( #28369 )
...
Backport #28314 by @yp05327
Fix #28264
`DataAsync()` will be called twice.
Caused by https://github.com/go-gitea/gitea/pull/27958 .
I'm sorry, I didn't completely remove all unnecessary codes.
Co-authored-by: yp05327 <576951401@qq.com >
2023-12-06 22:06:51 +00:00
8f2805f757
Fix incorrect default value of [attachment].MAX_SIZE ( #28373 ) ( #28376 )
...
Backport #28373 by @capvor
In the documents, the `[attachment] MAX_SIZE` default value should be 4.
Reference the source code `modules/setting/attachment.go` line 29.
Co-authored-by: capvor <capvor@sina.com >
2023-12-06 19:32:23 +00:00
5eaf91e919
Use filepath instead of path to create SQLite3 database file ( #28374 ) ( #28378 )
...
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Fix #28300
2023-12-06 11:22:18 -06:00
b7e3adc66c
Fix the runs will not be displayed bug when the main branch have no workflows but other branches have ( #28359 ) ( #28365 )
...
Backport #28359 by @lunny
The left menu will only display the default branch's workflows but the
right side will display the runs triggered by all branches' workflows.
So we cannot hide right side if default branch has no workflows.
Fix #28332
Replace #28333
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-12-06 02:28:00 -05:00
5b5f8aab19
handle repository.size column being NULL in migration v263 ( #28336 ) ( #28363 )
...
Co-authored-by: Nate Levesque <nate@thenaterhood.com >
2023-12-05 14:51:56 +00:00
fef34790bb
Convert git commit summary to valid UTF8. ( #28356 ) ( #28358 )
...
Backport #28356 by @darrinsmart
The summary string ends up in the database, and (at least) MySQL &
PostgreSQL require valid UTF8 strings.
Fixes #28178
Co-authored-by: darrinsmart <darrin@djs.to >
Co-authored-by: Darrin Smart <darrin@filmlight.ltd.uk >
2023-12-05 09:19:08 +00:00
8b590de186
Fix migration panic due to an empty review comment diff ( #28334 ) ( #28362 )
...
Backport #28334 by @lng2020
Fix #28328
```
func (p *PullRequestComment) GetDiffHunk() string {
if p == nil || p.DiffHunk == nil {
return ""
}
return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`
ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)ec1feedbf5/modules/git/diff.go (L97-L101)70063547+lng2020@users.noreply.github.com >
2023-12-05 16:58:15 +08:00
5105d2093c
Add HEAD support for rpm repo files ( #28309 ) ( #28360 )
...
Backport #28309 by @KN4CK3R
Fixes https://codeberg.org/forgejo/forgejo/issues/1810
zypper uses HEAD requests to check file existence.
https://github.com/openSUSE/libzypp/blob/HEAD/zypp/RepoManager.cc#L2549
https://github.com/openSUSE/libzypp/blob/HEAD/zypp-curl/ng/network/private/downloaderstates/basicdownloader_p.cc#L116
@ExplodingDragon fyi
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-12-05 16:24:57 +08:00
08445d5d86
Refactor template empty checks ( #28351 ) ( #28354 )
...
Backport #28351 by @KN4CK3R
Fix #28347
As there is no info how to reproduce it, I can't test it.
Fix may be `section_split.tmpl @ 126/130`.
Other changes are "empty check" refactorings.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-12-05 06:07:15 +00:00
b71d4c3ec0
Fix RPM/Debian signature key creation ( #28352 ) ( #28353 )
...
Backport #28352 by @KN4CK3R
Fixes #28324
The name parameter can't contain some characters
(https://github.com/keybase/go-crypto/blob/master/openpgp/keys.go#L680 )
but is optional. Therefore just use an empty string.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-12-05 13:42:41 +08:00
bf537adf8a
Keep profile tab when clicking on Language ( #28320 ) ( #28331 )
...
Backport #28320 by @JakobDev
Fixes https://codeberg.org/Codeberg/Community/issues/1355
Co-authored-by: JakobDev <jakobdev@gmx.de >
2023-12-03 14:54:53 +00:00
8c8c24f8eb
Fix missing issue search index update when changing status ( #28325 ) ( #28330 )
...
Backport #28325 by @brechtvl
Changing an issue status, assignee, labels or milestone without also
adding a comment would not update the index, resulting in wrong search
results.
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2023-12-03 11:43:17 +00:00
fee9c05ed3
Fix wrong link in protect_branch_name_pattern_desc ( #28313 ) ( #28315 )
...
Backport #28313 by @yp05327
The current href will link to
`https://domain/owner/repo/settings/branches/github.com/gobwas/glob `
Co-authored-by: yp05327 <576951401@qq.com >
2023-12-01 20:06:08 +08:00
e15fe85335
Read previous info from git blame ( #28306 ) ( #28310 )
...
Backport #28306 by @KN4CK3R
Fixes #28280
Reads the `previous` info from the `git blame` output instead of
calculating it afterwards.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2023-12-01 08:27:35 +01:00
4f5122a7fe
Ignore "non-existing" errors when getDirectorySize calculates the size ( #28276 ) ( #28285 )
...
Backport #28276
The git command may operate the git directory (add/remove) files in any
time.
So when the code iterates the directory, some files may disappear during
the "walk". All "IsNotExist" errors should be ignored.
2023-11-30 16:39:16 +00:00
84e65afffd
Use appSubUrl for OAuth2 callback URL tip ( #28266 ) ( #28275 )
...
Backport #28266 by @earl-warren
- When crafting the OAuth2 callbackURL take into account `appSubUrl`,
which is quite safe given that its strictly formatted.
- No integration testing as this is all done in Javascript.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1795
(cherry picked from commit 27cb6b7956136f87aa78067d9adb5a4c4ce28a24)
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
2023-11-30 00:26:47 +00:00
d2908b2794
Meilisearch: require all query terms to be matched ( #28293 ) ( #28296 )
...
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
2023-11-29 09:38:04 -06:00
24e03a125d
Fix required error for token name ( #28267 ) ( #28284 )
...
Backport #28267 by @earl-warren
- Say to the binding middleware which locale should be used for the
required error.
- Resolves https://codeberg.org/forgejo/forgejo/issues/1683
(cherry picked from commit 5a2d7966127b5639332038e9925d858ab54fc360)
Co-authored-by: Earl Warren <109468362+earl-warren@users.noreply.github.com >
Co-authored-by: Gusted <postmaster@gusted.xyz >
2023-11-29 23:00:32 +08:00
76e892317b
Fix issue will be detected as pull request when checking First-time contributor ( #28237 ) ( #28271 )
...
Backport #28237 by @yp05327
Fix #28224
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-29 02:49:33 +00:00
5001f63c07
Check for v prefix on tags for release clean name ( #28257 ) ( #28270 )
...
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-11-28 16:02:26 -06:00
6d22ca15ab
Use full width for project boards ( #28225 ) ( #28245 )
...
Backport #28225 by @denyskon
Inspired by #28182
Co-authored-by: Denys Konovalov <kontakt@denyskon.de >
2023-11-27 18:20:53 +00:00
ea9f5a57e4
Increase "version" when update the setting value to a same value as before ( #28243 ) ( #28244 )
...
Backport #28243
Setting the same value should not trigger DuplicateKey error, and the
"version" should be increased
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-28 01:58:39 +08:00
96141e4e55
Revert move installation/upgrade-from-gogs.md in 1.21 ( #28235 )
...
https://github.com/go-gitea/gitea/pull/28233#discussion_r1405539630
2023-11-27 15:28:48 +01:00
ca5f0c93c6
Fix links in docs ( #28234 ) ( #28238 )
...
Backport #28234 by @yp05327
Follow #28191
Changes:
- `(doc/administration/config-cheat-sheet.md` is incorrect:
- remove `../../`
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-27 15:36:15 +08:00
196100a07a
Change log for 1.21.1 ( #28222 )
...
As title.
---------
Co-authored-by: delvh <dev.lh@web.de >
2023-11-26 18:33:07 +08:00
bc3d8bff73
Fix comment permissions ( #28213 ) ( #28216 )
...
backport #28213
This PR will fix some missed checks for private repositories' data on
web routes and API routes.
2023-11-25 23:43:23 +00:00
7f81110461
Fix actions when tagging ( #28061 ) ( #28218 )
...
Backport #28061 by @lunny
close https://github.com/go-gitea/gitea/issues/28053
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-11-25 13:46:08 -05:00
5ed0eefc9a
Docs: Replace deprecated IS_TLS_ENABLED mailer setting in email setup ( #28205 ) ( #28208 )
...
Backport #28205 by @CodeShakingSheep
In the [docs for email
setup](https://docs.gitea.com/administration/email-setup )
`mailer.IS_TLS_ENABLED` is mentioned which was replaced by
`mailer.PROTOCOL` in release 1.18.0 according to
https://blog.gitea.com/release-of-1.18.0/ . This change wasn't reflected
in the docs for email setup. I just replaced the deprecated mailer
setting.
Co-authored-by: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com >
2023-11-25 15:41:01 +08:00
4b89c0f996
Fix some incorrect links in docs ( #28191 ) ( #28201 )
...
Backport #28191 by @yp05327
https://gitea.com/gitea/gitea-docusaurus/actions/runs/661/jobs/0#jobstep-9-39
I noticed that there are many warning logs in building docs.
It is causing 404 in docs.gitea.com now, so we need to fix it.
And there are also some other problems in v1.19 which can not be done in
this PR.
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-24 19:55:08 +00:00
7cae4dfc00
Fix delete-orphaned-repos ( #28200 ) ( #28202 )
...
Backport #28200
gitea doctor failed at checking and fixing 'delete-orphaned-repos',
because table name 'user' needs quoting to be correctly recognized by at
least PostgreSQL.
fixes #28199
2023-11-24 14:54:14 -05:00
28b8e0b43e
Use full width for PR comparison ( #28182 ) ( #28186 )
...
Backport #28182 by @lng2020
Follow-up #22844
close #28142
Before
After
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-11-23 16:14:20 +00:00
23838c2c2e
Make CORS work for oauth2 handlers ( #28184 ) ( #28185 )
...
Backport #28184
Fix #25473
Although there was `m.Post("/login/oauth/access_token", CorsHandler()...`,
it never really worked, because it still lacks the "OPTIONS" handler.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-23 22:27:00 +08:00
f9763f1366
Fix missing buttons ( #28179 ) ( #28181 )
...
Backport #28179 by @lng2020
fix #28173
regression #25948
That PR is supposed to only change the style but somehow delete a code
snippet. See the
diff(https://github.com/go-gitea/gitea/pull/25948/files#diff-7c36d66fe058f4ff9f2beaac73cf710dca45b350d0dd98daf806828a4745fe62L125-L129 )
for details.
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-23 12:24:34 +01:00
a2314ca9c5
Revert "Fix EOL handling in web editor" ( #28101 ) ( #28172 )
...
Backport #28101 by @lng2020
Reverts go-gitea/gitea#27141
close #28097
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-11-22 18:06:13 +08:00
994ba35f11
Fix swagger title ( #28164 ) ( #28167 )
...
Backport #28164 by @yp05327
Don't know why there's a `.` behind. 🤔
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-22 09:06:38 +00:00
447422fe27
Fix the description about the default setting for action in quick start document ( #28160 ) ( #28168 )
...
Backport #28160 by @yp05327
Since #27054 , Actions are enabled by default. so we should also edit the
document. 😃
ps: I think this should be backport to 1.21.0.
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-22 16:46:11 +08:00
9bfee5014b
Add guide page to actions when there's no workflows ( #28145 ) ( #28153 )
...
Backport #28145 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-22 02:29:54 +00:00
7128929a0d
Do not display search box when there's no packages yet ( #28146 ) ( #28159 )
...
Backport #28146 by @yp05327
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-22 10:07:13 +08:00
efcbaf8fa8
Fix no ActionTaskOutput table waring ( #28149 ) ( #28152 )
...
Backport #28149 by @yp05327
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:
It comes from:
The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
Co-authored-by: yp05327 <576951401@qq.com >
2023-11-21 22:23:57 +08:00
c997e90738
Fix empty action run title ( #28113 ) ( #28148 )
...
Backport #28113 by @lunny
Fix #27901
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-11-21 04:28:14 +00:00
ffab076b72
Use "is-loading" to avoid duplicate form submit for code comment ( #28143 ) ( #28147 )
...
Backport #28143 by @wxiaoguang
Compare by ignoring spaces:
https://github.com/go-gitea/gitea/pull/28143/files?diff=split&w=1
When the form is going to be submitted, add the "is-loading" class to
show an indicator and avoid user UI events.
When the request finishes (success / error), remove the "is-loading"
class to make user can interact the UI.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-21 12:02:58 +08:00
117d9a117f
Fix typo in packages.cleanup.success ( #28133 ) ( #28136 )
...
Backport #28133 by @wolfogre
Follow
https://github.com/go-gitea/gitea/pull/28129#discussion_r1398971596
Co-authored-by: Jason Song <i@wolfogre.com >
2023-11-20 13:43:40 +00:00
f8c5f202b7
Add missing packages.cleanup.success ( #28129 ) ( #28132 )
...
Backport #28129 by @wolfogre
Co-authored-by: Jason Song <i@wolfogre.com >
2023-11-20 04:39:54 -05:00
7213506680
Update docs for docusaurus v3 ( #28126 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2023-11-20 00:24:50 -05:00
1f82be6604
Fix Matrix and MSTeams nil dereference ( #28089 ) ( #28105 )
...
Backport #28089 by @KN4CK3R
Fixes #28088
Fixes #28094
Added missing tests.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-11-17 13:50:45 +00:00
56bedf2bcc
Change default size of attachments and repo files ( #28100 ) ( #28106 )
...
Backport #28100 by @lng2020
https://github.com/go-gitea/gitea/pull/27946 forgets to change them in
code. Sorry about that.
Co-authored-by: Nanguan Lin <70063547+lng2020@users.noreply.github.com >
2023-11-17 13:30:42 +01:00
f7567f798d
Fix incorrect pgsql conn builder behavior ( #28085 ) ( #28098 )
...
Backport #28085 by @wxiaoguang
Fix #28083 and fix the tests
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-17 10:45:04 +00:00
93ede4bc83
Fix permissions for Token DELETE endpoint to match GET and POST ( #27610 ) ( #28099 )
...
Backport #27610 by @evantobin
Fixes #27598
In #27080 , the logic for the tokens endpoints were updated to allow
admins to create and view tokens in other accounts. However, the same
functionality was not added to the DELETE endpoint. This PR makes the
DELETE endpoint function the same as the other token endpoints and adds
unit tests
Co-authored-by: Evan Tobin <me@evantob.in >
2023-11-17 12:24:16 +08:00
9f63d27ec4
Fix system config cache expiration timing ( #28072 ) ( #28090 )
...
Backport #28072
To avoid unnecessary database access, the `cacheTime` should always be
set if the revision has been checked.
Fix #28057
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-16 21:37:57 +08:00
073d8c50dd
Restricted users only see repos in orgs which their team was assigned to ( #28025 ) ( #28051 )
...
Backport #28025 by @6543
---
*Sponsored by Kithara Software GmbH*
Co-authored-by: 6543 <m.huber@kithara.com >
2023-11-14 16:44:46 +01:00
