Commit Graph
100 Commits
Author SHA1 Message Date
Lunny Xiao fdbb0b4762 fix gravatar disable bug (#22336) 2023-01-04 16:19:56 +08:00
Lunny Xiaoandwxiaoguang efa708501b Use git command instead of exec.Cmd in blame (#22098)
extract from #18147

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-01-03 16:17:13 +08:00
c59e1537a8 Display error log when a modified template has an error so that it could recovery when the error fixed (#22261)
A drawback is the previous generated template has been cached, so you
cannot get error in the UI but only from log

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: delvh <dev.lh@web.de>
2023-01-03 15:17:36 +08:00
Lunny Xiao a1c30740bb Fix get system setting bug when enabled redis cache (#22295)
Fix #22281

In #21621 , `Get[V]` and `Set[V]` has been introduced, so that cache
value will be `*Setting`. For memory cache it's OK. But for redis cache,
it can only store `string` for the current implementation. This PR
revert some of changes of that and just store or return a `string` for
system setting.
2023-01-02 00:06:52 +08:00
Lunny XiaoandKN4CK3R 9c8fc7f677 Fix bug of DisableGravatar default value (#22296)
#18058 made a mistake. The disableGravatar's default value depends on
`OfflineMode`. If it's `true`, then `disableGravatar` is true, otherwise
it's `false`. But not opposite.

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2023-01-01 20:19:23 +08:00
Lunny Xiao 2bbf9e7302 Upgrade go-chi to v5.0.8 (#22304) 2023-01-01 11:23:26 +01:00
ca67c5a8a7 refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 13:53:28 +08:00
Lunny Xiao 90237d8abd Add more test directory to exclude dir of air, remove watching templates from air include dir because gitea has internal mechanism (#22246)
Since #20218 introduced internal watching template, template watching
should be removed from `air`. This will prevent restart the whole server
once the template files changed to speed up developing when using `make
watch`.

To ensure `make watch` will reuse template watching, this PR introduced
a new ENV `GITEA_RUN_MODE` to make sure `make watch` will always run in
a dev mode of Gitea so that template watching will open.

This PR also added more exclude testdata directories.
2022-12-27 14:00:34 +08:00
Lunny Xiao 3bd49f7801 [skip ci] Updated licenses and gitignores 2022-12-25 00:19:36 +00:00
Lunny Xiao 2b0b56319e Improve testing for pgsql empty repository (#22223) 2022-12-23 12:34:51 -06:00
Lunny Xiao 7bf7c13b64 Frontport 1.17.4 changelog (#22216) 2022-12-22 09:36:01 -06:00
Lunny Xiao 8c1bb77437 Remove test session cache to reduce possible concurrent problem (#22199) 2022-12-22 21:09:35 +08:00
Lunny Xiao 495b8b3635 Fix delete secret modal (#22187)
Fix #22181
2022-12-20 12:18:15 -06:00
Lunny Xiao 1b32ed014a remove duplicated read file code (#22042)
Merge the duplicated read file code as one function in reading text file
and readme file.
2022-12-14 18:11:11 +08:00
Lunny Xiao 87c64f655a Fix permission check on issue/pull lock (#22110)
Fix #21826
2022-12-12 23:02:51 +08:00
Lunny Xiao 36a2d2f919 Add a simple test for external renderer (#20033)
Fix #16402
2022-12-12 20:45:21 +08:00
Lunny Xiao 6398ca745a refactor bind functions based on generics (#22055) 2022-12-12 16:09:26 +08:00
Lunny Xiao 705fbb46d5 Fix permission check on http push 2022-12-12 14:52:00 +08:00
Lunny Xiaoanddelvh 003b4e209c Allow disable code tab (#20805)
I know some users created a repository in an organization but just use
issues and projects to handle the whole organizations issues. So that
`Code` could be disabled per repository.

<img width="1148" alt="image"
src="https://user-images.githubusercontent.com/81045/184792075-346cb508-b620-4adb-bc9a-cba76fdcb294.png">

It could also become a wiki repository.

<img width="1173" alt="image"
src="https://user-images.githubusercontent.com/81045/184792324-e15c6f68-35c0-4105-ab77-83585ce53672.png">

Co-authored-by: delvh <dev.lh@web.de>
2022-12-12 13:29:27 +08:00
Lunny Xiao 3e8285b824 Use multi reader instead to concat strings (#22099)
extract from #20326
2022-12-12 11:03:54 +08:00
Lunny Xiao c9ef03af65 Fix wrong default value for update checker on app.example.ini (#22084) 2022-12-11 16:08:01 -06:00
Lunny Xiao 68704532c2 Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
Lunny XiaoandKN4CK3R 36cbaec54c Fix ListBranches to handle empty case (#21921)
Fix #21910

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2022-12-04 08:57:17 +00:00
0a7d3ff786 refactor some functions to support ctx as first parameter (#21878)
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Lauris BH <lauris@nix.lv>
2022-12-03 10:48:26 +08:00
Lunny Xiao df676a47d0 Remove session in api tests (#21984)
It's no meaning to request an API route with session.
2022-12-01 22:39:42 -05:00
Lunny Xiaoandsilverwind f7ade6de7c Fix generate index failure possibility on postgres (#21998)
@wxiaoguang Please review

Co-authored-by: silverwind <me@silverwind.io>
2022-12-02 11:15:36 +08:00
Lunny XiaoandLauris BH b2c4870481 Fix parallel creating commit status bug with tests (#21911)
This PR is a follow up of #21469

Co-authored-by: Lauris BH <lauris@nix.lv>
2022-12-01 00:41:49 +08:00
Lunny Xiao 324d6711da permission check 2022-11-25 17:48:48 +08:00
Lunny Xiao 3e8de17db3 permission 2022-11-25 17:48:48 +08:00
Lunny Xiao 52b32c37ad Use a new name for bots 2022-11-25 17:48:48 +08:00
Lunny Xiao 45afa0ee9f Support most github's sdk 2022-11-25 17:48:48 +08:00
Lunny Xiao 2ecb59c092 rename builds -> bots 2022-11-25 17:48:48 +08:00
Lunny Xiao c61ac24c1c Fix bug 2022-11-25 17:48:48 +08:00
Lunny Xiao 88b0ab89d0 Gitea bot will not fire the events otherwise it may causes a forever loop 2022-11-25 17:48:48 +08:00
Lunny Xiao f57e6999a2 Remove unused file 2022-11-25 17:48:47 +08:00
Lunny Xiao f4bbd534b9 Allow gitea bot as trigger user 2022-11-25 17:48:47 +08:00
Lunny Xiao 110072a8d4 Fix log 2022-11-25 17:48:47 +08:00
Lunny Xiao 9a45572ce2 Support bot site 2022-11-25 17:48:47 +08:00
Lunny Xiao fc2c70033a Add default bot url 2022-11-25 17:48:47 +08:00
Lunny Xiao aa09eb63e1 Support bot user 2022-11-25 17:48:47 +08:00
Lunny Xiao 1ddf3b2d12 Support push via gitea bot 2022-11-25 17:48:47 +08:00
Lunny Xiao f55253e81d Support clone private repository in runner 2022-11-25 17:48:47 +08:00
Lunny Xiao d8b401ab06 Fix virutal user 2022-11-25 17:48:47 +08:00
Lunny Xiao 339ddf4c5f Virtual user gitea-bots 2022-11-25 17:48:46 +08:00
Lunny Xiao 82c6fc2217 Add commit status for push event 2022-11-25 17:48:46 +08:00
Lunny Xiao 0bc995889f Finish bots events notifications 2022-11-25 17:48:46 +08:00
Lunny Xiao e5b835cf52 current page 2022-11-25 17:48:46 +08:00
Lunny Xiao 34a1bb2c20 encrypt master key 2022-11-25 17:48:46 +08:00
Lunny Xiao b8c7ea782c Fix bug 2022-11-25 17:48:46 +08:00
Lunny Xiao b00cd8de90 Fix bug 2022-11-25 17:48:46 +08:00
Lunny Xiao b5520f098f Some improvements 2022-11-25 17:48:46 +08:00
Lunny Xiao e7d5c99b42 Fix lint 2022-11-25 17:48:46 +08:00
Lunny Xiao 8ec691f3ce Almost finished 2022-11-25 17:48:46 +08:00
Lunny Xiao 08b463a308 Fix duplicated alert 2022-11-25 17:48:46 +08:00
Lunny Xiao 5b55fd0d36 org secrets 2022-11-25 17:48:46 +08:00
Lunny Xiao fa5b8e9eba org secrets 2022-11-25 17:48:46 +08:00
Lunny Xiao da981db596 finish adding and deleting secret for repository settting 2022-11-25 17:48:46 +08:00
Lunny Xiao e43e3f9518 improve UI 2022-11-25 17:48:46 +08:00
Lunny Xiao ab4f539453 add models and services 2022-11-25 17:48:46 +08:00
Lunny Xiao a5a112425b Support clone private repository from runner 2022-11-25 17:48:45 +08:00
Lunny Xiao b65e263f92 Fix filter count 2022-11-25 17:48:45 +08:00
Lunny Xiao 3518c098b9 Improve ui for builds 2022-11-25 17:48:45 +08:00
Lunny Xiao d69423a3b0 UI improvement 2022-11-25 17:48:45 +08:00
Lunny Xiao 57cc7bf823 improve UI 2022-11-25 17:48:45 +08:00
Lunny Xiao 7e01f8ce66 Fix bug 2022-11-25 17:48:45 +08:00
Lunny Xiao 243c1e5134 Add workflow 2022-11-25 17:48:45 +08:00
Lunny Xiao f75a4abc5d build UI 2022-11-25 17:48:45 +08:00
Lunny Xiao 482832da76 delete unused structs 2022-11-25 17:48:45 +08:00
Lunny Xiao db02603882 Fix bug 2022-11-25 17:48:44 +08:00
Lunny Xiao b84aa84a0f Fix template 2022-11-25 17:48:44 +08:00
Lunny Xiao 931d8c2c21 add runners management ui 2022-11-25 17:48:43 +08:00
Lunny Xiao 2ea693cdd2 update template 2022-11-25 17:48:43 +08:00
Lunny Xiao a1bd3a8932 Fix build 2022-11-25 17:48:43 +08:00
Lunny Xiao 2c4f6fd42f add most tables 2022-11-25 17:48:43 +08:00
Lunny Xiao 5a479bb034 Add builds UI 2022-11-25 17:48:43 +08:00
Lunny Xiao 7732392a96 Add bots 2022-11-25 17:48:33 +08:00
34283a74e8 Allow detect whether it's in a database transaction for a context.Context (#21756)
Fix #19513

This PR introduce a new db method `InTransaction(context.Context)`,
and also builtin check on `db.TxContext` and `db.WithTx`.
There is also a new method `db.AutoTx` has been introduced but could be used by other PRs.

`WithTx` will always open a new transaction, if a transaction exist in context, return an error.
`AutoTx` will try to open a new transaction if no transaction exist in context.
That means it will always enter a transaction if there is no error.

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: 6543 <6543@obermui.de>
2022-11-12 21:18:50 +01:00
Lunny XiaoandAndrew Thornton 385462d36c Fix dashboard ignored system setting cache (#21621)
This is a performance regression from #18058

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Andrew Thornton <art27@cantab.net>
2022-11-10 14:43:53 +08:00
Lunny Xiaoandsilverwind 2ebab42934 Move svg html render to modules/svg (#21716)
Also added more checks for the render function.

Co-authored-by: silverwind <me@silverwind.io>
2022-11-08 23:13:58 +08:00
Lunny Xiao 91c7a3e66f Fix tests on migrations (#21705) 2022-11-08 12:07:46 +08:00
Lunny Xiao 57df0f116a Revert "[skip ci] Updated translations via Crowdin" (#21689)
This reverts commit cb4473692f.
2022-11-06 11:29:52 +08:00
Lunny Xiao 44cc684a50 [skip ci] Updated translations via Crowdin 2022-11-03 00:19:50 +00:00
Lunny Xiao e72acd5e5b Split migrations folder (#21549)
There are too many files in `models/migrations` folder so that I split
them into sub folders.
2022-11-02 16:54:36 +08:00
Lunny Xiao 9a70a12a34 Merge db.Iterate and IterateObjects (#21641)
These two functions are similiar, merge them.
2022-10-31 23:51:14 +08:00
Lunny Xiao f337c32e86 Add index for hook_task table (#21545)
Since `hook_id` and `uuid` will become a search condition column. It's
better to add some index for them.
2022-10-28 13:05:39 +02:00
Lunny Xiaoanddelvh 5e8e3ecbeb Fix issues count bug (#21557)
fix #19349 , #19505

Co-authored-by: delvh <dev.lh@web.de>
2022-10-25 14:47:46 +02:00
Lunny Xiao 4eeea7b30e Update binding to fix bugs (#21556)
Fix #19698
2022-10-23 13:50:48 +03:00
Lunny Xiaoandzeripath 16cbd5b59c Fix generating compare link (#21519)
Fix #6318

Co-authored-by: zeripath <art27@cantab.net>
2022-10-21 16:39:26 +08:00
Lunny Xiaoand6543 f0182d8840 Fix read system configuration bug when installing (#21489)
Fix https://github.com/go-gitea/gitea/pull/18058#issuecomment-1280944311

Co-authored-by: 6543 <6543@obermui.de>
2022-10-18 23:16:58 +08:00
Lunny Xiao 683c9af89f [skip ci] Updated translations via Crowdin 2022-10-17 00:20:53 +00:00
Lunny Xiao f860a6d2e4 Add system setting table with cache and also add cache supports for user setting (#18058) 2022-10-17 07:29:26 +08:00
1428877c37 log real ip of requests from ssh (#21216)
Partially fix #21213.

This PR will get client IP address from SSH_CONNECTION env which should
be the first field of that. And deliver it to the internal API so Gitea
routers could record the real IP from SSH requests.

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: zeripath <art27@cantab.net>
2022-10-11 16:57:37 +08:00
Lunny XiaoandLauris BH a196302472 Fix template bug of admin monitor (#21208)
Fix #21207

Co-authored-by: Lauris BH <lauris@nix.lv>
2022-09-19 20:53:39 -04:00
Lunny Xiaoandzeripath bc4cce138a Fix delete user missed some comments (#21067)
There is a mistake in the batched delete comments part of DeleteUser which causes some comments to not be deleted

The code incorrectly updates the `start` of the limit clause resulting in most comments not being deleted.

```go
			if err = e.Where("type=? AND poster_id=?", issues_model.CommentTypeComment, u.ID).Limit(batchSize, start).Find(&comments); err != nil {
```

should be:

```go
			if err = e.Where("type=? AND poster_id=?", issues_model.CommentTypeComment, u.ID).Limit(batchSize, 0).Find(&comments); err != nil {
```

Co-authored-by: zeripath <art27@cantab.net>
2022-09-05 19:41:16 +03:00
Lunny Xiao d74390ee39 [skip ci] Updated translations via Crowdin 2022-09-01 00:20:54 +00:00
Lunny Xiaoandtechknowlogick de5b8cfad8 Fix missed sort bug (#20996)
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2022-08-31 14:15:12 -04:00
Lunny Xiao b0c62846f1 Fix download archiver of a commit (#20962) 2022-08-26 15:07:06 +02:00
Lunny Xiaoand6543 1d8543e7db Move some files into models' sub packages (#20262)
* Move some files into models' sub packages

* Move functions

* merge main branch

* Fix check

* fix check

* Fix some tests

* Fix lint

* Fix lint

* Revert lint changes

* Fix error comments

* Fix lint

Co-authored-by: 6543 <6543@obermui.de>
2022-08-25 10:31:57 +08:00
Lunny XiaoandGusted 999392f6a5 Fix owners cannot create organization repos bug (#20841)
* Fix owners cannot create organization repos bug

* Fix api

* Update routers/api/v1/org/team.go

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
2022-08-18 11:58:21 +03:00
Lunny Xiao 5d0f643461 Fix migration file name (#20843) 2022-08-18 13:38:59 +08:00