ff7057a46d
Change button text for commenting and closing an issue at the same time ( #23135 ) ( #23182 )
...
Backport #23135
Close #10468
Without SimpleMDE/EasyMDE, using Simple Textarea, the button text could
be changed when content changes.
After introducing SimpleMDE/EasyMDE, there is no code for updating the
button text.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-02-28 17:54:24 -05:00
6c6a7e7d97
Avoid too long names for actions ( #23162 ) ( #23190 )
...
Backport #23162
The name of the job or step comes from the workflow file, while the name
of the runner comes from its registration. If the strings used for these
names are too long, they could cause db issues.
Co-authored-by: Jason Song <i@wolfogre.com >
2023-02-28 13:42:40 +01:00
111c509287
Add InsecureSkipVerify to Minio Client for Storage ( #23166 ) ( #23177 )
...
Backport #23166
Allows using Minio with untrusted certificates
Closes #23128
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-02-28 00:29:17 +02:00
9d7ef0ad63
Add word-break to sidebar-item-link ( #23146 ) ( #23180 )
...
Backport #23146
Fixes https://github.com/go-gitea/gitea/issues/22953
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: delvh <leon@kske.dev >
2023-02-27 15:59:36 -05:00
9aae54c81f
Remove useless comment in #23114 ( #23173 ) ( #23175 )
...
Backport #23173
The `isAdmin` param is no longer used so the comment should be removed.
https://github.com/go-gitea/gitea/blob/d27d36f2f4dd389050e613967ad2a5d02d250acc/routers/web/explore/repo.go#L36-L37
Co-authored-by: Zettat123 <zettat123@gmail.com >
2023-02-27 22:43:15 +08:00
1bc4ffc337
Return 404 instead of 403 if user can not access the repo ( #23155 ) ( #23158 )
...
Backport #23155
Fixes https://github.com/go-gitea/gitea/issues/23150
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-26 20:20:44 +08:00
27879bc45e
Fix DBConsistency checks on MSSQL ( #23132 ) ( #23134 )
...
Backport #23132
Unfortunately xorm's `builder.Select(...).From(...)` does not escape the
table names. This is mostly not a problem but is a problem with the
`user` table.
This PR simply escapes the user table. No other uses of `From("user")`
where found in the codebase so I think this should be all that is
needed.
Fix #23064
Signed-off-by: Andrew Thornton <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2023-02-25 23:25:58 +08:00
Yarden Shoham and GitHub
a3694b6989
Fix secrets overview page missing from docs sidebar ( #23143 ) ( #23145 )
...
Backport #23143
There was a warning while building the docs: `Building sites … WARN
2023/02/25 08:56:37
"/workspace/gitea/docs/content/doc/secrets/overview.en-us.md:1:1":
duplicate menu entry with identifier "overview" in menu "sidebar"`.
### Before
### After
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-02-25 13:30:32 +02:00
28625fba5b
Redirect to the commit page after applying patch ( #23056 ) ( #23127 )
...
Backport #23056
Fixes https://github.com/go-gitea/gitea/issues/22621
Co-authored-by: yp05327 <576951401@qq.com >
2023-02-24 22:43:26 -05:00
7c3196ceac
Avoid warning for system setting when start up ( #23054 ) ( #23116 )
...
Backport #23054
Partially fix #23050
After #22294 merged, it always has a warning log like `cannot get
context cache` when starting up. This should not affect any real life
but it's annoying. This PR will fix the problem. That means when
starting up, getting the system settings will not try from the cache but
will read from the database directly.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2023-02-24 16:46:11 -05:00
80c1264f4b
Show empty repos in Admin Repository Management page ( #23114 ) ( #23130 )
...
Backport #23114
The **Admin Repository Management** page and the **Explore Repository**
page both use the `RenderRepoSearch` function. In this function, the
`OnlyShowRelevant` search option is `true` when querying repositories
for admin page.
https://github.com/go-gitea/gitea/blob/edf98a2dc30956c8e04b778bb7f1ce55c14ba963/routers/web/explore/repo.go#L99-L115
Refer to
[#19361 ](https://github.com/go-gitea/gitea/pull/19361/files#diff-8058dfb85557010e0592d586675ec62ce406af7068e6311f39c160deac37f149R497 ),
the repositories with `is_empty=true` will be hidden if
`OnlyShowRelevant` is `true`.
Administrators should be able to see all repositories. So
`OnlyShowRelevant` shouldn't be set to `true` .
Co-authored-by: Zettat123 <zettat123@gmail.com >
Co-authored-by: Andrew Thornton <art27@cantab.net >
2023-02-24 20:17:21 +00:00
5beb29ad35
Fix height for sticky head on large screen on PR page ( #23111 ) ( #23123 )
...
Backport #23111
Right now on the PR 'File Change' Tab, the file title header sticky to
the top on large screens has wrong height, resulting in wrong ui
behavior when scrolling down. This PR is to fix this.
Before:
<img width="964" alt="截屏2023-02-24 17 12 29"
src="https://user-images.githubusercontent.com/17645053/221140409-025c4a84-6bbe-4b5b-a13f-bd2b79063522.png ">
After:
<img width="1430" alt="截屏2023-02-24 21 10 12"
src="https://user-images.githubusercontent.com/17645053/221186750-0344d652-4610-4a90-a4c0-7f6269f950d6.png ">
Co-authored-by: HesterG <hestergong@gmail.com >
2023-02-24 14:47:48 +00:00
Yarden Shoham and GitHub
27e307142b
Fix db.Find bug ( #23115 ) ( #23119 )
...
Backport #23115
Caused by #20821
Fix #23110
2023-02-24 14:05:36 +00:00
e02e752f68
Fix nil context in RenderMarkdownToHtml ( #23092 ) ( #23108 )
...
Backport #23092
Fix #23082 .
This bug is caused by a nil context in
https://github.com/go-gitea/gitea/issues/23082#issuecomment-1441276546 .
Co-authored-by: Zettat123 <zettat123@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-24 21:17:03 +08:00
5ddf67a9c2
Make issue meta dropdown support Enter, confirm before reloading ( #23014 ) ( #23102 )
...
Backport #23014
As the title. Label/assignee share the same code.
* Close #22607
* Close #20727
Also:
* partially fix for #21742 , now the comment reaction and menu work with
keyboard.
* partially fix for #17705 , in most cases the comment won't be lost.
* partially fix for #21539
* partially fix for #20347
* partially fix for #7329
### The `Enter` support
Before, if user presses Enter, the dropdown just disappears and nothing
happens or the window reloads.
After, Enter can be used to select/deselect labels, and press Esc to
hide the dropdown to update the labels (still no way to cancel ....
maybe you can do a Cmd+R or F5 to refresh the window to discard the
changes .....)
This is only a quick patch, the UX is still not perfect, but it's much
better than before.
### The `confirm` before reloading
And more fixes for the `reload` problem, the new behaviors:
* If nothing changes (just show/hide the dropdown), then the page won't
be reloaded.
* If there are draft comments, show a confirm dialog before reloading,
to avoid losing comments.
That's the best effect can be done at the moment, unless completely
refactor these dropdown related code.
Screenshot of the confirm dialog:
<details>
</details>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Brecht Van Lommel <brecht@blender.org >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-24 17:40:36 +08:00
4d3e2b23b8
Fix SyncOnCommit always return false in API of push_mirrors ( #23088 ) ( #23100 )
...
Backport #23088
Fix : #22990
---
Before, the return value of the api is always false,regrardless of
whether the entry of `sync_on_commit` is true or false.
I have confirmed that the value of `sync_on_commit` dropped into the
database is correct.
So, I think it is enough to make some small changes.
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-24 14:36:25 +08:00
ddf61373f6
Add wrapper to author to avoid long name ui problem ( #23030 ) ( #23098 )
...
Backport #23030
This PR is a possible solution for issue #22866 . Main change is to add a
`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now. Which will work like below:
<img width="1183" alt="2023-02-21 11 57 53"
src="https://user-images.githubusercontent.com/17645053/220244146-3d47c512-33b6-4ed8-938e-de0a8bc26ffb.png ">
<img width="417" alt="2023-02-21 11 58 43"
src="https://user-images.githubusercontent.com/17645053/220244154-1ea0476b-9d1c-473a-9917-d3216860f9a9.png ">
And `title` is added to the wrapper like it did in message wrapper. So
the full author name will show on hover.
Co-authored-by: HesterG <hestergong@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2023-02-24 10:45:18 +08:00
b4ed3f07e4
Fix commit name in Apply Patch page ( #23086 ) ( #23099 )
...
Backport #23086
Fixes
https://github.com/go-gitea/gitea/issues/22621#issuecomment-1439309200
Co-authored-by: yp05327 <576951401@qq.com >
2023-02-24 08:47:35 +08:00
aff432b197
Nest metadata in refactoring docs ( #23087 ) ( #23091 )
...
Backport #23087
Whitespace was missing from refactoring docs metadata.
backport label applied so it is included in versioned docs.
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2023-02-23 03:39:30 -05:00
0ac3be1482
Improve accessibility for issue comments ( #22612 ) ( #23083 )
...
Backport #22612
### Preamble
Gitea is an extremely great and smart solution perfectly suitable for
smaller systems and self-hosted Git-powered setups. However, there is a
group of people who have indredible difficulties in using Gitea,
rendering it useless in many cases. Those people are blind developers
using [screen readers](https://en.wikipedia.org/wiki/Screen_reader ).
Unfortunately, the frontend framework is super convoluted, and Go
templates don’t allow accessibility improvements in a straightforward
way. As a blind developer myself, I'm trying to start fixing smaller
accessibility quirks with intention to go deeper and eventually, alone
or not, make Gitea at least mostly accessible for screen reader users.
### What This Fix Does
My blind fellows and me navigate webpages not very similarly to how a
sighted person does it. For instance, we love semantic HTML markup like
headings, lists, tables etc. because our screen readers allow us to jump
by those landmarks with a single keypress.
Currently in Gitea issue comments are not marked up with headings. I'm
trying to fix this by adding an appropriate
[ARIA](https://www.w3.org/WAI/standards-guidelines/aria/ ) role for
comment header and also by enclosing the comment itself in a semantical
article element.
Co-authored-by: Andre Polykanine <ap@oire.me >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-02-23 16:32:15 +08:00
75eaf99076
Wrap unless-check in docker manifests ( #23079 ) ( #23081 )
...
Backport #23079
Should fix the following:
> failed to render template: Evaluation error: Helper 'unless' called
with wrong number of arguments, needed 2 but got 3
https://go.dev/play/p/h7bt7MWKTcv
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: John Olheiser <john.olheiser@gmail.com >
2023-02-23 01:34:47 +01:00
Yarden Shoham and GitHub
6840a8ccfc
Add comment marking the end of database migrations in 1.19.0 ( #22975 )
...
There will be no more migrations in `1.19.0`
---------
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-02-20 10:30:36 +08:00
feed1ff38f
Rename "People" to "Members" in organization page and use a better icon ( #22960 )
...
`member` is how it's named in the code
Closes #22931
Before | After
--- | ---
|
---------
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: delvh <leon@kske.dev >
2023-02-18 21:41:31 +08:00
Yarden Shoham and GitHub
ce4fd95233
Use native error checking with exec.ErrDot ( #22735 )
...
This was meant to land in #22073 but was blocked until #22732 was merged
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-02-03 17:22:11 +00:00
Yarden Shoham and GitHub
b91bc68092
Remove address from DCO ( #22595 )
...
I copy-pasted from https://developercertificate.org/
2023-01-24 18:52:38 +00:00
Yarden Shoham and GitHub
f417157bdd
Split default gitpod view to include all tasks ( #22555 )
...
It was showing only the `docs` process
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-01-20 13:46:33 -06:00
Yarden Shoham and GitHub
e763fab685
Fix pull request API field closed_at always being null ( #22482 )
...
Fix #22480
2023-01-17 11:42:32 +00:00
Yarden Shoham and GitHub
3b804ff76c
Fix "remember this device" case ( #22388 )
...
In the title case, it should be "Remember This Device"
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-01-10 17:43:54 +08:00
Yarden Shoham and GitHub
b994b2ea9c
Fix due date rendering the wrong date in issue ( #22302 )
...
Previously, the last minute of the chosen date caused bad timezone
rendering.
For example, I chose January 4th, 2023.
### Before
```html
<time data-format="date" datetime="Wed, 04 Jan 2023 23:59:59 +0000">January 5, 2023</time>
```
### After
```html
<time data-format="date" datetime="2023-01-04">January 4, 2023</time>
```
---
Closes #21999
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2023-01-02 10:49:05 +08:00
Yarden Shoham and GitHub
22a6e97597
Update standard copyright header to use a placeholder year ( #22254 )
2022-12-27 11:51:23 -06:00
Yarden Shoham and GitHub
9745c33e9e
Remove unnecessary whitespace in snapcraft.yaml ( #22090 )
...
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-12-10 08:31:16 -06:00
Yarden Shoham and GitHub
77f50356f4
Remove useless "Cancel" buttons ( #21872 )
...
* Continues #21381
These buttons have no real use. To cancel, one would simply navigate
away.
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-12-05 20:38:34 +08:00
6c8ff32511
Add updated_at field to PullReview API object ( #21812 )
...
* Closes #19997
Adds an `updated_at` time field to the `PullReview` API object to
specify when the pull request review's state changed.
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-11-15 11:33:52 +02:00
Yarden Shoham and GitHub
de6dfb7141
Remove href="javascript:;" in "save topics (Done)" button ( #21813 )
...
To use an anchor tag as a button and have it be accessible I added
`role="button" tabindex="0"`,
[reference](https://stackoverflow.com/a/10510353/7414734 ).
* Closes #19912
2022-11-15 10:10:50 +08:00
6f3efdfe11
Render number of commits in repo page in a user friendly way ( #21786 )
...
Use `JsPrettyNumber` to render the number of commits
* Closes #12637
### Before
### After
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
2022-11-13 00:55:19 -05:00
cb83288530
Add attention blocks within quote blocks for Note and Warning ( #21711 )
...
For each quote block, the first `**Note**` or `**Warning**` gets an icon
prepended to it and its text is colored accordingly. GitHub does this
(community/community#16925 ). [Initially requested on
Discord.](https://discord.com/channels/322538954119184384/322538954119184384/1038816475638661181 )
### Before
### After
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: silverwind <me@silverwind.io >
2022-11-09 02:11:26 +02:00
e3a7f15791
Add "Copy" button to file view of raw text ( #21629 )
...
If a raw text file is displayed, a copy button of the text is enabled.
* Closes #12866
### Before
### After
#### Rendered files and binaries have their button disabled
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2022-11-04 15:33:50 -04:00
5f0cbb3e80
Make rss/atom identifier globally unique ( #21550 )
...
This field should be globally unique.
[RSS
reference](https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt ).
### Before
```xml
<item>
<title>abc opened issue <a href="https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1">abc/defg#1</a> ;</title>
<link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1 </link>
<description>1#Colors</description>
<content:encoded><![CDATA[<p><code>#FF0000<span class="color-preview" style="background-color: #FF0000"></span></code></p>
]]></content:encoded>
<author>abc</author>
<guid>2</guid>
<pubDate>Mon, 17 Oct 2022 16:06:08 +0000</pubDate>
</item>
<item>
<title>abc created repository <a href="https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg">abc/defg</a> ;</title>
<link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg </link>
<description></description>
<author>abc</author>
<guid>1</guid>
<pubDate>Mon, 17 Oct 2022 16:05:43 +0000</pubDate>
</item>
```
### After
```xml
<item>
<title>abc opened issue <a href="https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1">abc/defg#1</a> ;</title>
<link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1 </link>
<description>1#Colors</description>
<content:encoded><![CDATA[<p><code>#FF0000<span class="color-preview" style="background-color: #FF0000"></span></code></p>
]]></content:encoded>
<author>abc</author>
<guid>2: https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg/issues/1 </guid>
<pubDate>Mon, 17 Oct 2022 16:06:08 +0000</pubDate>
</item>
<item>
<title>abc created repository <a href="https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg">abc/defg</a> ;</title>
<link>https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg </link>
<description></description>
<author>abc</author>
<guid>1: https://3000-yardenshoham-gitea-3pzuhkduf6t.ws-eu72.gitpod.io/abc/defg </guid>
<pubDate>Mon, 17 Oct 2022 16:05:43 +0000</pubDate>
</item>
```
* Fixes #21542
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2022-10-28 09:49:04 -04:00
125e3e3d66
Localize time units on activity heatmap ( #21570 )
...
Previously, the months and days were hardcoded into English
* Closes #15541
## Screenshots
### English
### German
### Spanish
### Italian
### Portuguese
This one has a bit of overflow
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Gusted <williamzijl7@hotmail.com >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2022-10-28 09:48:24 -04:00
Yarden Shoham
3bd05172d5
[skip ci] Updated translations via Crowdin
2022-10-25 00:20:58 +00:00
Yarden Shoham and GitHub
fc1048a411
Add sqlite vscode extension to Gitpod configuration ( #21552 )
...
It allows for quick database inspections in the IDE.
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-24 16:55:59 -04:00
Yarden Shoham and GitHub
c04ad7632f
Use recommended vscode configuration in gitpod environments ( #21537 )
...
To make go tests run in gitpod, the vscode settings.json must be in the
correct place in the filesystem
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-24 02:24:33 +01:00
578b43ddb5
Add yardenshoham to maintainers ( #21566 )
...
[List of merged
PRs](https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Ayardenshoham+is%3Amerged )
(with many more on the way!)
Co-authored-by: Lauris BH <lauris@nix.lv >
2022-10-23 12:09:21 -04:00
88a03a6133
Link mentioned user in markdown only if they are visible to viewer ( #21554 )
...
We need to make sure a user can't confirm the existence of a user with
private visibility
* Follow up on #21533
### Before
#### User
#### Admin
### After
#### User
#### Admin
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-10-23 17:13:52 +08:00
63ebb53fd5
Add link to user profile in markdown mention only if user exists ( #21533 )
...
Previously mentioning a user would link to its profile, regardless of
whether the user existed. This change tests if the user exists and only
if it does - a link to its profile is added.
* Fixes #3444
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-10-23 01:15:52 +08:00
2c77d4b195
Remove unnecessary debug log ( #21536 )
...
It distractingly shows up on unit tests
* Looks like a leftover from #20571
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-10-22 15:25:34 +08:00
e828564445
Add color previews in markdown ( #21474 )
...
* Resolves #3047
Every time a color code will be in \`backticks`, a cute little color
preview will pop up
[Inspiration](https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#supported-color-models )
#### Before
#### After
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-10-21 20:00:53 +08:00
acdb92ad42
Localize all timestamps ( #21440 )
...
Following
* #21410
We are now able to localize all timestamps. Some examples:
`short-date` format, French, user profile page:
`date-time` format, Portuguese, mirror repository settings page:
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Gusted <williamzijl7@hotmail.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2022-10-17 12:08:21 +08:00
bc53256316
Use own Go version instead of hardcoded 1.17 for make fmt ( #21457 )
...
We should make sure we're using the same version across the codebase.
* We upgraded in #19918 but forgot about the following line
https://github.com/go-gitea/gitea/blob/6bb6a108e0c03b323402b452fc05c6845f7d00df/build/code-batch-process.go#L273
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
2022-10-15 21:10:25 +01:00
b9cd6fb703
Add code highlighting in issue titles ( #21432 )
...
This changes the rendering logic of issue titles. If a substring in an
issue title is enclosed with a pair of backticks, it'll be rendered with
a monospace font (HTML `code` tag).
* Closes #20887
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Gusted <williamzijl7@hotmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
2022-10-16 02:24:41 +08:00
671c609c46
Add wording about keeping PRs up-to-date in CONTRIBUTING.md ( #21468 )
...
Following a discord discussion from today I've written the policy
explained to me about keeping PRs up-to-date.
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: techknowlogick <techknowlogick@gitea.io >
2022-10-15 12:41:24 -04:00
Yarden Shoham
7917123209
[skip ci] Updated translations via Crowdin
2022-10-15 00:21:30 +00:00
Yarden Shoham and GitHub
94d6d93cc2
Fix Drone pushing commits with wrong author info ( #21450 )
...
I don't know how to test this so I'll explain my thought process:
After a discussion with @techknowlogick in
https://github.com/go-gitea/gitea/commit/cda2c38f4a61ef7f448be3efab5420d9974c8474
I saw the CI config has this block:
https://github.com/go-gitea/gitea/blob/cda2c38f4a61ef7f448be3efab5420d9974c8474/.drone.yml#L618-L630
I don't know much about Drone but after looking at
[appleboy/drone-git-push](https://github.com/appleboy/drone-git-push )'s
source code, I think each setting becomes an environment variable (e.g.
`remote` to `PLUGIN_REMOTE`, `commit_message` to `PLUGIN_COMMIT_MESSAGE`
etc...). Take a look at the code block loading the author info:
https://github.com/appleboy/drone-git-push/blob/a69878c00665277c53fb38d6c5980221cb687935/main.go#L32-L42
Two environment variables are listed for each setting. This PR forces
both to have the same value.
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-14 15:09:04 -04:00
Yarden Shoham and GitHub
6bb6a108e0
Add vitest tests to Gitpod ( #21449 )
...
The vitest PR is merged, we can now add vitest to Gitpod's testing pane
* #21444
We couldn't use jest in the same manner because we had to customize
`NODE_OPTIONS`.
Screenshot (look at all the cool stuff circled in red):
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-14 11:22:57 -04:00
Yarden Shoham and GitHub
c4f7c96903
Run make fmt ( #21437 )
...
The only change is what `make fmt` did, I am merely a vessel for its
glorious function
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-13 21:33:54 -04:00
Yarden Shoham
cda2c38f4a
[skip ci] Updated translations via Crowdin
2022-10-13 00:21:26 +00:00
6a6dc97b0f
Respect user's locale when rendering the date range in the repo activity page ( #21410 )
...
# Description
Previously, to make the date range understood by all, we used the format
"2006-01-02" for the dates as it's locale-generic.
This commit changes the rendering logic. Instead of rendering the date
on the server, we send a formatted computer-readable timestamp. The
client's javascript then renders it according to the user's locale.
This approach is reusable across the codebase, any `<time></time>` tag
with the data-format="date" attribute would get rendered according to
the user's chosen locale.
## Previous View
## New View
### English
### French
### Portuguese
### Italian
# References
* #21380
* #21387
* #21396
Inspiration:
I think either differentiating by class, or probably better by a custom
attribute such as `data-format` or similar, is the best course of
action.
_Originally posted by @delvh in
https://github.com/go-gitea/gitea/issues/21396#issuecomment-1274424788_
Resolves #21380
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: silverwind <me@silverwind.io >
2022-10-13 00:14:14 +03:00
b474730cf6
Refactor Gitpod configuration to improve quick spin up of automated dev environments ( #21411 )
...
This commit instructs Gitpod to run `docs` in watch mode in fresh
development environments so any dev could start hacking in seconds.
Also included some vscode extensions for Vue, Go, and Docker.
Try it here:
[](https://gitpod.io/#https://github.com/yardenshoham/gitea/tree/gitpod )
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
Co-authored-by: Gusted <williamzijl7@hotmail.com >
2022-10-12 12:17:04 -04:00
Yarden Shoham and GitHub
b5a54f03a2
Fix broken link to frontend guidelines in hacking guidelines ( #21382 )
2022-10-11 21:23:21 -04:00
Yarden Shoham and GitHub
9b7675d0cf
Remove cancel button in repo creation page ( #21381 )
2022-10-11 22:47:35 +08:00
Yarden Shoham and GitHub
2d4c6321c3
Use ISO date format instead of hard-coded English date format for date range in repo activity page ( #21396 )
...
January 2, 2006 -> 2006-01-02
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-11 18:48:17 +08:00
Yarden Shoham and GitHub
083ac164dc
Fix missing left and right carets in TRANSLATORS ( #21397 )
2022-10-10 10:36:37 -04:00
Yarden Shoham and GitHub
97f3f1988b
Fix typos in PullRequestMergeForm.vue header comment ( #21378 )
...
Signed-off-by: Yarden Shoham <hrsi88@gmail.com >
2022-10-09 15:17:01 +08:00
