mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	_This is a different approach to #20267, I took the liberty of adapting some parts, see below_ ## Context In some cases, a weebhook endpoint requires some kind of authentication. The usual way is by sending a static `Authorization` header, with a given token. For instance: - Matrix expects a `Bearer <token>` (already implemented, by storing the header cleartext in the metadata - which is buggy on retry #19872) - TeamCity #18667 - Gitea instances #20267 - SourceHut https://man.sr.ht/graphql.md#authentication-strategies (this is my actual personal need :) ## Proposed solution Add a dedicated encrypt column to the webhook table (instead of storing it as meta as proposed in #20267), so that it gets available for all present and future hook types (especially the custom ones #19307). This would also solve the buggy matrix retry #19872. As a first step, I would recommend focusing on the backend logic and improve the frontend at a later stage. For now the UI is a simple `Authorization` field (which could be later customized with `Bearer` and `Basic` switches):  The header name is hard-coded, since I couldn't fine any usecase justifying otherwise. ## Questions - What do you think of this approach? @justusbunsi @Gusted @silverwind - ~~How are the migrations generated? Do I have to manually create a new file, or is there a command for that?~~ - ~~I started adding it to the API: should I complete it or should I drop it? (I don't know how much the API is actually used)~~ ## Done as well: - add a migration for the existing matrix webhooks and remove the `Authorization` logic there _Closes #19872_ Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Gusted <williamzijl7@hotmail.com> Co-authored-by: delvh <dev.lh@web.de>
		
			
				
	
	
		
			214 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			214 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2016 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package org
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 
 | |
| 	"code.gitea.io/gitea/models/webhook"
 | |
| 	"code.gitea.io/gitea/modules/context"
 | |
| 	"code.gitea.io/gitea/modules/convert"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/modules/web"
 | |
| 	"code.gitea.io/gitea/routers/api/v1/utils"
 | |
| )
 | |
| 
 | |
| // ListHooks list an organziation's webhooks
 | |
| func ListHooks(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /orgs/{org}/hooks organization orgListHooks
 | |
| 	// ---
 | |
| 	// summary: List an organization's webhooks
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: org
 | |
| 	//   in: path
 | |
| 	//   description: name of the organization
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: page
 | |
| 	//   in: query
 | |
| 	//   description: page number of results to return (1-based)
 | |
| 	//   type: integer
 | |
| 	// - name: limit
 | |
| 	//   in: query
 | |
| 	//   description: page size of results
 | |
| 	//   type: integer
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/HookList"
 | |
| 
 | |
| 	opts := &webhook.ListWebhookOptions{
 | |
| 		ListOptions: utils.GetListOptions(ctx),
 | |
| 		OrgID:       ctx.Org.Organization.ID,
 | |
| 	}
 | |
| 
 | |
| 	count, err := webhook.CountWebhooksByOpts(opts)
 | |
| 	if err != nil {
 | |
| 		ctx.InternalServerError(err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	orgHooks, err := webhook.ListWebhooksByOpts(ctx, opts)
 | |
| 	if err != nil {
 | |
| 		ctx.InternalServerError(err)
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	hooks := make([]*api.Hook, len(orgHooks))
 | |
| 	for i, hook := range orgHooks {
 | |
| 		hooks[i], err = convert.ToHook(ctx.Org.Organization.AsUser().HomeLink(), hook)
 | |
| 		if err != nil {
 | |
| 			ctx.InternalServerError(err)
 | |
| 			return
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	ctx.SetTotalCountHeader(count)
 | |
| 	ctx.JSON(http.StatusOK, hooks)
 | |
| }
 | |
| 
 | |
| // GetHook get an organization's hook by id
 | |
| func GetHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation GET /orgs/{org}/hooks/{id} organization orgGetHook
 | |
| 	// ---
 | |
| 	// summary: Get a hook
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: org
 | |
| 	//   in: path
 | |
| 	//   description: name of the organization
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to get
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	org := ctx.Org.Organization
 | |
| 	hookID := ctx.ParamsInt64(":id")
 | |
| 	hook, err := utils.GetOrgHook(ctx, org.ID, hookID)
 | |
| 	if err != nil {
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	apiHook, err := convert.ToHook(org.AsUser().HomeLink(), hook)
 | |
| 	if err != nil {
 | |
| 		ctx.InternalServerError(err)
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.JSON(http.StatusOK, apiHook)
 | |
| }
 | |
| 
 | |
| // CreateHook create a hook for an organization
 | |
| func CreateHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation POST /orgs/{org}/hooks organization orgCreateHook
 | |
| 	// ---
 | |
| 	// summary: Create a hook
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: org
 | |
| 	//   in: path
 | |
| 	//   description: name of the organization
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   required: true
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/CreateHookOption"
 | |
| 	// responses:
 | |
| 	//   "201":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	form := web.GetForm(ctx).(*api.CreateHookOption)
 | |
| 	// TODO in body params
 | |
| 	if !utils.CheckCreateHookOption(ctx, form) {
 | |
| 		return
 | |
| 	}
 | |
| 	utils.AddOrgHook(ctx, form)
 | |
| }
 | |
| 
 | |
| // EditHook modify a hook of a repository
 | |
| func EditHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation PATCH /orgs/{org}/hooks/{id} organization orgEditHook
 | |
| 	// ---
 | |
| 	// summary: Update a hook
 | |
| 	// consumes:
 | |
| 	// - application/json
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: org
 | |
| 	//   in: path
 | |
| 	//   description: name of the organization
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to update
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// - name: body
 | |
| 	//   in: body
 | |
| 	//   schema:
 | |
| 	//     "$ref": "#/definitions/EditHookOption"
 | |
| 	// responses:
 | |
| 	//   "200":
 | |
| 	//     "$ref": "#/responses/Hook"
 | |
| 
 | |
| 	form := web.GetForm(ctx).(*api.EditHookOption)
 | |
| 
 | |
| 	// TODO in body params
 | |
| 	hookID := ctx.ParamsInt64(":id")
 | |
| 	utils.EditOrgHook(ctx, form, hookID)
 | |
| }
 | |
| 
 | |
| // DeleteHook delete a hook of an organization
 | |
| func DeleteHook(ctx *context.APIContext) {
 | |
| 	// swagger:operation DELETE /orgs/{org}/hooks/{id} organization orgDeleteHook
 | |
| 	// ---
 | |
| 	// summary: Delete a hook
 | |
| 	// produces:
 | |
| 	// - application/json
 | |
| 	// parameters:
 | |
| 	// - name: org
 | |
| 	//   in: path
 | |
| 	//   description: name of the organization
 | |
| 	//   type: string
 | |
| 	//   required: true
 | |
| 	// - name: id
 | |
| 	//   in: path
 | |
| 	//   description: id of the hook to delete
 | |
| 	//   type: integer
 | |
| 	//   format: int64
 | |
| 	//   required: true
 | |
| 	// responses:
 | |
| 	//   "204":
 | |
| 	//     "$ref": "#/responses/empty"
 | |
| 
 | |
| 	org := ctx.Org.Organization
 | |
| 	hookID := ctx.ParamsInt64(":id")
 | |
| 	if err := webhook.DeleteWebhookByOrgID(org.ID, hookID); err != nil {
 | |
| 		if webhook.IsErrWebhookNotExist(err) {
 | |
| 			ctx.NotFound()
 | |
| 		} else {
 | |
| 			ctx.Error(http.StatusInternalServerError, "DeleteWebhookByOrgID", err)
 | |
| 		}
 | |
| 		return
 | |
| 	}
 | |
| 	ctx.Status(http.StatusNoContent)
 | |
| }
 |