mirror of
https://github.com/go-gitea/gitea
synced 2025-11-03 04:48:25 +00:00
f63822fe64
The "autofocus" was abused or misbehaved:
1. When users visit a page but they are not going to change a field,
then the field shouldn't get "autofocus"
* the "auth" / "user" page: in most cases, users do not want to change
the names
* see also the GitHub's "settings" page behavior.
2. There shouldn't be duplicate "autofocus" inputs in most cases, only
the first one focuses
3. When a panel is shown, the "autofocus" should get focus
* "add ssh key" panel
This PR fixes all these problems and by the way remove duplicate
"isElemHidden" function.
68 lines
2.6 KiB
TypeScript
68 lines
2.6 KiB
TypeScript
import {isElemVisible, onInputDebounce, submitEventSubmitter, toggleElem} from '../utils/dom.ts';
|
|
import {GET} from '../modules/fetch.ts';
|
|
|
|
const {appSubUrl} = window.config;
|
|
const reIssueIndex = /^(\d+)$/; // eg: "123"
|
|
const reIssueSharpIndex = /^#(\d+)$/; // eg: "#123"
|
|
const reIssueOwnerRepoIndex = /^([-.\w]+)\/([-.\w]+)#(\d+)$/; // eg: "{owner}/{repo}#{index}"
|
|
|
|
// if the searchText can be parsed to an "issue goto link", return the link, otherwise return empty string
|
|
export function parseIssueListQuickGotoLink(repoLink: string, searchText: string) {
|
|
searchText = searchText.trim();
|
|
let targetUrl = '';
|
|
if (repoLink) {
|
|
// try to parse it in current repo
|
|
if (reIssueIndex.test(searchText)) {
|
|
targetUrl = `${repoLink}/issues/${searchText}`;
|
|
} else if (reIssueSharpIndex.test(searchText)) {
|
|
targetUrl = `${repoLink}/issues/${searchText.substring(1)}`;
|
|
}
|
|
} else {
|
|
// try to parse it for a global search (eg: "owner/repo#123")
|
|
const [_, owner, repo, index] = reIssueOwnerRepoIndex.exec(searchText) || [];
|
|
if (owner) {
|
|
targetUrl = `${appSubUrl}/${owner}/${repo}/issues/${index}`;
|
|
}
|
|
}
|
|
return targetUrl;
|
|
}
|
|
|
|
export function initCommonIssueListQuickGoto() {
|
|
const goto = document.querySelector<HTMLElement>('#issue-list-quick-goto');
|
|
if (!goto) return;
|
|
|
|
const form = goto.closest('form');
|
|
const input = form.querySelector<HTMLInputElement>('input[name=q]');
|
|
const repoLink = goto.getAttribute('data-repo-link');
|
|
|
|
form.addEventListener('submit', (e) => {
|
|
// if there is no goto button, or the form is submitted by non-quick-goto elements, submit the form directly
|
|
let doQuickGoto = isElemVisible(goto);
|
|
const submitter = submitEventSubmitter(e);
|
|
if (submitter !== form && submitter !== input && submitter !== goto) doQuickGoto = false;
|
|
if (!doQuickGoto) return;
|
|
|
|
// if there is a goto button, use its link
|
|
e.preventDefault();
|
|
window.location.href = goto.getAttribute('data-issue-goto-link');
|
|
});
|
|
|
|
const onInput = async () => {
|
|
const searchText = input.value;
|
|
// try to check whether the parsed goto link is valid
|
|
let targetUrl = parseIssueListQuickGotoLink(repoLink, searchText);
|
|
if (targetUrl) {
|
|
const res = await GET(`${targetUrl}/info`); // backend: GetIssueInfo, it only checks whether the issue exists by status code
|
|
if (res.status !== 200) targetUrl = '';
|
|
}
|
|
// if the input value has changed, then ignore the result
|
|
if (input.value !== searchText) return;
|
|
|
|
toggleElem(goto, Boolean(targetUrl));
|
|
goto.setAttribute('data-issue-goto-link', targetUrl);
|
|
};
|
|
|
|
input.addEventListener('input', onInputDebounce(onInput));
|
|
onInput();
|
|
}
|