mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-31 11:28:24 +00:00 
			
		
		
		
	This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
		
			
				
	
	
		
			47 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			47 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // SPDX-License-Identifier: MIT
 | |
| 
 | |
| package integration
 | |
| 
 | |
| import (
 | |
| 	"net/http"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	auth_model "code.gitea.io/gitea/models/auth"
 | |
| 	"code.gitea.io/gitea/models/unittest"
 | |
| 	user_model "code.gitea.io/gitea/models/user"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 	"code.gitea.io/gitea/services/convert"
 | |
| 	"code.gitea.io/gitea/tests"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAPITeamUser(t *testing.T) {
 | |
| 	defer tests.PrepareTestEnv(t)()
 | |
| 
 | |
| 	normalUsername := "user2"
 | |
| 	session := loginUser(t, normalUsername)
 | |
| 	token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeReadOrg)
 | |
| 	req := NewRequest(t, "GET", "/api/v1/teams/1/members/user1?token="+token)
 | |
| 	MakeRequest(t, req, http.StatusNotFound)
 | |
| 
 | |
| 	req = NewRequest(t, "GET", "/api/v1/teams/1/members/user2?token="+token)
 | |
| 	resp := MakeRequest(t, req, http.StatusOK)
 | |
| 	var user2 *api.User
 | |
| 	DecodeJSON(t, resp, &user2)
 | |
| 	user2.Created = user2.Created.In(time.Local)
 | |
| 	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user2"})
 | |
| 
 | |
| 	expectedUser := convert.ToUser(user, user)
 | |
| 
 | |
| 	// test time via unix timestamp
 | |
| 	assert.EqualValues(t, expectedUser.LastLogin.Unix(), user2.LastLogin.Unix())
 | |
| 	assert.EqualValues(t, expectedUser.Created.Unix(), user2.Created.Unix())
 | |
| 	expectedUser.LastLogin = user2.LastLogin
 | |
| 	expectedUser.Created = user2.Created
 | |
| 
 | |
| 	assert.Equal(t, expectedUser, user2)
 | |
| }
 |