yp05327 and GitHub
300b724abf
Leave MAINTAINERS and the organization ( #32820 )
...
## Why join
I didn’t talk about myself before, so some people may think that I am an
employee from the company. So I think it is necessary to talk about why
and how I joined.
At the begining, my boss gave me a task to find a git software which can
self hosted in on-premise. Then I found that there are not many project
which meet our needs. But finally, I found Gitea. A easy use, easy
maintenance, and without a good machine you can also run it.
At that time, I just finished my previous work which is using helm to
deploy something in K8s. So I tried to use Gitea’s helm chart to deploy
in my work PC to see whether we can use it. But soon, I found a bug, and
reported it (https://gitea.com/gitea/helm-chart/issues/382 ), but after
about 1 month, there’s no fix. So I try to check the source code, and I
found that it is caused by Gitea’s code and it is easy to fix it. So I
created an issue (https://github.com/go-gitea/gitea/issues/22523 ) in
Gitea. But unfortunately, after a long time again, it is still not
fixed. So I tried to finish it by myself.
I’m not a pro programmer, coding is just my hobby since I was 13 or 14
years old. (I will tell the reason later), I even don’t know the
workflow about the contribution of OSS, so maybe I did some bad things
at the early time, I apologize.
But the people here are very kind, at that time, I start to consider
whether it has worth to recommend to my boss. So I started to use it,
but I found more and more bugs in a short time. Japanese company is very
sensitive to it, so I gave up to recommend.
But I can try to fix them! Because I can learn too many things during
the contribution, not just about the programing but also the usage of
other tools and the general contribution rule in the world of OSS. It
let me grow up, and to become (maybe) a perfect full-stack engineer
which is my dream. (Why it is my dream? I made a wrong decision in my
college, I took/followed the advice of my parent, choosed communications
engineering instead of computer science which is my favorite thing)
# Why leave
Several days ago, there’s an
[article](https://juejin.cn/post/7446578471901626420#comment ) came into
my eye. Something about JiHu (GitLab Ltd in China) start to file a
lawsuit to the company which is using GitLab CE version which is under
MIT License. So people start to find other git service/application to
avoid it. And in the this article, a project called Fogejo is mentioned.
It says it is a hard-fork of Gitea. But I don’t know the meaning of
`hard-fork`, so I access the home page of this project to find where it
comes from.
Finally, I found it here:
https://forgejo.org/compare-to-gitea/#why-was-forgejo-created . They
said:
> As of early 2024, Forgejo is developed independently of Gitea, as a
“hard-fork”.
`hard-fork` has a quotation, so the meaning is not the original meaning
of it, but they said `as`, which means `like` or `similar` I think. So
just focus on the words before `as` is ok, because `hard-fork` is a
simile, `As of early 2024, Forgejo is developed independently of Gitea`
is what they want to say.
In my mind, this means:
since early 2024 Forgejo’s codes (new changes) are all written by
themselves, and emphasize that these changes are not related to Gitea,
because they can simply say `As of early 2024, Forgejo is developed
independently, as a “hard-fork”`
But after I check the commit history, I can still find some strange
commits in recent month:
https://codeberg.org/forgejo/forgejo/commits/branch/forgejo/search?q=author%3Ayp05327&all=
The author is me, but the commit is signed by someone I even never
heard.
Considering the words they said above, it feels/sounds like my work has
become their work. Although Gitea is under MIT license, is this allowed
in the OSS world?
Even it is allowed, I can not accept it personally.
So I created a issue to ask them:
https://codeberg.org/forgejo/forgejo/issues/6236
https://codeberg.org/forgejo/discussions/issues/251
Finally, it seems that they understood the problem and promised to
improve it. But I also required a public statement to explain it which
means they need to apologize, otherwise it is hard to the users who
believe these are all their work know it, and it seems they ignored some
of my words again? So it is hard for me to believe they will really make
changes and post the apologize. If they did, I will consider to come
back. Otherwise, I think there’s no worth to continually contribute to
any OSS project, so I decided to leave.
ps: TOC voting is still ongoing, please remove me from the list. And I
will leave the organization after the merge.
At the end, thanks to all people who have helped me to finish the
contribution and teach me new knowledges.
2024-12-16 00:38:18 +00:00
yp05327 and GitHub
d43620e7bc
Add is_archived option for issue indexer ( #32735 )
...
Try to fix #32697
Reason：
`is_archived` is already defined in the query options, but it is not
implemented in the indexer.
2024-12-12 07:33:31 +08:00
yp05327 and GitHub
2ac6f2b129
Fix internal server error when updating labels without write permission ( #32776 )
...
Fix #32775
if permission denined, `prepareForReplaceOrAdd` will return nothing, and
this case is not handled.
2024-12-10 18:42:52 +00:00
yp05327 and GitHub
2d13eafd69
Remove unnecessary border in repo home page sidebar ( #32767 )
2024-12-09 15:30:16 +08:00
faf5705d29
GitHub like repo home page ( #32213 )
...
Move some components (description, license, release, language stats) to sidebar
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-12-06 14:29:04 +00:00
yp05327 and GitHub
690d07470c
Fix word overflow in file search page ( #32695 )
2024-12-03 16:52:25 +00:00
dd1f67491f
Fix the missing menu in organization project view page ( #32313 )
...
#29248 didn't modify the view page.
The class name is not good enough, so this is a quick fix.
Before:
org:
user:
After:
org:
user: (no change)
Co-authored-by: Giteabot <teabot@gitea.io >
2024-10-30 19:05:40 +00:00
yp05327 and GitHub
7cf611d197
Fix broken image when editing comment with non-image attachments ( #32319 )
...
Fix #32316
2024-10-23 17:39:10 +02:00
yp05327 and GitHub
5d6d025c9b
Add support for searching users by email ( #30908 )
...
Fix #30898
we have an option `SearchByEmail`, so enable it, then we can search user
by email.
Also added a test for it.
2024-10-04 17:45:06 +00:00
+1
70b7df0e5e
Support repo license ( #24872 )
...
Close #278
Close #24076
## Solutions:
- Use
[google/licenseclassifier](https://github.com/google/licenseclassifier/ )
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[go-license-detector](https://github.com/go-enry/go-license-detector ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167
Test result between
[google/licensecheck](https://github.com/google/licensecheck ) and
[google/licenseclassifier](https://github.com/google/licenseclassifier/ ):
https://github.com/go-gitea/gitea/pull/24872#issuecomment-1576092178
- Generate License Convert Name List to avoid import license templates
with same contents
Gitea automatically get latest license data from[
spdx/license-list-data](https://github.com/spdx/license-list-data ).
But unfortunately, some license templates have same contents. #20915
[click here to see the
list](https://github.com/go-gitea/gitea/pull/24872#issuecomment-1584141684 )
So we will generate a list of these license templates with same contents
and create a new file to save the result when using `make
generate-license`. (Need to decide the save path)
- Save License info into a new table `repo_license`
Can easily support searching repo by license in the future.
## Screen shot
Single License:
Multiple Licenses:
Triggers:
- [x] Push commit to default branch
- [x] Create repo
- [x] Mirror repo
- [x] When Default Branch is changed, licenses should be updated
Todo:
- [x] Save Licenses info in to DB when there's a change to license file
in the commit
- [x] DB Migration
- [x] A nominal test?
- [x] Select which library to
use(https://github.com/go-gitea/gitea/pull/24872#issuecomment-1560361167 )
- [x] API Support
- [x] Add repo license table
- ~Select license in settings if there are several licenses(Not
recommended)~
- License board(later, not in this PR)
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: Denys Konovalov <kontakt@denyskon.de >
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: 6543 <m.huber@kithara.com >
Co-authored-by: a1012112796 <1012112796@qq.com >
Co-authored-by: techknowlogick <techknowlogick@gitea.com >
2024-10-01 15:25:08 -04:00
yp05327 and GitHub
6fa962f409
Fix wrong status of Set up Job when first step is skipped ( #32120 )
...
Fix #32089
2024-09-24 18:34:08 +00:00
yp05327 and GitHub
eba6bfbe15
Fix 500 error when state params is set when editing issue/PR by API ( #31880 )
...
A quick fix for #31871
2024-09-02 02:08:27 +08:00
661a1e10f7
Fix sort order for organization home and user profile page ( #31921 )
...
Fix #31916
In #30876 , `sortOrder` has been changed into a map, but it is only
implemented in explore.
~~But it seems that size sort order has no effect from long long ago,~~
not directly caused by the PR above.
I think it is still caused by #29231 .
In #29231 , it merged the sort orders from
`templates/explore/repo_search.tmpl` and
`templates/admin/repo/search.tmpl`.
In `templates/admin/repo/search.tmpl`, it contains size sort orders, but
not in `templates/explore/repo_search.tmpl`, which is used in non-admin
pages.
So `order by size` is added from #29231 , but the handler was not added.
---------
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-09-01 16:55:05 +00:00
yp05327 and GitHub
7092402a2d
Add missing repository type filter parameters to pager ( #31832 )
...
Fix #31807
ps: the newly added params's value will be changed.
When the first time you selected the filter, the values of params will
be `0` or `1`
But in pager it will be `true` or `false`.
So do we have `boolToInt` function?
2024-08-15 16:34:24 +00:00
yp05327 and GitHub
75d0b61546
Fix the display of project type for deleted projects ( #31732 )
...
Fix : #31727
After:
2024-07-30 04:37:43 +00:00
yp05327 and GitHub
0a11bce87f
Fix Null Pointer error for CommitStatusesHideActionsURL ( #31731 )
...
Fix https://github.com/go-gitea/gitea/pull/30156#discussion_r1695247028
Forgot fixing it in #31719
2024-07-30 02:56:25 +00:00
yp05327 and GitHub
7b388630ec
Fix loadRepository error when access user dashboard ( #31719 )
2024-07-29 06:51:02 +00:00
yp05327 and GitHub
e0a408e6f3
Add permission check when creating PR ( #31033 )
...
user should be a collaborator of the base repo to create a PR
2024-07-29 02:21:22 +00:00
cc044818c3
Support delete user email in admin panel ( #31690 )
...
---------
Co-authored-by: Jason Song <i@wolfogre.com >
2024-07-25 18:11:04 +08:00
yp05327 and GitHub
e61e9a36b7
Fix PullRequestList.GetIssueIDs's logic ( #31352 )
...
fix a bug from #30490
`prs.GetIssueIDs()` will also be used in other places, e.g.
`InvalidateCodeComments`
so we should not add `if pr.Issue == nil` in it, or if `pr.Issue` is
already loaded, you will not get the issueID in the results list and
this is not an expected result.
So this will caused a bug:
before calling `InvalidateCodeComments`, all `pr.Issues` in `prs` are
loaded, so `issueIDs` in this function will always be `[]`.
2024-06-13 09:42:07 +00:00
yp05327 and GitHub
93570de496
Update air package path ( #31233 )
2024-06-04 13:00:44 +08:00
yp05327 and GitHub
fc641b3a28
Remove sqlite-viewer and using database client ( #31223 )
...
sqlite-viewer can not edit sqlite.
database client can connect to almost all common databases, which is
very useful I think. Of cause, it can edit sqlite.
https://marketplace.visualstudio.com/items?itemName=cweijan.vscode-database-client2
And for using sqlite, sqlite3 is required. So also added a new feature:
https://github.com/warrenbuckley/codespace-features
found from: https://containers.dev/features
2024-06-03 10:41:29 +00:00
daf2a4c047
Fix wrong display of recently pushed notification ( #25812 )
...
There's a bug in #25715 :
If user pushed a commit into another repo with same branch name, the
no-related repo will display the recently pushed notification
incorrectly.
It is simple to fix this, we should match the repo id in the sql query.
The latest commit is 2 weeks ago.
The notification comes from another repo with same branch name:
After:
In forked repo:
New PR Link will redirect to the original repo:
In the original repo:
New PR Link:
In the same repo:
New PR Link:
08/15 Update:
Follow #26257 , added permission check and logic fix mentioned in
https://github.com/go-gitea/gitea/pull/26257#discussion_r1294085203
2024/04/25 Update:
Fix #30611
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-05-21 17:00:35 +00:00
yp05327 and GitHub
e94723f2de
Fix incorrect default branch when adopt a repository ( #30912 )
...
Fix #30521
we should sync branches first, then detect default branch, or
`git_model.FindBranchNames` will always return empty list, and the
detection will be wrong.
2024-05-09 08:44:26 +00:00
yp05327 and GitHub
f7d2f695a4
Fix misspelling of mergable ( #30896 )
...
https://github.com/go-gitea/gitea/pull/25812#issuecomment-2099833692
Follow #30573
2024-05-08 16:11:43 +00:00
yp05327 and GitHub
ecd1d96f49
Add result check in TestAPIEditUser ( #29674 )
...
Fix #29514
There are too many usage of `NewRequestWithValues`, so there's no need
to check all of them.
Just one is enough I think.
2024-05-05 02:10:20 +00:00
yp05327 and GitHub
a50026e2f3
Fix no edit history after editing issue's title and content ( #30814 )
...
Fix #30807
reuse functions in services
2024-05-03 14:11:51 +08:00
2a3906d755
Improve job commit description ( #30579 )
...
Fix https://github.com/go-gitea/gitea/issues/30567
When job is a schedule:
When it is a normal one:
also add a 'space' behind `:`
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-26 02:22:45 +00:00
cb6814adad
Use action user as the trigger user of schedules ( #30581 )
...
Follow https://github.com/go-gitea/gitea/pull/30357
When user push to default branch, the schedule trigger user will be the
user.
When disable then enable action units in settings, the schedule trigger
user will be action user.
When repo is a mirror, the schedule trigger user will be action user. (
before it will return error, fixed by #30357 )
As scheduled job is a cron, the trigger user should be action user from
Gitea, not a real user.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-20 02:35:29 +02:00
yp05327 and GitHub
cf9061f44a
Fix empty field login_name in API response JSON when creating user ( #30511 )
...
Fix #30508
ps: if `sourceID` is not set, `LoginName` will be ignored
2024-04-16 13:13:00 +08:00
yp05327 and GitHub
2c80421243
Convert max file name length to 255 ( #30489 )
...
Quick/Partly fix #29907
In Linux and MacOS, by default the max file name length is 255.
In windows, it depends on the version and settings, and has no file name
length limitation, but has path length limitation.
By default it is 260, considering path length is longer than filename,
so I think it is ok to do this.
For Windows, see
https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
For Linux, see
https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13
For MacOS, see
https://discussions.apple.com/thread/254788848?sortBy=best
2024-04-15 19:08:31 +00:00
yp05327 and GitHub
af02b8a0e9
Fix network error when open/close organization/individual projects and redirect to project page ( #30387 )
...
Follow #27734
Updated:
Redirect to project page instead of project list page.
2024-04-13 16:17:01 +00:00
b4d86912ef
Fix mirror error when mirror repo is empty ( #30432 )
...
Fix #30424
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-13 03:01:02 +00:00
yp05327 and GitHub
96d31fe0a8
Avoid user does not exist error when detecting schedule actions when the commit author is an external user ( #30357 )
...
When repo is a mirror, and commit author is an external user, then
`GetUserByEmail` will return error.
reproduce/test:
- mirror Gitea to your instance
- disable action and enable it again, this will trigger
`DetectAndHandleSchedules`
ps: also follow #24706 , it only fixed normal runs, not scheduled runs.
2024-04-11 15:11:32 +08:00
yp05327 and GitHub
d872ce006c
Avoid running action when action unit is disabled after workflows detected ( #30331 )
...
Fix #30243
We only checking unit disabled when detecting workflows, but not in
runner `FetchTask`.
So if a workflow was detected when action unit is enabled, but disabled
later, `FetchTask` will still return these detected actions.
Global setting: repo.ENABLED and repository.`DISABLED_REPO_UNITS` will
not effect this.
2024-04-08 22:08:26 +08:00
yp05327 and GitHub
7d66b9ea65
Avoid showing Failed to change the default wiki branch if repo has no wiki when saving repo settings ( #30329 )
2024-04-08 19:43:23 +08:00
yp05327 and GitHub
6103623596
Fix DEFAULT_SHOW_FULL_NAME=false has no effect in commit list and commit graph page ( #30096 )
...
Fix #20446
This PR will fix the username in:
repo home page
repo commit list page
repo commit graph page
pr commit page
Will not fix:
wiki revisions page:
ps: the author name is `FullName` by default
2024-03-28 15:15:39 -04:00
yp05327 and GitHub
ce3c351226
Load attachments for code comments ( #30124 )
...
Fix #30103
ps: comments has `LoadAttributes`, but maybe considering performance
problem, we don't call it.
2024-03-27 04:44:26 +00:00
yp05327 and GitHub
274bc00ca2
Fix duplicate migrated milestones ( #30102 )
...
Fix #17567
2024-03-26 10:20:26 +00:00
yp05327 and GitHub
9cf0f0bb04
Fix gitea doctor will remove repo-avatar files when execute command storage-archives ( #30094 )
...
Fix #30037
2024-03-26 08:24:13 +00:00
yp05327 and GitHub
08aec2c20a
Fix panic for fixBrokenRepoUnits16961 ( #30068 )
...
2024-03-26 14:45:11 +08:00
13921569dd
Add muted class to author name in repo commit list ( #29989 )
...
Before:
After:
If repo is a mirror, external user's name will be white, but if user is
existed, then you will see blue names and white names together:
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-03-25 20:18:58 +00:00
yp05327 and GitHub
4bef1fb3e4
Update register application URL for GitLab ( #29959 )
...
Fix #26593
The old URL was updated 7 years ago. Maybe no need to hold it any more.
2024-03-21 15:48:13 +00:00
yp05327 and GitHub
98217b0340
Fix invalid link of the commit status when ref is tag ( #29752 )
...
Fix #29731
Caused by #24634
Also remove fixme.
ps: we can not fix the existed runs, as wrong refs are all recorded in
DB, and we can not know whether they are branch or tag:
2024-03-19 07:23:40 +00:00
ce085b26fc
Improve commit record's ui in comment list ( #26619 )
...
Before:
After:
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-03-14 19:01:16 +00:00
2da13675c0
Fix incorrect menu/link on webhook edit page ( #29709 )
...
Fix #29699
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-03-14 01:37:15 +00:00
8fc1a8f0eb
Fix inconsistent rendering of block mathematical expressions ( #29677 )
...
Fix #28735
GitHub render `\```math\``` ` as a block now.
Add `display` class will render it as a block.
After:
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-11 05:00:50 +00:00
b253463e95
bump python version to 3.12 in dev container ( #29670 )
...
The default version is 3.9.2, which is not supported by poetry.
---------
Co-authored-by: silverwind <me@silverwind.io >
2024-03-08 16:10:01 +01:00
yp05327 and GitHub
9dc8a6336e
Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize ( #29653 )
...
Fix #29506
2024-03-08 08:44:50 +00:00
yp05327 and GitHub
c6cc392b55
Fix wrong header of org project view page ( #29626 )
...
Follow #29248
The project view page still using `user/overview/header.tmpl`
Before:
After:
2024-03-06 10:23:27 +00:00
a2b0fb1a64
Fix wrong line number in code search result ( #29260 )
...
Fix #29136
Before: The result is a table and all line numbers are all in one row.
After: Use a separate table column for the line numbers.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-06 07:24:43 +00:00
yp05327 and GitHub
3f3335ae51
Add empty repo check in DetectAndHandleSchedules ( #29606 )
...
2024-03-05 14:47:07 +00:00
yp05327 and GitHub
9616dbec33
Fix workflow trigger event IssueChangeXXX bug ( #29559 )
...
Bugs from #29308
Follow #29467
partly fix #29558
2024-03-03 18:37:41 +00:00
yp05327 and GitHub
403766cd81
Ignore empty repo for CreateRepository in action notifier ( #29416 )
...
Fix #29415
2024-02-26 09:38:15 +00:00
f8c1efe944
Fix logic error from #28138 ( #29417 )
...
There's a miss in #28138 :
https://github.com/go-gitea/gitea/pull/28138/files#diff-2556e62ad7204a230c91927a3f2115e25a2b688240d0ee1de6d34f0277f37dfeR162
@lunny
Not sure about the impact of this, but it will only effect 1.22, and
maybe we should fix it ASAP.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-26 08:10:14 +00:00
yp05327 and GitHub
1a6e1cbada
Implement some action notifier functions ( #29173 )
...
Fix #29166
Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
2024-02-18 10:58:46 +00:00
yp05327 and GitHub
68227996a7
Fix broken following organization ( #29005 )
...
- following organization is broken from #28908
- add login check for the follow button in organization profile page
2024-02-17 13:13:37 +08:00
yp05327 and GitHub
8e2831611c
Fix gitea-action user avatar broken on edited menu ( #29190 )
...
Fix #29178
2024-02-16 09:50:20 +00:00
yp05327 and GitHub
78c48d8fdd
Fix can not select team reviewers when reviewers is empty ( #29174 )
...
Before:
After:
Is this a bug? Maybe we don't need to fix this, as it only occurs when
there's only one user in the organization. 🤔
2024-02-15 11:30:11 +00:00
yp05327 and GitHub
3aed8ae034
Fix default avatar image size in PR diff page ( #28971 )
...
Fix #28941
ps: didn't test. The repo is too big to migrate.
2024-02-02 10:01:11 +00:00
yp05327 and GitHub
b9f8d75e27
Avoid sending update/delete release notice when it is draft ( #29008 )
...
Fix #27157
2024-02-02 04:18:12 +00:00
yp05327 and GitHub
64faecefe1
Fix UI Spacing Errors in mirror settings ( #28990 )
2024-02-01 00:04:23 +00:00
yp05327 and GitHub
0b1a42ce0f
Fix doc img path in profile readme ( #28994 )
...
https://gitea.com/gitea/gitea-docusaurus/actions/runs/1007/jobs/0#jobstep-9-25
2024-01-31 21:32:17 +08:00
yp05327 and GitHub
b693611b35
Don't show new pr button when page is not compare pull ( #26431 )
...
Before:
After:
(TestOrg:test is a tag not branch)
Problem:
In the template, we will not add `compare pull` class when
`PageIsComparePull` is false.
https://github.com/go-gitea/gitea/blob/a370efc13f0e1ea309e324639832832bc14cb6dc/templates/repo/diff/compare.tmpl#L2
But in the js, we are using `.repository.compare.pull` to find the
button:
https://github.com/go-gitea/gitea/blob/a370efc13f0e1ea309e324639832832bc14cb6dc/web_src/js/features/repo-legacy.js#L552-L563
So, if `PageIsComparePull` is false, the `New Pull Request` button will
be there, but has no response when we click it.
2024-01-21 15:13:00 +00:00
yp05327 and GitHub
07ba4d9f87
Fix incorrect action duration time when rerun the job before executed once ( #28364 )
...
Fix #28323
Reason was mentioned here:
https://github.com/go-gitea/gitea/issues/28323#issuecomment-1841867298
### Changes: (maybe breaking)
We can rerun jobs in Gitea, so there will be some problems in
calculating duration time.
In this PR, I use the exist `Started` and `Stopped` column to record the
last run time instead of the total time,
and add a new `PreviousDuration` column to record the previous duration
time.
You can also check the cost time of last run:
2024-01-19 14:05:49 +00:00
yp05327 and GitHub
b60a7c3358
Return responseText instead of string in some functions ( #28836 )
...
Follow
https://github.com/go-gitea/gitea/pull/28796#issuecomment-1891727591
2024-01-19 10:45:23 +08:00
yp05327 and GitHub
4674aea25b
Fix display latest sync time for pull mirrors on the repo page ( #28841 )
...
Follow #28712
1. Missing Locale word `mirror_sync`
2. Maybe forgot checking the conflict from #27760
Before:
After:
2024-01-18 18:27:07 +08:00
yp05327 and GitHub
c7e4629c02
Fix nil pointer panic when exec some gitea cli command ( #28791 )
...
panic:
After:
2024-01-15 07:43:53 +00:00
ce0225c1b8
Forbid removing the last admin user ( #28337 )
...
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2024-01-15 06:51:43 +00:00
yp05327 and GitHub
b820019fec
Fix when private user following user, private user will not be counted in his own view ( #28037 )
...
Doer: asdasasdasasdasasdasasdasasdasasdasasdas (private user)
Followed: TestUser (public user)
Before:
(From doer's view)
(From followed user's view, can see doer)
After:
(From doer's view)
2024-01-15 05:43:14 +00:00
yp05327 and GitHub
dd5693387e
Add links to owner home page in explore ( #28341 )
...
User can select access repo or owner's home page.
Before:
After:
2024-01-05 03:34:35 +00:00
yp05327 and GitHub
4ea522fecf
Only check online runner when detecting matching runners in workflows ( #28286 )
...
Mentioned:
[#28277 ](https://github.com/go-gitea/gitea/issues/28277#issuecomment-1831325276 )
We should only check online runner when detecting matching runners in
workflows,
as if runner is not online, the workflow will not run.
2023-12-18 16:06:19 +00:00
yp05327 and GitHub
3849fd2ac2
Remove unnecessary forgot password link in delete user section ( #28355 )
...
Before:
<img width="458" alt="image"
src="https://github.com/go-gitea/gitea/assets/18380374/92815496-38cc-4bb9-9182-1509a72b07f6 ">
After:
2023-12-15 14:13:55 +00:00
yp05327 and GitHub
0abb5633e3
Fix commit status in repo list ( #28412 )
...
Before:
`TestOrg/testactions` does have commit status, but won't display in
`All`
After:
Same to #26179 .
2023-12-11 06:19:57 +00:00
yp05327 and GitHub
f4561c44b1
Fix incorrect run order of action jobs ( #28367 )
...
When we pick up a job, all waiting jobs should firstly be ordered by
update time,
otherwise when there's a running job, if I rerun an older job, the older
job will run first, as it's id is smaller.
2023-12-06 22:10:05 +00:00
yp05327 and GitHub
ec90ee61ef
Fix object does not exist error when checking citation file ( #28314 )
...
Fix #28264
`DataAsync()` will be called twice.
Caused by https://github.com/go-gitea/gitea/pull/27958 .
I'm sorry, I didn't completely remove all unnecessary codes.
2023-12-06 16:51:01 +08:00
yp05327 and GitHub
004ab3758c
Fix wrong link in protect_branch_name_pattern_desc ( #28313 )
...
The current href will link to
`https://domain/owner/repo/settings/branches/github.com/gobwas/glob `
2023-12-01 19:45:04 +08:00
yp05327 and GitHub
1ae33e0bad
Fix links in docs ( #28302 )
...
Close #28287
## How to test it in local
convert Makefile L34 into:
```
cd .tmp/upstream-docs && git clean -f && git reset --hard && git fetch origin pull/28302/head:pr28302 && git switch pr28302
```
2023-12-01 19:42:42 +08:00
yp05327 and GitHub
8572e71a7f
Fix issue will be detected as pull request when checking First-time contributor ( #28237 )
...
Fix #28224
2023-11-27 10:46:55 +00:00
yp05327 and GitHub
0a0e8200ec
Fix links in docs ( #28234 )
...
Follow #28191
Changes:
- `(doc/administration/config-cheat-sheet.md` is incorrect:
- remove `../../`
2023-11-27 00:34:40 -05:00
yp05327 and GitHub
ad9aac3975
Fix some incorrect links in docs ( #28191 )
...
https://gitea.com/gitea/gitea-docusaurus/actions/runs/661/jobs/0#jobstep-9-39
I noticed that there are many warning logs in building docs.
It is causing 404 in docs.gitea.com now, so we need to fix it.
And there are also some other problems in v1.19 which can not be done in
this PR.
ps: Are there any good methods to test this in local?
2023-11-24 13:57:09 +00:00
yp05327 and GitHub
4d0eba8e0a
Fix swagger title ( #28164 )
...
Don't know why there's a `.` behind. 🤔
2023-11-22 08:09:19 +00:00
yp05327 and GitHub
2d9b91aa24
Fix the description about the default setting for action in quick start document ( #28160 )
...
Since #27054 , Actions are enabled by default. so we should also edit the
document. 😃
ps: I think this should be backport to 1.21.0.
2023-11-22 02:11:22 +00:00
yp05327 and GitHub
d1acd7e9de
Do not display search box when there's no packages yet ( #28146 )
...
Before:
After:
2023-11-21 20:03:19 +00:00
yp05327 and GitHub
a6a674e26a
Add guide page to actions when there's no workflows ( #28145 )
...
Before:
After:
2023-11-21 08:27:33 +00:00
yp05327 and GitHub
976a9926d7
Fix no ActionTaskOutput table waring ( #28149 )
...
Reproduce:
- Create a new Gitea instance
- Register a runner
- Create a repo and add a workflow
- Check the log, you will see warnings:
It comes from:
The reason is that we forgot registering `ActionTaskOutput` model.
So `action_table_output` table will be missing in your db.
2023-11-21 08:02:51 +00:00
yp05327 and GitHub
eae555ff23
Remove autofocus in search box ( #28033 )
...
Mentioned here:
https://github.com/go-gitea/gitea/pull/27982#issuecomment-1807923026
2023-11-20 08:57:46 +00:00
yp05327 and GitHub
e88377470a
Fix project counter in organization/individual profile ( #28068 )
...
Fix #28052
Before:
After:
2023-11-18 11:02:42 +08:00
yp05327 and GitHub
83c30634a4
Add word break to the repo list in admin settings page ( #28034 )
...
Before:
After:
2023-11-14 04:58:01 +00:00
089ac06969
Improve profile for Organizations ( #27982 )
...
Fixes some problems in #27955 :
- autofocus of the search box
before:
if access the home page will jump to the search box
after:
will not jump to the search box
- incorrect display of overview tab
before:
after:
- improve the permission check to the private profile repo
In #26295 , we simply added access control to the private profile.
But if user have access to the private profile repo , we should also
display the profile.
- add a button which can jump to the repo list?
I agree @wxiaoguang 's opinion here:
https://github.com/go-gitea/gitea/pull/27955#issuecomment-1803178239
But it seems that this feature is sponsored.
So can we add a button which can quickly jump to the repo list or just
move profile to the `overview` page?
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-11-13 15:33:22 +01:00
yp05327 and GitHub
f48a863b99
Fix citation error when the file size is larger than 1024 bytes ( #27958 )
...
Mentioned in:
https://github.com/go-gitea/gitea/pull/27931#issuecomment-1798016960
Same to #25131 , so use the same method to fix this problem.
2023-11-08 06:40:12 +00:00
4a0103fa29
Add word-break to repo description in home page ( #27924 )
...
In #25315 , @denyskon fixed UI on mobile view.
But for the repo description, on desktop view there's no word-break.
So maybe we can just add `gt-word-break` to fix it on both mobile view
and desktop view.
Before:
desktop view:
mobile view:
After:
desktop view:
mobile view(almost same?)
---------
Co-authored-by: silverwind <me@silverwind.io >
2023-11-07 23:52:08 +00:00
yp05327 and GitHub
3a924fdc83
Add word break to release title ( #27942 )
...
Before:
After:
2023-11-07 10:53:04 +00:00
yp05327 and GitHub
7a2ff6c162
Fix edit topic UI ( #27925 )
...
Before:
desktop view:
mobile view:
after click `Save` btn:
refresh the page, you will see that `gt-m-0` is missing after save
topic:
After:
desktop view:
mobile view:
after click `Save` btn:
2023-11-06 09:23:50 +00:00
dcb648ee71
Add Hide/Show all checks button to commit status check ( #26284 )
...
Step one for a GitHub like commit status check ui:
Step two:
The design now will list all commit status checks which takes too much
space.
This is a pre-improve for #26247
---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2023-11-02 14:49:02 +00:00
yp05327 and GitHub
0e021cd33e
Fix display member unit in the menu bar if there are no hidden members in public org ( #27795 )
...
Follow #26363 .
I missed that org templates also using
`templates/user/overview/header.tmpl`.
You can confirm this problem in https://gitea.com/gitea/-/projects with
anonymous access.
Before: (no login)
After:
2023-10-30 09:11:16 +00:00
yp05327 and GitHub
f39256f035
Add word-break to organization name and description ( #26624 )
...
Fix #24318
Before:
After:
2023-10-25 10:40:39 +00:00
8abc1aae4a
Improve the list header in milestone page ( #27302 )
...
The ui of list header in milestone page is not same as issue and pr list
page.
And they are using different template codes which can be merged into
one.
Before:
After:
---------
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com >
2023-10-18 00:03:42 +00:00
yp05327 and GitHub
5a7ab86b98
Avoid run change title process when the title is same ( #27467 )
...
If user only changed the target branch or just did nothing and clicked
the `Save` button, you will see the change log as following:
This makes no sense, so we should check whether the title is surely
changed before run the `ChangeTitle`.
2023-10-06 18:00:53 +00:00
yp05327 and GitHub
393193a3e0
Fix repo count in org action settings ( #27245 )
...
Only in org action settings, repo count is missing
Before:
In other setting page:
After:
2023-09-29 15:46:07 +00:00
yp05327andGitHub
