Giteabot and charles
1f89763744
Fix commit_status problem when testing ( #29672 ) ( #29675 )
...
Backport #29672 by @charles7668
Close #29661
fix #29656
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com >
2024-03-08 16:04:23 +00:00
Lunny Xiao and Jason Song
a129c0c06c
Fix 500 when deleting account with incorrect password or unsupported login type ( #29579 ) ( #29656 )
...
Fix #26210
Backport #29579
Co-authored-by: Jason Song <i@wolfogre.com >
2024-03-08 15:43:57 +01:00
yp05327
bd7de0c4e4
Add empty repo check in DetectAndHandleSchedules ( #29606 ) ( #29659 )
...
Backport #29606
2024-03-08 09:50:04 +00:00
Giteabot and yp05327
6651d2d87a
Fix incorrect rendering csv file when file size is larger than UI.CSV.MaxFileSize ( #29653 ) ( #29663 )
...
Backport #29653 by @yp05327
Fix #29506
Co-authored-by: yp05327 <576951401@qq.com >
2024-03-08 09:13:58 +00:00
76b6754c3a
Fixing the issue when status check per rule matches multiple actions ( #29631 ) ( #29655 )
...
Backport #29631 by @charles7668
Close #29628
rule
```
Test / Build*
Test / Build *
Test / Build 2*
Test / Build 1*
```
rule2
```
Test / Build*
Test / Build 1*
```
rule3
```
Test / Build*
Test / Build 1*
NotExist*
```
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com >
Co-authored-by: Zettat123 <zettat123@gmail.com >
2024-03-08 13:24:32 +08:00
Giteabot and wxiaoguang
0b5a4e7db4
Use strict protocol check when redirect ( #29642 ) ( #29644 )
...
Backport #29642 by wxiaoguang
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-07 03:53:33 +00:00
silverwind
b6a2b9594a
Update Twitter Logo ( #29621 ) ( #29633 )
...
Backport https://github.com/go-gitea/gitea/pull/29621
<img width="430" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/9cf7b0a3-406b-4dd6-ab3d-d31a96b9335a ">
2024-03-06 17:41:23 +01:00
Giteabot and wxiaoguang
6ee58a0ac2
Avoid issue info panic ( #29625 ) ( #29632 )
...
Backport #29625 by wxiaoguang
Fix #29624
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-06 13:33:29 +00:00
wxiaoguang
2f1eb619bc
Avoid unexpected panic in graceful manager ( #29629 ) ( #29630 )
...
Backport #29629
2024-03-06 11:00:21 +00:00
9db426ad8c
Fix wrong line number in code search result ( #29260 ) ( #29623 )
...
Backport #29260 by @yp05327
Fix #29136
Before:
The result is a table and all line numbers are all in one row.
After:
~~Updated:~~
~~added `active` class to the target line.~~
Co-authored-by: yp05327 <576951401@qq.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-06 10:05:41 +01:00
techknowlogick
a8277cfc8f
bump protobuf module ( #29617 ) ( #29619 )
...
backport #29617
2024-03-06 13:16:35 +08:00
Lunny Xiao
5667ef9aab
Add missing database transaction for new issue ( #29490 ) ( #29607 )
...
When creating an issue, inserting issue, assign users and set project
should be in the same transaction.
Backport #29490
2024-03-05 16:37:55 +00:00
wxiaoguang
02df269d24
Make "/user/login" page redirect if the current user has signed in ( #29583 ) ( #29599 )
...
Backport #29583
2024-03-05 21:03:45 +08:00
wxiaoguang
4ef7e496b8
Add a trailing slash to dashboard links ( #29555 ) ( #29573 )
...
Backport #29555
2024-03-04 13:50:55 +08:00
Giteabot and yp05327
b519e4750b
Fix workflow trigger event IssueChangeXXX bug ( #29559 ) ( #29565 )
...
Backport #29559 by @yp05327
Bugs from #29308
Follow #29467
partly fix #29558
Co-authored-by: yp05327 <576951401@qq.com >
2024-03-04 04:34:46 +08:00
Giteabot and Nanguan Lin
b84303ef6e
Fix 500 when pushing release to an empty repo ( #29554 ) ( #29564 )
...
Backport #29554 by @lng2020
As title.
The former code directly used `ctx.Repo.GitRepo`, causing 500.
https://github.com/go-gitea/gitea/blob/22b4f0c09f1de5e581929bd10f39833d30d2c482/routers/api/v1/repo/release.go#L241
Co-authored-by: Nanguan Lin <nanguanlin6@gmail.com >
2024-03-03 17:10:22 +00:00
wxiaoguang
2b059f493e
Only use supported sort order for "explore/users" page ( #29430 ) ( #29443 )
...
Backport #29430
Thanks to inferenceus : some sort orders on the "explore/users" page
could list users by their lastlogintime/updatetime.
It leaks user's activity unintentionally. This PR makes that page only
use "supported" sort orders.
Removing the "sort orders" could also be a good solution, while IMO at
the moment keeping the "create time" and "name" orders is also fine, in
case some users would like to find a target user in the search result,
the "sort order" might help.
2024-03-03 02:28:45 +00:00
Giteabot and wxiaoguang
5ca2971ccb
Fix incorrect cookie path for AppSubURL ( #29534 ) ( #29552 )
...
Backport #29534
Regression of #24107
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-03 08:54:33 +08:00
Giteabot and Martin
63ec6facea
gitea.service: Remove syslog.target ( #29550 ) ( #29551 )
...
Backport #29550 by @C0rn3j
Remove syslog.target from service file, this target hasn't existed for
over a decade.
https://github.com/systemd/systemd/blob/6aa8d43ade72e24c9426e604f7fc4b7582b9db7c/NEWS#L72-L73
Co-authored-by: Martin <spleefer90@gmail.com >
2024-03-03 00:57:10 +01:00
Giteabot and wxiaoguang
971eab18fa
Fix incorrect redirection when creating a PR fails ( #29537 ) ( #29543 )
...
Backport #29537 by wxiaoguang
This is only a quick fix to make it easier to backport.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-02 20:01:19 +00:00
Giteabot
86cd94cba6
Fix queue worker incorrectly stopped when there are still more items in the queue ( #29532 ) ( #29546 )
...
Backport #29532
Without `case <-t.C`, the workers would stop incorrectly, the test won't
pass. For the worse case, there might be only one running worker
processing the queue items for long time because other workers are
stopped. The root cause is related to the logic of doDispatchBatchToWorker.
It isn't a serious problem at the moment, so keep it as-is.
2024-03-02 19:40:06 +00:00
Giteabot and wxiaoguang
8723389028
Fix incorrect relative/absolute URL usages ( #29531 ) ( #29547 )
...
Backport #29531 by wxiaoguang
Add two "HTMLURL" methods for PackageDescriptor.
And rename "FullWebLink" to "VersionWebLink"
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-02 18:00:15 +00:00
Giteabot and wxiaoguang
401cc394d5
Fix incorrect subpath in links ( #29535 ) ( #29541 )
...
Backport #29535 by wxiaoguang
* `$referenceUrl`: it is constructed by "Issue.Link", which already has
the "AppSubURL"
* `window.location.href`: AppSubURL could be empty string, so it needs
the trailing slash
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-02 12:26:54 +00:00
Giteabot and charles
3a8877c058
Fix issue link does not support quotes ( #29484 ) ( #29487 ) ( #29536 )
...
Backport #29487 by @charles7668
Close #29484
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com >
2024-03-02 19:37:45 +08:00
Giteabot and wxiaoguang
a86d9337e9
Fix issue & comment history bugs ( #29525 ) ( #29527 )
...
Backport #29525 by @wxiaoguang
* Follow #17746 : `HasIssueContentHistory` should use expr builder to
make sure zero value (0) be respected.
* Add "doer" check to make sure `canSoftDeleteContentHistory` only be
called by sign-in users.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-03-02 08:45:48 +08:00
Giteabot and sillyguodong
8d08558783
Set pre-step status to skipped if job is skipped ( #29489 ) ( #29523 )
...
Backport #29489 by @sillyguodong
close #27496
1. Set pre-step (Set up job) status to `skipped` if job is skipped.
2. Apart from pre-step, the other steps should also be set to `skipped`.
The status of other steps are reported from the runner side. This will
be completed by this PR: https://gitea.com/gitea/act_runner/pulls/500
before:
after:
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2024-03-01 14:51:54 +01:00
Giteabot and Jason Song
730cd2dee4
Update FAQ about git hook problems ( #29495 ) ( #29496 )
...
Backport #29495 by @wolfogre
Close
https://github.com/go-gitea/gitea/issues/29338#issuecomment-1970363817
Co-authored-by: Jason Song <i@wolfogre.com >
2024-02-29 22:36:00 +08:00
Giteabot and silverwind
65b9ffe3c0
Improve contrast on blame timestamp, fix double border ( #29482 ) ( #29485 )
...
Backport #29482 by @silverwind
Before, double border on top, bad contrast on dark:
<img width="155" alt="Screenshot 2024-02-29 at 02 06 17"
src="https://github.com/go-gitea/gitea/assets/115237/fc0f1e08-a5ce-47ed-9eb6-135eed5a1abb ">
<img width="126" alt="Screenshot 2024-02-29 at 02 07 28"
src="https://github.com/go-gitea/gitea/assets/115237/38ae8483-8d9b-484c-8909-d4466131ea16 ">
After, no double border on top, good contrast:
<img width="154" alt="Screenshot 2024-02-29 at 02 20 20"
src="https://github.com/go-gitea/gitea/assets/115237/ad91282b-e9f5-4f41-8f5e-6ba28db3beac ">
<img width="147" alt="Screenshot 2024-02-29 at 02 20 38"
src="https://github.com/go-gitea/gitea/assets/115237/7ee2ec92-e72a-4981-aec3-98fc8e579bae ">
Co-authored-by: silverwind <me@silverwind.io >
2024-02-29 08:51:42 +00:00
Giteabot and KN4CK3R
c293e34df0
Fix wrong test usage of AppSubURL ( #29459 ) ( #29488 )
...
Backport #29459 by @KN4CK3R
The tests use an invalid `setting.AppSubURL`. The wrong behaviour
disturbs other PRs like #29222 and #29427 .
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-29 14:40:35 +08:00
Giteabot and silverwind
9abba8c11a
Fix/Improve processWindowErrorEvent ( #29407 ) ( #29480 )
...
Backport #29407 by @silverwind
- `e.error` can be undefined in some cases which would raise an error
inside this error handler, fixed that.
- The displayed message mentions looking into the console, but in my
case of error from `ResizeObserver` there was nothing there, so add this
logging. I think this logging was once there but got lost during
refactoring.
Co-authored-by: silverwind <me@silverwind.io >
2024-02-29 01:22:53 +01:00
Giteabot and charles
5477728282
Fix counter display number incorrectly displayed on the page ( #29448 ) ( #29478 )
...
Backport #29448 by @charles7668
issue : #28239
The counter number script uses the 'checkbox' attribute to determine
whether an item is selected or not.
However, the input event only increments the counter value, and when
more items are displayed, it does not update all previously loaded
items.
As a result, the display becomes incorrect because it triggers the
update counter script, but checkboxes that are selected without the
'checked' attribute are not counted
Co-authored-by: charles <30816317+charles7668@users.noreply.github.com >
2024-02-28 23:13:49 +01:00
Giteabot and Zettat123
b43ce53a23
Fix workflow trigger event bugs ( #29467 ) ( #29475 )
...
Backport #29467 by @Zettat123
1. Fix incorrect `HookEventType` for issue-related events in
`IssueChangeAssignee`
2. Add `case "types"` in the `switch` block in `matchPullRequestEvent`
to avoid warning logs
Co-authored-by: Zettat123 <zettat123@gmail.com >
2024-02-28 21:24:51 +01:00
Giteabot and silverwind
222f93822e
Fix URL calculation in clone input box ( #29470 ) ( #29473 )
...
Backport #29470 by @silverwind
Ported the function as-is and added comments so we don't forget about
this in the future.
Fixes: https://github.com/go-gitea/gitea/issues/29462
Co-authored-by: silverwind <me@silverwind.io >
2024-02-28 15:25:53 +00:00
Giteabot and Zettat123
eabcfd3f7d
The job should always run when if is always() ( #29464 ) ( #29469 )
...
Backport #29464 by @Zettat123
Fix #27906
According to GitHub's
[documentation](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds ),
a job should always run when its `if` is `always()`
> If you would like a job to run even if a job it is dependent on did
not succeed, use the `always()` conditional expression in
`jobs.<job_id>.if`.
Co-authored-by: Zettat123 <zettat123@gmail.com >
2024-02-28 12:22:31 +01:00
Giteabot and Lunny Xiao
2df38af752
Fix missed return ( #29450 ) ( #29453 )
...
Backport #29450 by @lunny
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2024-02-27 23:33:03 +08:00
Lunny Xiao
dc48eb070b
Fix template bug ( #27581 ) ( #29446 )
...
Fix #29152
Backport #27581
2024-02-27 11:11:38 +00:00
Jason Song
06dc26167a
Update docs about DEFAULT_ACTIONS_URL ( #29442 ) ( #29445 )
...
Backport #29442 .
Follow #25581 .
2024-02-27 18:16:08 +08:00
Giteabot and sillyguodong
9456deb512
Not trigger all jobs any more, when re-running the first job ( #29439 ) ( #29441 )
...
Backport #29439 by @sillyguodong
Previously, it will be treated as "re-run all jobs" when `jobIndex ==
0`. So when you click re-run button on the first job, it triggers all
the jobs actually.
Caused by #26535 .
Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com >
2024-02-27 16:18:49 +08:00
Giteabot and yp05327
c758a8afba
Ignore empty repo for CreateRepository in action notifier ( #29416 ) ( #29424 )
...
Backport #29416 by @yp05327
Fix #29415
Co-authored-by: yp05327 <576951401@qq.com >
2024-02-26 09:59:12 +00:00
Giteabot and wxiaoguang
83327e043a
Fix incorrect tree path value for patch editor ( #29377 ) ( #29421 )
...
Backport #29377 by wxiaoguang
Regression of #18718 . When submitting the form,
EditRepoFileForm.TreePath is marked as "Required", so the value can't be
empty. The value is not used by backend, so use a meaningful dummy value
for it.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-02-26 09:26:23 +00:00
Lunny Xiao and wxiaoguang
78cb09deda
Change log for 1.21.7 ( #29411 )
...
This is an emergency release to fix the bug #29402 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-02-26 15:39:21 +08:00
Giteabot and KN4CK3R
0f35cb5a2a
Add missing space ( #29393 ) ( #29399 )
...
Backport #29393 by @KN4CK3R
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-26 00:08:44 +08:00
Giteabot and Tim-Niclas Oelschläger
0b3d6c399c
enforce maxlength in frontend ( #29389 ) ( #29396 )
...
Backport #29389 by @zokkis
Set maxlength attribute in frontend
to long file-name
(same for branch-name and commit-summary)
Co-authored-by: Tim-Niclas Oelschläger <72873130+zokkis@users.noreply.github.com >
2024-02-25 14:56:44 +00:00
Giteabot and Lunny Xiao
f98a1b851c
Users with read permission of pull requests can be assigned too ( #27263 ) ( #29372 )
...
Backport #27263 by @lunny
This PR will also keep the consistent between list assigned users and
check assigned users.
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2024-02-24 17:42:33 +01:00
e75594f7a6
Do not double close reader ( #29354 ) ( #29370 )
...
Backport #29354 by @KN4CK3R
Fixes #29346
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-02-24 12:08:06 +00:00
Lunny Xiao and KN4CK3R
a1c0b3a02e
Display friendly error message ( #29105 ) ( #29363 )
...
Backport #29105
`ctx.Error` only displays the text but `ctx.ServerError` renders the
usual error page.
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-24 11:01:18 +00:00
6624f257d3
Docker Tag Information in Docs ( #29047 ) ( #29362 )
...
Backport #29047
Add more details for the docker tag when using container registry.
Co-authored-by: wienans <40465543+wienans@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-24 10:41:10 +00:00
35db5a373b
Fix validity of the FROM email address not being checked ( #29347 ) ( #29360 )
...
Backport #29347 by @carlosfelgueiras
Fixes #27188 .
Introduces a check on the installation that tries to parse the FROM
address. If it fails, shows a new error message to the user.
Co-authored-by: Carlos Felgueiras <carlosfelgueiras@tecnico.ulisboa.pt >
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-02-24 08:23:21 +00:00
Lunny Xiao and yp05327
5043ad54c7
Fix project counter in organization/individual profile ( #28068 ) ( #29361 )
...
Fix #28052
Backport #28068
Before:
After:
Co-authored-by: yp05327 <576951401@qq.com >
2024-02-24 07:58:43 +00:00
wxiaoguang
727435743a
Fix incorrect tests in 1.21 ( #29366 )
...
The submitted tests in the patch for the XSS fix is not right.
To test, it should test "what should happen", but not "what doesn't
exist" or "what is processed/decoded".
2024-02-24 15:27:47 +08:00
Giteabotandcharles
Lunny XiaoandJason Song
yp05327
silverwind
techknowlogick
