99fef44280
Follow wxiaoguang's suggestion
2024-04-20 20:19:59 +08:00
20fbed7a67
Merge branch 'main' into lunny/fix_wrong_tablename
2024-04-19 19:50:16 +08:00
05674f7a38
Fix test
2024-04-19 19:50:06 +08:00
eb24d973b0
Fix project description rendering for org ( #30587 )
...
Fix #30263

Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-19 07:58:56 +00:00
fe82991547
Fix changelog (main) ( #30582 )
...
1. The 1.21.11 changelog is missing
2. Split the old content to CHANGELOG-archived.md, to reduce the size of
CHANGELOG.md
2024-04-19 06:08:30 +00:00
61457cdf6b
Avoid importing modules/web/middleware
in modules/session
( #30584 )
...
Related to #30375 .
It doesn't make sense to import `modules/web/middleware` and
`modules/setting` in `modules/web/session` since the last one is more
low-level.
And it looks like a workaround to call `DeleteLegacySiteCookie` in
`RegenerateSession`, so maybe we could reverse the importing by
registering hook functions.
2024-04-19 04:03:53 +00:00
acfe29fc2b
Enable npm cache on setup-node
action ( #30577 )
...
Enable npm dependency cache in
[setup-node](https://github.com/actions/setup-node ). This should work
reliably and across branches as well.
2024-04-19 03:29:08 +00:00
f8d57dcfa0
Add migration
2024-04-19 10:52:42 +08:00
ba9b124c34
[skip ci] Updated translations via Crowdin
2024-04-19 00:24:35 +00:00
bcbeb24dba
Mock queue backoff duration ( #30553 )
...
During testing, the backoff duration shouldn't be longer than other
durations
2024-04-18 20:00:59 +00:00
dd8e6ae270
Improve "Reference in new issue" modal ( #30547 )
...
Fixes: https://github.com/go-gitea/gitea/issues/29994
Also some misc enhancements done to the form in the modal.
<img width="840" alt="Screenshot 2024-04-17 at 23 02 55"
src="https://github.com/go-gitea/gitea/assets/115237/e71fba55-55cd-4e48-a497-6b1025c36a43 ">
2024-04-18 19:31:53 +00:00
354705450a
Add a few root files to lint-spell ( #30530 )
...
Files in root were not linted, add them. No new violations.
2024-04-18 18:54:40 +00:00
d0e0708355
Refactor and fix archive link bug ( #30535 )
...
Regression of #29920
Fixes : #30569
Also this is a rewriting to eliminate the remaining jQuery usages from code.
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-19 00:45:50 +08:00
86d4c8a466
Fixup app.example.ini for task section, which is now queue.task ( #30555 )
...
Config section `[task]` has been deprecated in favor of `[queue.task]`
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2024-04-18 19:22:06 +08:00
d1ba5f431b
Some following up changes for routes ( #30550 )
...
1. Switch back to the old order for `reqRepoAdmin, context.RepoRef()`
2. Add a routing function info for global NotFound
2024-04-18 09:36:19 +00:00
a5187260bf
Merge branch 'main' into lunny/fix_wrong_tablename
2024-04-18 17:11:07 +08:00
712ab94b23
Fix wrong fixture file name
2024-04-18 17:10:45 +08:00
d4ec6b3d16
Add form field id generation, remove duplicated ids ( #30546 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30384
On repo settings page, there id `repo_name` was used 5 times on the same
page, some in modal and such. I think we are better off just
auto-generating these IDs in the future so that labels link up with
their form element.
Ideally this id generation would be done in backend in a subtemplate,
but seeing that we already have similar JS patches for checkboxes, I
took the easy path for now.
I also checked that these `#repo_name` were not in use in JS and the
only case where this id appears in JS is on the migration page where
it's still there.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 09:01:06 +00:00
437cca7f6f
Fix the real problem
2024-04-18 16:39:21 +08:00
31538133c3
Fix border-radius on view, blame and code search ( #30545 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30540
1. Fix all these boxes by adding `bottom attached` and removing a
problematic CSS rule:
<img width="1319" alt="Screenshot 2024-04-17 at 22 25 31"
src="https://github.com/go-gitea/gitea/assets/115237/346445a4-4944-4003-a1ef-6f5b0eda624e ">
<img width="643" alt="Screenshot 2024-04-17 at 22 21 18"
src="https://github.com/go-gitea/gitea/assets/115237/10f17ed3-9ad6-48de-92fa-bac6621815b9 ">
2. Change the "last commit" box to `ui segment` which has correct
border-radius. Also included is a tiny tweak to make author name ellipse
instead of wrap.
<img width="1331" alt="Screenshot 2024-04-17 at 22 23 23"
src="https://github.com/go-gitea/gitea/assets/115237/285fbd45-ced0-4d33-abe3-7384ffa03188 ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 08:34:23 +00:00
7922845e70
Add test for the tablename
2024-04-18 16:33:52 +08:00
49b80f8ac1
Disable enter key for accepting code completion in Monaco ( #30548 )
...
Fixes https://github.com/go-gitea/gitea/issues/28114 and behaviour
matches vscode on desktop as well.
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-18 10:06:56 +02:00
59e020755f
Fix wrong table name
2024-04-18 15:59:04 +08:00
2da1dcfc21
Add an api test for updating user ( #30539 )
...
Fix #30518
2024-04-18 03:16:20 +00:00
ffc9879070
[skip ci] Updated translations via Crowdin
2024-04-18 00:26:04 +00:00
be5be0ac81
Expose fuzzy search for issues/pulls ( #29701 )
...
close #29685
---------
Signed-off-by: 6543 <6543@obermui.de >
Co-authored-by: silverwind <me@silverwind.io >
2024-04-18 00:16:52 +00:00
3feba9f1f4
Allow everyone to read or write a wiki by a repo unit setting ( #30495 )
...
Replace #6312
Help #5833
Wiki solution for #639
2024-04-17 15:58:37 +00:00
bafb80f80d
Support nuspec manifest download for nuget packages ( #28921 )
...
Support downloading nuget nuspec manifest[^1]. This is useful for
renovate because it uses this api to find the corresponding repository
- Store nuspec along with nupkg on upload
- allow downloading nuspec
- add doctor command to add missing nuspec files
[^1]:
https://learn.microsoft.com/en-us/nuget/api/package-base-address-resource#download-package-manifest-nuspec
---------
Co-authored-by: KN4CK3R <admin@oldschoolhack.me >
2024-04-17 15:30:41 +00:00
02e183bf3f
Fix branch_protection api shows users/teams who has no readAccess ( #30291 )
...
Add some logic in `convert.ToBranchProtection` to return only the names
associated with readAccess instead of returning all names. This will
ensure consistency in behavior between the frontend and backend.
Fixes : #27694
---------
Co-authored-by: techknowlogick <techknowlogick@gitea.com >
Co-authored-by: wenzhuo.zhang <wenzhuo.zhang@geely.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 15:24:07 +02:00
0798370f25
Correct locale string rendering ( #30522 )
...
Since #29165 , the translations are rendered as HTML in templates, so:
1. if the translation does contain `<>`, use `TrString`
2. use `{dummy}` instead of `<dummy>` as much as possible
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 10:24:08 +00:00
8e12ef911a
Run go generate
and go vet
on all packages ( #30529 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30512
I think this does mean those tools would run on a potential `vendor`
directory, but I'm not sure we really support vendoring of dependencies
anymore.
`release` has a `vendor` prerequisite so likely the source tarballs
contain vendor files?
2024-04-17 09:40:35 +00:00
311f5261cd
Fix and tweak pull request commit list ( #30528 )
...
Fixes https://github.com/go-gitea/gitea/issues/30493 , regression from
https://github.com/go-gitea/gitea/pull/30374 .
Also did the flexbox convertion as suggested by the existing comment.
<img width="850" alt="Screenshot 2024-04-16 at 22 28 48"
src="https://github.com/go-gitea/gitea/assets/115237/e8905944-620a-4211-b5c5-53ed3b3ee23e ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 08:58:08 +00:00
3e2e76e248
Refactor web routes ( #30519 )
...
Re-organize the routes in web.go and use ctx constants instead of `context.UnitTypes()`
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 08:31:37 +00:00
4f276a3363
Fix install page checkboxes and dropdown width ( #30526 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30523
1. Fix checkbox rendering
2. Fix width of selection dropdowns (was too small)
---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-17 15:30:46 +08:00
6f7d70fb3d
Reduce unnecessary database queries on actions table ( #30509 )
2024-04-17 01:25:03 +00:00
38147d020d
[skip ci] Updated translations via Crowdin
2024-04-17 00:24:47 +00:00
5ccd042f70
Tweak and fix toggle checkboxes ( #30527 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30524 . Slightly restyled
them so that the "knob" is contained inside the background.
<img width="179" alt="Screenshot 2024-04-16 at 21 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/be94517b-9cb7-46e2-ae96-fcf6767ce4ba ">
<img width="187" alt="Screenshot 2024-04-16 at 21 58 50"
src="https://github.com/go-gitea/gitea/assets/115237/c13a1959-5c5a-4e88-9225-e5f6fb72e3e0 ">
2024-04-17 00:39:19 +02:00
3746a625f5
Tweak repo buttons on mobile and labeled button border-radius ( #30503 )
...
Fixes: https://github.com/go-gitea/gitea/issues/30514
Fixes:
https://github.com/go-gitea/gitea/pull/30288#issuecomment-2057466623
- Fix border-radius regression from
https://github.com/go-gitea/gitea/pull/30475
- Fix and simplify hover state
- Move the modal HTML so it does not interfere with the CSS
- Make the star and unwatch text show on mobile. There is still plenty
of space, below is iPhone 12 viewport size
<img width="696" alt="Screenshot 2024-04-15 at 20 34 03"
src="https://github.com/go-gitea/gitea/assets/115237/af90bb00-4671-4973-a255-8eb44ee6ba8d ">
<img width="230" alt="Screenshot 2024-04-15 at 20 31 42"
src="https://github.com/go-gitea/gitea/assets/115237/986ef533-7a01-4bb0-8dcd-fd19e4259e84 ">
<img width="233" alt="Screenshot 2024-04-15 at 20 31 47"
src="https://github.com/go-gitea/gitea/assets/115237/5b825dd8-0ccc-4d56-9d8f-774abb935b68 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-16 17:46:12 +02:00
a658e2f277
Fix long branch name overflows ( #30345 )
...
Fixes: https://github.com/go-gitea/gitea/issues/27971
Fixes: https://github.com/go-gitea/gitea/pull/28010
<img width="689" alt="Screenshot 2024-04-09 at 00 19 57"
src="https://github.com/go-gitea/gitea/assets/115237/7c895a47-274f-40a6-a126-290658f1982d ">
Also fixes a similar issue in issue list where CSS was there but not
active because of missing `display: block`.
<img width="372" alt="Screenshot 2024-04-09 at 00 18 25"
src="https://github.com/go-gitea/gitea/assets/115237/cfbee7cd-2e15-4ac7-96ce-020816f48798 ">
2024-04-16 08:52:45 +00:00
58b204b813
Update API to return 'source_id' for users ( #29718 )
...
Using the API, a user's _source_id_ can be set in the _CreateUserOption_
model, but the field is not returned in the _User_ model.
This PR updates the _User_ model to include the field _source_id_ (The
ID of the Authentication Source).
2024-04-16 06:08:48 +00:00
6ba0c371c2
Allow preferred_username
as username source for OIDC ( #30454 )
...
This PR adds the preferred_username claim as a possible username source
for the oauth2_client.
Closes #21518
2024-04-16 05:41:39 +00:00
cf9061f44a
Fix empty field login_name
in API response JSON when creating user ( #30511 )
...
Fix #30508
ps: if `sourceID` is not set, `LoginName` will be ignored
2024-04-16 13:13:00 +08:00
c70e442ce4
feat(api): implement branch/commit comparison API ( #30349 )
...
- Add new `Compare` struct to represent comparison between two commits
- Introduce new API endpoint `/compare/*` to get commit comparison
information
- Create new file `repo_compare.go` with the `Compare` struct definition
- Add new file `compare.go` in `routers/api/v1/repo` to handle
comparison logic
- Add new file `compare.go` in `routers/common` to define `CompareInfo`
struct
- Refactor `ParseCompareInfo` function to use `common.CompareInfo`
struct
- Update Swagger documentation to include the new API endpoint for
commit comparison
- Remove duplicate `CompareInfo` struct from
`routers/web/repo/compare.go`
- Adjust base path in Swagger template to be relative (`/api/v1`)
GitHub API
https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#compare-two-commits
---------
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2024-04-16 11:45:04 +08:00
3b045ee165
[skip ci] Updated translations via Crowdin
2024-04-16 00:23:51 +00:00
b9f69b4a4d
Fix various overflows on actions view ( #30344 )
...
Fix a number of text overflow issues in actions view and run list. Also
improve mobile view of run list.
Fixes: https://github.com/go-gitea/gitea/issues/30328
<img width="782" alt="Screenshot 2024-04-08 at 23 10 16"
src="https://github.com/go-gitea/gitea/assets/115237/3d9f9f88-3eab-44a0-8144-30c2b58b24cb ">
<img width="935" alt="Screenshot 2024-04-08 at 23 17 46"
src="https://github.com/go-gitea/gitea/assets/115237/581d73ea-a31d-416b-be3a-47313b879b12 ">
<img width="1008" alt="Screenshot 2024-04-08 at 23 49 05"
src="https://github.com/go-gitea/gitea/assets/115237/c5d10565-f285-477f-8659-1caf94797647 ">
<img width="397" alt="Screenshot 2024-04-08 at 23 55 30"
src="https://github.com/go-gitea/gitea/assets/115237/368aaa75-1903-4058-9d75-d1fe91c564d6 ">
2024-04-15 19:46:52 +00:00
2c80421243
Convert max file name length to 255 ( #30489 )
...
Quick/Partly fix #29907
In Linux and MacOS, by default the max file name length is 255.
In windows, it depends on the version and settings, and has no file name
length limitation, but has path length limitation.
By default it is 260, considering path length is longer than filename,
so I think it is ok to do this.
For Windows, see
https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
For Linux, see
https://github.com/torvalds/linux/blob/master/include/uapi/linux/limits.h#L12-L13
For MacOS, see
https://discussions.apple.com/thread/254788848?sortBy=best
2024-04-15 19:08:31 +00:00
3b40ebf895
Remove active border on pointing menu ( #30486 )
...
It looks better when these menus don't flash a border-bottom on click.
2024-04-15 18:22:53 +00:00
2dc7e9e5fe
Fix button color on red and green buttons ( #30500 )
...
Previously these colors were provided by fomantic css. I missed them.
Fixes: https://github.com/go-gitea/gitea/issues/30499
Regressed by: https://github.com/go-gitea/gitea/pull/30475
2024-04-15 17:20:32 +00:00
c63060b130
Fix code owners will not be mentioned when a pull request comes from a forked repository ( #30476 )
...
Fix #30277
Caused by #29783
2024-04-15 16:11:07 +02:00
1508a85f62
Fix overflow on issue dependency ( #30484 )
...
Small tweak here to prevent this and likely other events from
overflowing in the timeline:
<img width="895" alt="Screenshot 2024-04-14 at 22 53 17"
src="https://github.com/go-gitea/gitea/assets/115237/001b4f6b-f649-44ff-b2f0-c8e0dedeb384 ">
Co-authored-by: Giteabot <teabot@gitea.io >
2024-04-15 10:49:48 +02:00